Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1460C54EAA for ; Mon, 30 Jan 2023 08:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235851AbjA3InG (ORCPT ); Mon, 30 Jan 2023 03:43:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbjA3InB (ORCPT ); Mon, 30 Jan 2023 03:43:01 -0500 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7F75126DB; Mon, 30 Jan 2023 00:43:00 -0800 (PST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1631b928691so14070869fac.11; Mon, 30 Jan 2023 00:43:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P6jHULr0UQaDIQzU8hyuuqTklxOoQZdGiuLMsSkhuWs=; b=S1Tm8H/OnWW4DfYurqncTbXVsh18VHwSVW3b9L68G3OSBalCsUkfOyvK2IDufkhqWV PlCJOXL4H2vycBSbKjXvEWfyJPALfVmo0njLpRuH9L05rvcXkFMFYlo90Q1WRUeFZA3T N8er15m3zIhotAzqYoEZz/yB6oVfT3bW03yZuIwTnue/qk4XCRig39972XUsZDHyWw8G ffOJIXju419cVI4FP1j4udAozox2ACumg4dTSZLDxzxvFkl4u/SfYFn8o9HCDljyM5HA XUgSLsiVdMNzPLjXinrwrFw4DZrPLJKHNCojH5cdMaeZ9cGQ3pc/u+FPO88tNJEi/ry3 nixA== X-Gm-Message-State: AO0yUKW3ub8jDm39uOhfj7w+TA6HUFBhijt2uLGJV+AOW/V1EJ4zABxM fWMswW51hlfcvYbEdvBijUDZ5u2h7g2ZJg== X-Google-Smtp-Source: AK7set/SYIL3y3Z8ZbL72BHPZj9eiDJ+EepfDjYiGnDYjfWs274lBCXLC9w8SNyJjrHN7JtOaIXoUg== X-Received: by 2002:a05:6870:9106:b0:163:ade9:27b4 with SMTP id o6-20020a056870910600b00163ade927b4mr2012832oae.26.1675068179567; Mon, 30 Jan 2023 00:42:59 -0800 (PST) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id bf34-20020a0568700a2200b001631914e41asm4890153oac.33.2023.01.30.00.42.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 00:42:59 -0800 (PST) Received: by mail-ot1-f52.google.com with SMTP id k91-20020a9d19e4000000b0068bca1294aaso1194275otk.8; Mon, 30 Jan 2023 00:42:59 -0800 (PST) X-Received: by 2002:a25:37d4:0:b0:80b:8602:f3fe with SMTP id e203-20020a2537d4000000b0080b8602f3femr2897020yba.36.1675068168732; Mon, 30 Jan 2023 00:42:48 -0800 (PST) MIME-Version: 1.0 References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-4-saravanak@google.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 30 Jan 2023 09:42:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, On Sat, Jan 28, 2023 at 8:19 AM Saravana Kannan wrote: > On Fri, Jan 27, 2023 at 12:11 AM Geert Uytterhoeven > wrote: > > On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan wrote: > > > The OF_POPULATED flag was set to let fw_devlink know that the device > > > tree node will not have a struct device created for it. This information > > > is used by fw_devlink to avoid deferring the probe of consumers of this > > > device tree node. > > > > > > Let's use fwnode_dev_initialized() instead because it achieves the same > > > effect without using OF specific flags. This allows more generic code to > > > be written in driver core. > > > > > > Signed-off-by: Saravana Kannan > > > > Thanks for your patch! > > > > > --- a/drivers/soc/renesas/rcar-sysc.c > > > +++ b/drivers/soc/renesas/rcar-sysc.c > > > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > > > > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > > > if (!error) > > > - of_node_set_flag(np, OF_POPULATED); > > > + fwnode_dev_initialized(&np->fwnode, true); > > > > As drivers/soc/renesas/rmobile-sysc.c is already using this method, > > it should work fine. > > > > Reviewed-by: Geert Uytterhoeven > > i.e. will queue in renesas-devel for v6.4. > > Thanks! Does that mean I should drop this from this series? If two > maintainers pick the same patch up, will it cause problems? I'm > eventually expecting this series to be picked up by Greg into > driver-core-next. Indeed. Patches for drivers/soc/renesas/ are supposed to go upstream through the renesas-devel and soc trees. This patch has no dependencies on anything else in the series (or vice versa), so there is no reason to deviate from that, and possibly cause conflicts later. BTW, I will convert to of_node_to_fwnode() while applying. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds