MIME-Version: 1.0
From:   Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date:   Mon, 30 Jan 2023 09:43:49 +0100
Message-ID: <CAKXUXMycsUQ3aWbAHa6fnSwmQpTt9PhagY14_k2sKGC+vGiqGg@mail.gmail.com>
Subject: Dependency on non-existing config I2C_DMI_CORE in commit a2f416bf062a
 ("HID: multitouch: Add quirks for flipped axes")
To:     Allen Ballway <ballway@chromium.org>, linux-input@vger.kernel.org
Cc:     Jiri Kosina <jkosina@suse.cz>, Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Dear Allen,

with commit a2f416bf062a ("HID: multitouch: Add quirks for flipped
axes"), you add code that is dependent on the CONFIG_I2C_DMI_CORE.
However, this config symbol has not been defined anywhere in the
kernel repository. Is this a mistake in your code and you intended to
refer to another config symbol? Is there another patch to come that
adds this config symbol? Or is this a config symbol that only exists
in some out-of-tree repository?

Something might be odd here, because this code is effectively dead now
with being dependent on a non-existing config symbol.

Best regards,

Lukas