MIME-Version: 1.0
References: <00000000000076699c05ed7c54a2@google.com> <00000000000091f75805f3627ddd@google.com>
In-Reply-To: <00000000000091f75805f3627ddd@google.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Mon, 30 Jan 2023 09:47:45 +0100
Message-ID: <CACT4Y+bUreYncw=xFEf_qvrKJ8GKgzstv8BF8LBWTD=XOj_vXw@mail.gmail.com>
Subject: Re: [syzbot] possible deadlock in btrfs_commit_transaction
To:     syzbot <syzbot+52d708a0bca2efc4c9df@syzkaller.appspotmail.com>
Cc:     anand.jain@oracle.com, clm@fb.com, dsterba@suse.com,
        hdanton@sina.com, josef@toxicpanda.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 29 Jan 2023 at 09:00, syzbot
<syzbot+52d708a0bca2efc4c9df@syzkaller.appspotmail.com> wrote:
>
> syzbot suspects this issue was fixed by commit:
>
> commit b740d806166979488e798e41743aaec051f2443f
> Author: Josef Bacik <josef@toxicpanda.com>
> Date:   Mon Nov 7 16:44:51 2022 +0000
>
>     btrfs: free btrfs_path before copying root refs to userspace
>
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=14e58bae480000
> start commit:   08ad43d554ba Merge tag 'net-6.1-rc7' of git://git.kernel.o..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=8d01b6e3197974dd
> dashboard link: https://syzkaller.appspot.com/bug?extid=52d708a0bca2efc4c9df
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=114d3e03880000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1320ea4b880000
>
> If the result looks correct, please mark the issue as fixed by replying with:
>
> #syz fix: btrfs: free btrfs_path before copying root refs to userspace
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Looks reasonable:

#syz fix: btrfs: free btrfs_path before copying root refs to userspace