Message-ID: <0177c346-d969-f8d2-6a31-e3ce570c8251@axis.com>
Date:   Mon, 30 Jan 2023 10:39:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3 2/3] ASoC: simple-card-utils: create jack inputs for
 aux_devs
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Astrid Rost <astrid.rost@axis.com>
CC:     Liam Girdwood <lgirdwood@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <kernel@axis.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20230123135913.2720991-1-astrid.rost@axis.com>
 <20230123135913.2720991-3-astrid.rost@axis.com>
 <Y9PBZjkW7Nrsg4j9@sirena.org.uk>
From:   Astrid Rost <astridr@axis.com>
In-Reply-To: <Y9PBZjkW7Nrsg4j9@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emFnczZuS1UvWXA4WkFVUmN2RTlQekRTR3RLVVYzZGZqUHNzeWV0RGN5MVAy?=
 =?utf-8?B?VFp4TVU0VFVHdDNYZ3hxSnR5R2tTUStnVithZHlENlVWQmZtOFhEbThLdm5l?=
 =?utf-8?B?L3pHYTJCZjNZS09xTkJpTUo2S3FGclpLVm85dG1XRzExbzBqeFUyKzJYcFJm?=
 =?utf-8?B?R2FFY0dSSTFTcWhpRmZoVzdvZ3NtcDVuY3ZvWWlKVlFKcDEvMXgzUTM2S3dv?=
 =?utf-8?B?SmJyZU9SS2JtaDJ6c1RtYWJKQmtTY2NJVldWbCtycDIxVTZYNUF6UUpzR3li?=
 =?utf-8?B?M1JNQlNydy9KcVhLenNPZU92WWsvd2h5Zy8yWGw3NFBZZUYzekg4Vk41aFgr?=
 =?utf-8?B?WEJCOFJPRzVUZ0VaWGJkamJYOHhoT014cnh1S0haT0d6amh0TSs0YlZhdjRF?=
 =?utf-8?B?Q0VUVTlqVnIrZWpFeGtqdmc5VFgrbVA5MVRCTnBlNEpDK21BK25NVVlpYThW?=
 =?utf-8?B?Y3Bzb01Eclh4emdFME1xOWlldndERU1kZzdlRTRyeTFLelpRRlo2YmFYUTF5?=
 =?utf-8?B?K3Axc2pKS3NtdDIraXNmWG5XaElRR1J0Mk83MUtxRlBDQXprcEtiSXFQTDMv?=
 =?utf-8?B?NnVGbFN4elBqKzJTUTBUU0RhMmgyUlorNDhYcURHQ0JBTmFKQ0dGVlpKUll4?=
 =?utf-8?B?S011ZXlnMFhTL2ZjUkxtcW1qa240M1JuVzlNVlRpclc4QTFQUTRHeThDWkZY?=
 =?utf-8?B?Q1ZGYUJVNzdrV2Y4VmRFOFVlM2E4d1RkYkFRamlRdUs4b0daMGFDQUoxNHFv?=
 =?utf-8?B?MDVsQU41TDVodDdZUmpZYytXbTk1bys1U1dOUHljTWFia3UrdE5IaVp4ampJ?=
 =?utf-8?B?OVJmeHpteVZORWpBSi83TmJRaTVIM0xML1ZWQzJMWnpLTHZReHo2MFNNeTVo?=
 =?utf-8?B?M2tra3VOcDJHL0Y0eXNUeWpjUTJHSUorV2RaSWJmNDN0S2dMV25xZERzdFdU?=
 =?utf-8?B?VmRMQ1dFR2JoODI3dHhjRDQydVNvREtIbkYwNlczVXZ3ZkZJTFRZR2wyTkVt?=
 =?utf-8?B?OEdpbEZjaStiSlJvdlNFVnN3eVozU1ExdUNkaXgyOWlpOFJTZjJtQ0JVbTBl?=
 =?utf-8?B?NHh6RURZSzhlUG9ZU1c4VUZvRDNCMm4wbHRneHRFeWlqSWowREZDcVVPSE10?=
 =?utf-8?B?WlhGZGpEVDQrRk1TWWQwc0ZDemZ4SkZJbnVWNnVaT20xemJtTDVtSmhsaXg3?=
 =?utf-8?B?NnJ3QW9GNHVTMVNmWHVxVk1qTUd6VDk2bDk2aUR5STU2cTBVdTY2UmUvc1Y1?=
 =?utf-8?B?NHJ1cmVIb1l6ZVB2ZG9Pd3gvcGp5RlpuTWlrbEU2SExNWGo5Z0VidGZiU0Vz?=
 =?utf-8?B?Smh1L2Vid0dCRUZCcUNGL0NXYi83ZGpyVFZnK0R5eWRFeWExcXljejRCbkZ2?=
 =?utf-8?B?UlBGaXMxeWJPZ2lKRG1uakV3NDNnbE5XZjlpUm90b2NlbjFFaGloMEhhT0Jz?=
 =?utf-8?B?K3F4eUxlcXNVNjk3T1J4ZVJpdVFsWFZFeExXQk1uU3lGL1lCa3hMbzdoYlJL?=
 =?utf-8?B?NnNtQzVWUGlkUHZJVEkyZGRjOVhNRnFDVHNRTm14di9UV0JELytBcWVmdFBG?=
 =?utf-8?B?cWJMRlN1Vk9xN1E1OS9IOG5mcnFxNjFHdEkyWWFXR3Y2dmF5K09DYnNBUXV3?=
 =?utf-8?B?Z0N5YVhoT0Vza2JTbjlKaGFQWnBiZENGekpqOWpibUlab0hldjZzTW1BYWdr?=
 =?utf-8?B?eHVpdHBWMm9qSHZwY3hOd0w3R1JRMjNXZ3RwQ0Q3QnNQcTdWbkhLYWc1TUVK?=
 =?utf-8?B?VWwwdGJBZk5DeFpxOEw3cGJIUnFXMUJhYWJ2QXBQa3o1ZmJ2YjlCb3I1dk9j?=
 =?utf-8?B?OURTdis3ZEw0WUxYWHYyRWwrVXMrRkVEOHZ5ajVUQzVoSXI3cjFOWS9Rb1Jv?=
 =?utf-8?B?c3VwR1dHa0ZWQjB5R1Jpa2FiM0hucEExZ1hqek5jMW10VytQVmVpcGNmdlRo?=
 =?utf-8?B?NmpoVmJBMHltdlBXWXlwKzlVUHY1RmdNQkN5aFgydlBzenpIcHY3SGpWMGxR?=
 =?utf-8?B?SHY1V0ZqcVUyK3V2VHJmZ0tnRDFTT2YvaSt2bE1neHRtZFcxVURyUkhZNnhT?=
 =?utf-8?B?RWNrOXlSM1l2MUQ0dVJxbWpWRFB6TGpaMUcxQ0JDTkUrRStKQXZEVlBNZnVv?=
 =?utf-8?Q?4rVKoN5aUBY9nW1R6wKACj+AH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29a3f2ae-e255-41ff-f0fc-08db02a5dd07
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB9467.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 09:39:20.5452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kpGw1rvw4yy1vJGHk3uPzSi7NTYhkCtbb+3lPwDqJ1NaY2wJFhBmAkM9OEoX3fw8VlYOsVDUpaV+k4fF5nCe6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB9291
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/27/23 13:19, Mark Brown wrote:
> On Mon, Jan 23, 2023 at 02:59:12PM +0100, Astrid Rost wrote:
>> Add a generic way to create jack inputs for auxiliary jack detection
>> drivers (e.g. via i2c, spi), which are not part of any real codec.
>> The simple-card can be used as combining card driver to add the jacks,
>> no new one is required.
>>
>> Create a jack (for input-events) for jack devices in the auxiliary
>> device list (aux_devs). A device which returns a valid value on
>> get_jack_type counts as jack device; set_jack is required
>> to add the jack to the device.
>>
>> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
>> ---
>>   include/sound/simple_card_utils.h     |  3 ++
>>   sound/soc/generic/simple-card-utils.c | 49 +++++++++++++++++++++++++++
>>   sound/soc/generic/simple-card.c       |  4 +++
>>   3 files changed, 56 insertions(+)
> 
> Given that everyone is really supposed to be using the
> audio-graph cards for new systems this should be hooked up there
> too.

Hello,

Yes auxiliary devices are very useful, e.g. for GPIO. I can make a patch
for audio-graph-card.c  to add it.

Best Regards

Astrid