Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA45C54EED for ; Mon, 30 Jan 2023 09:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236016AbjA3J5Z (ORCPT ); Mon, 30 Jan 2023 04:57:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235865AbjA3J5X (ORCPT ); Mon, 30 Jan 2023 04:57:23 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C5B030184; Mon, 30 Jan 2023 01:56:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D79B1B80EBC; Mon, 30 Jan 2023 09:55:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0EFFC433D2; Mon, 30 Jan 2023 09:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675072550; bh=eQum8BvEG4rRObKjEyM9pnllkgIf+dV5Kliwi0Rsi+c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FHmN+/PbSG5PwAgzwNbC8hurQsVAPj6HnhL0/z3e47qcwkRUkLP+haZXY7epqhnMd C9WNl8aEa81qRZeFOi6MNECfOjw/ZJSjuThkjHK3BV1qvaMdefvC/kJZbUHXfMJKGW mjI4G+OV+fQeKSLELtDB41n6l3I2gKCxAJRWDr88W/tS63FNJHzPx2MfdZ89cHWUby ebgncIc/PuuNf0EkF5qiyfstt0rnqBUus/R4rtSLcArLUvVBfun5AI1ieKcbIocm1A 6BgeLnjWMPQxLtPFwvcl/zL47fmaQt0YoCLaLMJVaZNdvluQY/bvx5jWoIGPhbEP2x +r555dEmKxPfg== Date: Mon, 30 Jan 2023 11:55:45 +0200 From: Leon Romanovsky To: Ratheesh Kannoth Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, sgoutham@marvell.com Subject: Re: [net-next PATCH] octeontx2-af: Removed unnecessary debug messages. Message-ID: References: <20230130035556.694814-1-rkannoth@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130035556.694814-1-rkannoth@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote: > From: Sunil Goutham > > NPC exact match feature is supported only on one silicon > variant, removed debug messages which print that this > feature is not available on all other silicon variants. > > Signed-off-by: Sunil Goutham > Signed-off-by: Ratheesh Kannoth > --- > .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > index f69102d20c90..ad1374a12a40 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_info(rvu->dev, "HW does not support secret key configuration\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), > @@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > npc_program_mkex_hash_rx(rvu, blkaddr, intf); > @@ -1854,16 +1850,12 @@ int rvu_npc_exact_init(struct rvu *rvu) > /* Check exact match feature is supported */ > npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); > if (!(npc_const3 & BIT_ULL(62))) { > - dev_info(rvu->dev, "%s: No support for exact match support\n", > - __func__); > return 0; > } You should remove () brackets here too. > > /* Check if kex profile has enabled EXACT match nibble */ > cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX)); > if (!(cfg & NPC_EXACT_NIBBLE_HIT)) { > - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n", > - __func__); > return 0; > } Same comment. > > -- > 2.25.1 >