Date:   Mon, 30 Jan 2023 10:14:25 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Jinyu Tang <tjytimi@163.com>
CC:     <palmer@rivosinc.com>, <paul.walmsley@sifive.com>,
        <palmer@dabbelt.com>, <yuzhao@google.com>,
        <ajones@ventanamicro.com>, <guoren@kernel.org>,
        <tongtiangen@huawei.com>, <anup@brainfault.org>,
        <akpm@linux-foundation.org>, <falcon@tinylab.org>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] riscv: support arch_has_hw_pte_young()
Message-ID: <Y9eYgSnTmI168933@wendy>
References: <20230129064956.143664-1-tjytimi@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="anvknZz1ArHLm8XG"
Content-Disposition: inline
In-Reply-To: <20230129064956.143664-1-tjytimi@163.com>
Precedence: bulk

--anvknZz1ArHLm8XG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 29, 2023 at 02:49:56PM +0800, Jinyu Tang wrote:
> The arch_has_hw_pte_young() is false for riscv by default. If it's
> false, page table walk is almost skipped for MGLRU reclaim. And it
> will also cause useless step in __wp_page_copy_user().
>=20
> RISC-V Privileged Book says that riscv have two schemes to manage A
> and D bit.
>=20
> So add a config for selecting, the default is true. For simple
> implementation riscv CPU which just generate page fault, unselect it.
>=20
> Signed-off-by: Jinyu Tang <tjytimi@163.com>
> ---
>  arch/riscv/Kconfig               | 10 ++++++++++
>  arch/riscv/include/asm/pgtable.h |  7 +++++++
>  2 files changed, 17 insertions(+)
>=20
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index e2b656043abf..17c82885549c 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -180,6 +180,16 @@ config PAGE_OFFSET
>  	default 0x80000000 if 64BIT && !MMU
>  	default 0xff60000000000000 if 64BIT
> =20
> +config ARCH_HAS_HARDWARE_PTE_YOUNG
> +	bool "Hardware Set PTE Access Bit"
> +	default y
> +	help
> +	  Select if hardware set A bit when PTE is accessed. The default is
> +	  'Y', because most RISC-V CPU hardware can manage A and D bit.
> +	  But RISC-V may have simple implementation that do not support
> +	  hardware set A bit but only generate page fault, for that case just
> +	  unselect it.

Hmm, I am not really sure if this is the right way to go. Should we
really be defaulting this option to enabled if there are going to be
implementations that do not support it?

Thanks,
Conor.


--anvknZz1ArHLm8XG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY9eYcgAKCRB4tDGHoIJi
0v50AP9BruHvX+Vp+nv8nNnUUgTJCFqXa+miF0OX6/LB2A5BlAEAtWmDrHHF+wUL
CZA1/N+0ovdarfkIEMX76O7HnBKe1QE=
=RCMS
-----END PGP SIGNATURE-----

--anvknZz1ArHLm8XG--