Date:   Mon, 30 Jan 2023 14:30:18 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Angel Iglesias <ang.iglesiasg@gmail.com>
Cc:     linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andreas Klinger <ak@it-klinger.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Add support for pressure sensor Bosch BMP580
Message-ID: <Y9e4WviD+Lmiin9T@smile.fi.intel.com>
References: <cover.1674954271.git.ang.iglesiasg@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1674954271.git.ang.iglesiasg@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sun, Jan 29, 2023 at 02:33:02AM +0100, Angel Iglesias wrote:
> This patchset adds support for the new pressure sensors BMP580 extending
> the bmp280 driver.
> 
> Patch 1 introduces a minor refactor of the driver structure to change how
> the device matching and driver initialization is performed. In place of
> the chips ids, the driver_data now contains a pointer to its chip_info.
> To perform this change, a series of declarations previously on the core
> file were migrated to the shared header file, to allow access to specific
> fields on the chip_info on the I2C and SPI drivers. This change is
> required because BMP380 and BMP580 have the same chip_id and values would
> collide using the chip_id as the driver_data value.
> Patch 2 introduces new preinit callback and unifies init logic across all
> supported variants.
> Patch 3 made calibration callback function optional.
> Patch 4 deletes misleading i2c reference on bmp280 Kconfig entry.
> Patch 5 extends the bmp280 driver with the new logic to read measurements
> and configure the operation parameters for the BMP580 sensors.
> Patch 6 updates the devicetree binding docs with the new sensor id.
> Patch 7 adds the NVMEM operations to read and program the NVM user range
> contained in the non-volatile memory of the BMP580 sensors.

Patches 1-5 are good enough for me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

If anything, we can fix in the followups.

-- 
With Best Regards,
Andy Shevchenko