From:   Tomasz Duszynski <tduszynski@marvell.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        Eric Auger <eric.auger@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        "open list:VFIO PLATFORM DRIVER" <kvm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
CC:     Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [PATCH] vfio: platform: ignore missing reset if disabled at
 module init
Thread-Topic: [PATCH] vfio: platform: ignore missing reset if disabled at
 module init
Thread-Index: AQHZMNewpePFVSldhUyVc0kESdCwdq62slYAgAA5LyA=
Date:   Mon, 30 Jan 2023 12:31:11 +0000
Message-ID: <DM4PR18MB43687D458F4EE8EEABBB3A24D2D39@DM4PR18MB4368.namprd18.prod.outlook.com>
References: <20230125161115.1356233-1-tduszynski@marvell.com>
 <BN9PR11MB527630B903EC14BC61351C668CD39@BN9PR11MB5276.namprd11.prod.outlook.com>
In-Reply-To: <BN9PR11MB527630B903EC14BC61351C668CD39@BN9PR11MB5276.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GuLdr7/o3j8QNlrWLaJUq36ByR7JAgh+0iWYwq/yaRPMJGr17OIIyfdlnwN7?=
 =?us-ascii?Q?pBO6gNm1rEZw1Y1qKacQ+Xplz4E0hV7S5MGN7N1w14JeQ3XeRiUKochhVxre?=
 =?us-ascii?Q?A+RodJAeuz3tcZJkTYRli7fJGefYLd8+G0SvxsN6tZYGuvMlqND1MZj6A5E0?=
 =?us-ascii?Q?Zifr6B4GCCnFe85C8xCFBWU6wGeBJZND77mDHho0C0EZMfrdduTF6U+mJPRP?=
 =?us-ascii?Q?Q2A1ic6Z4/QftnUb2ZqbXI79MmoiHN+WLf0Mu0BtwYvSEdDDR1E4N3hQpUeT?=
 =?us-ascii?Q?OXTABGlaQcs/S4LK5CGoUk0hjtX7e4f7t4i5lyd9vANEaHmVqWt9AFkDKYKR?=
 =?us-ascii?Q?eUHnTVgS+EAqOhozQkrJPB4c6naygAywdKgGbpONUnyPDuuD5I4p55JARU+n?=
 =?us-ascii?Q?+q2uvnmPMnLBT6mRmxah6zQiAMy58/rLTqSBflUMPchnOkm28DjVGYUyr0Gu?=
 =?us-ascii?Q?qPT0SCoSmg8OVfUV9XXNwsodtLqwzn7mcnjhCApGlK4l4KaWCf9ZDX4vaqSi?=
 =?us-ascii?Q?XmLZimA/+lobeEvKdPkyAzO+Mc2xbXCUaEIhIbGMZQp5xi7bhAXSr5itNpY+?=
 =?us-ascii?Q?NdrotZsVe543UtZeIOuc6Pgixx0M87wfIibnRtfMpbBe5h6X6vZuX3d577fV?=
 =?us-ascii?Q?J/sW74KmXw3f8qAz0OHwMTc13dUE/o3dX+sNotl6j/AQDlTeXsXBViZhkMuH?=
 =?us-ascii?Q?Tbo6WnYyyGoqksPj6YYou0YYnLwNWPQ71Ch3AHCe1Ue7vNnOnz2d6dbt15bm?=
 =?us-ascii?Q?b1D7vhEKhvAULDlcKQhGhZE4dLsiuByMdLMXR3J3wIiRYYFlN0DuRifgdFny?=
 =?us-ascii?Q?46g5g+/Xgq2FnhxWICURY3h75sbwMwd1IDZiJKpBFAbyOkZEHxVtEzZjL+/1?=
 =?us-ascii?Q?b+C1U1DlZyUfCpbOsZnzPF8LNKe6lQuXCFarxYQxU4AamOsYSCBfNKyp42Hp?=
 =?us-ascii?Q?PuT208ZKpN+X5O+lXgkpmv3vEWVcsPbiSmBgbYjWIjydtT3JfOcSVxMYfaqo?=
 =?us-ascii?Q?OcqF+KqznptrNO7xcCkgBvmQ1F1mQEUvhrgtTfElEpukQbakLhnXortVyDRf?=
 =?us-ascii?Q?oVoiyaBCTfCiVsIBgGeS9AfCGR2sscGRMzpdJv6zvku62wT83RD92iVWOAfs?=
 =?us-ascii?Q?ldUXSx61BwkSncfmIGsU0AOOkqxSLUSVoxKrMuJxqNQg0i+hs/N86UUJFhGC?=
 =?us-ascii?Q?ZSZ53hjzNkKIt4Is7KKrxJKd1y1NzJixIr3DyA3jBcv8rxbOJgj5h8X2QQyZ?=
 =?us-ascii?Q?p8UMdukM+fzYMBTmK1AGX6lfTA2oY9dqrcYa54sKFmwy5mTychRZdEGFmX4j?=
 =?us-ascii?Q?2jWZH/ml27NnZe5AdQr/7m5Jis7w8/Ka08l6UUQpHoV2LLJm0QzUxGMXSOQ4?=
 =?us-ascii?Q?C9e16jURVG7umvTqzDDe68Jlq1ib97Api8YsVuYOEW8UfxOER1m6LluoRjmd?=
 =?us-ascii?Q?F+7G8cDAvWrUxBNkcX2xb518pLyB8CfoPN/vMMVRAYwP9+Uj0LaNw+Md/fcO?=
 =?us-ascii?Q?DVxm5L7H9Fz68y1QIx1cW6iuE2eqR04ayp17xIVnCG35rwDe8H0NZAdRit4O?=
 =?us-ascii?Q?6v1BdPJ0ajupYqT60alsTqGvE2Jtr1VGUObq+iE0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4368.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e41dde4e-588a-4563-7275-08db02bddf08
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 12:31:11.6379
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4xh/l91C/IiGGuZbgYBfPAfhCX4ipkxy/KMGGhyM8QxJAq81oGk408v/lttwCbVeui6RKbYj0D1dXxqx/pek8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4493
X-Proofpoint-GUID: wpcsnUgce4nEsHELBuiLqNvI8SctJ87e
X-Proofpoint-ORIG-GUID: wpcsnUgce4nEsHELBuiLqNvI8SctJ87e
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-30_10,2023-01-30_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Tian, Kevin <kevin.tian@intel.com>
>Sent: Monday, January 30, 2023 10:06 AM
>To: Tomasz Duszynski <tduszynski@marvell.com>; Eric Auger <eric.auger@redh=
at.com>; Alex Williamson
><alex.williamson@redhat.com>; Cornelia Huck <cohuck@redhat.com>; Jason Gun=
thorpe <jgg@ziepe.ca>;
>open list:VFIO PLATFORM DRIVER <kvm@vger.kernel.org>; open list <linux-ker=
nel@vger.kernel.org>
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>Subject: [EXT] RE: [PATCH] vfio: platform: ignore missing reset if disable=
d at module init
>
>External Email
>
>----------------------------------------------------------------------
>> From: Tomasz Duszynski <tduszynski@marvell.com>
>> Sent: Thursday, January 26, 2023 12:11 AM @@ -653,7 +653,8 @@ int
>> vfio_platform_init_common(struct vfio_platform_device *vdev)
>>  	if (ret && vdev->reset_required)
>>  		dev_err(dev, "No reset function found for device %s\n",
>>  			vdev->name);
>> -	return ret;
>> +
>> +	return vdev->reset_required ? ret : 0;
>>  }
>>  EXPORT_SYMBOL_GPL(vfio_platform_init_common);
>
>It reads slightly better to me as below:
>
>	if (ret & vdev->reset_required) {
>		dev_err(...);
>		return ret;
>	}
>
>	return 0;

Sure no problem.=20