Message-ID: <4c1173f3-18e9-e46d-c50e-1febb90b426c@gmail.com>
Date:   Mon, 30 Jan 2023 13:34:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101
 Thunderbird/96.0
Subject: Re: [PATCH V3 1/6] nvmem: core: add nvmem_dev_size() helper
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Michael Walle <michael@walle.cc>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        u-boot@lists.denx.de,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20230127125709.32191-1-zajec5@gmail.com>
 <20230130115654.0041716d@xps-13>
From:   =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
In-Reply-To: <20230130115654.0041716d@xps-13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 30.01.2023 11:56, Miquel Raynal wrote:
> Hi Rafał,
> 
> zajec5@gmail.com wrote on Fri, 27 Jan 2023 13:57:04 +0100:
> 
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This is required by layouts that need to read whole NVMEM space. It
>> applies to NVMEM devices without hardcoded layout (like U-Boot
>> environment data block).
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> V2: Drop "const" from "const size_t"
> 
> It would be good if you could always add a cover-letter, just so that
> we can reply to the whole series. In my case I wanted to add a global
> 
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> Because I gave this series a quick review and it looks good to me.

Good point, I'll keep that in mind and do that in future for all bigger
series.
Thank you.