Message-ID: <81c25623-8689-759a-026e-b49190bc19cf@linux.intel.com>
Date:   Mon, 30 Jan 2023 15:28:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH] ASoC: amd: acp: Refactor bit width calculation
To:     Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
        Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jia-Ju Bai <baijiaju1990@gmail.com>,
        Akihiko Odaki <akihiko.odaki@gmail.com>,
        Vijendar.Mukunda@amd.com,
        V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230130100104.4076640-1-venkataprasad.potturu@amd.com>
Content-Language: en-US
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
In-Reply-To: <20230130100104.4076640-1-venkataprasad.potturu@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 30/01/2023 12:01, Venkata Prasad Potturu wrote:
> Refactor bit width calculation using params_physical_width()
> instead hard-code values.

I would have added a Reported-by tag for Pierre...
A Fixes tag might also help this patch to follow
ca9d237994db ("ASoC: amd: acp: Refactor i2s clocks programming sequence")

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
> ---
>  sound/soc/amd/acp/acp-mach-common.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
> index b83ae946b3e4..b4dcce4fbae9 100644
> --- a/sound/soc/amd/acp/acp-mach-common.c
> +++ b/sound/soc/amd/acp/acp-mach-common.c
> @@ -186,7 +186,7 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream,
>  
>  	srate = params_rate(params);
>  	ch = params_channels(params);
> -	format = 8 * params_format(params);
> +	format = params_physical_width(params);
>  
>  	if (drvdata->tdm_mode)
>  		fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -330,7 +330,7 @@ static int acp_card_rt5682s_hw_params(struct snd_pcm_substream *substream,
>  
>  	srate = params_rate(params);
>  	ch = params_channels(params);
> -	format = 8 * params_format(params);
> +	format = params_physical_width(params);
>  
>  	if (drvdata->tdm_mode)
>  		fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -475,7 +475,7 @@ static int acp_card_rt1019_hw_params(struct snd_pcm_substream *substream,
>  
>  	srate = params_rate(params);
>  	ch = params_channels(params);
> -	format = 8 * params_format(params);
> +	format = params_physical_width(params);
>  
>  	if (drvdata->amp_codec_id != RT1019)
>  		return -EINVAL;
> @@ -616,7 +616,7 @@ static int acp_card_maxim_hw_params(struct snd_pcm_substream *substream,
>  
>  	srate = params_rate(params);
>  	ch = params_channels(params);
> -	format = 8 * params_format(params);
> +	format = params_physical_width(params);
>  
>  	if (drvdata->tdm_mode)
>  		fmt = SND_SOC_DAIFMT_DSP_A;

-- 
Péter