Message-ID: <e8c35d5d-d855-a38c-2f3b-6887df208360@nvidia.com>
Date:   Mon, 30 Jan 2023 16:33:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH rdma-next 00/13] Add RDMA inline crypto support
To:     Christoph Hellwig <hch@lst.de>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Bryan Tan <bryantan@vmware.com>,
        Eric Dumazet <edumazet@google.com>,
        Israel Rukshin <israelr@nvidia.com>,
        Jakub Kicinski <kuba@kernel.org>, Jens Axboe <axboe@fb.com>,
        Keith Busch <kbusch@kernel.org>, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org,
        Masami Hiramatsu <mhiramat@kernel.org>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Vishnu Dasa <vdasa@vmware.com>,
        Yishai Hadas <yishaih@nvidia.com>
References: <cover.1673873422.git.leon@kernel.org>
 <20230118073654.GC27048@lst.de>
 <ac48766a-b861-4fc0-3171-7b23f175c672@nvidia.com>
 <20230130123505.GA19948@lst.de>
Content-Language: en-US
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <20230130123505.GA19948@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHgxZDR4ZTJmamFQcENpM1NwUjlSeU1rNDJjVVppc2FLSzdGUHRnb2wrUlV6?=
 =?utf-8?B?TjVncEtBVUh3VVhQMFZ5Qm0xTlBrbVNCVnJPTmM3dm9vNVlKQ016NHlydGx3?=
 =?utf-8?B?N3ZCVTB5ZzFGRWFCakdsdUd6dGdSQ1MwYnExdE1NR0JRcklhMG5VWGlTVnNC?=
 =?utf-8?B?RDRodmRGRHZnL0pPUk5BSUdLRFY4aW5ZQm4vNjJlM1dGV0ZmQzRYVnZXVEVa?=
 =?utf-8?B?eWQyYm5YZ2pMc21ESnlBcG42R0hYc2tvbjFocWtiZkdaVmhNNUt0amNxSjBC?=
 =?utf-8?B?L3JleU1wc2FHYkdpa0k5ZlJOZlRjTFpvR05jZ2xXYW5DVkZZTVZUTTRDSHNM?=
 =?utf-8?B?OW5ISHpUVXRXOVY1Smx0WlFzSjlTV1Vxbk5CeEZoYUdYdWIrc1ZyYy9aaTBX?=
 =?utf-8?B?di9yVnArOEN5QnpRZ2dPdmZPTW9qRSszc0Q2eXYzd0MvNlIxUUhET0hOZjZZ?=
 =?utf-8?B?UE1mMWdMNkJnY3dlbXI1WFpOVXdRUzA4aHFaVUJyYlB2bnRpNTFJRkZaOGg5?=
 =?utf-8?B?Z280NkpNWXpka0FvSW94UFF5T0RXWTQwSWNXZTY1RnUyQVcyM0I1QlRXcXlk?=
 =?utf-8?B?czdvcVFYM0ErMmo2OGZtVXpOUDhNUlFUOHZENUVxem9NczBLb0hVVTNpZHFF?=
 =?utf-8?B?cWVMSmE2ZU9wT2M0YWhiOHZMcnZ1dHlPVDlhNkVYYmxLT1lPRmZiU1RNNVBP?=
 =?utf-8?B?TFE1Y3ZIMG0yTkdzanR1c282eFdTL3BmcGdwdzI1TFNWeWloM0FTNThvZnNH?=
 =?utf-8?B?aFJ2M1Z5bDZURUNNa2VVNGlhU3c2OUtJdHFMMWFnL0ZVT1pZWjJDNjJzc0lk?=
 =?utf-8?B?NjY1cS9NR1B1ejlnUTRjYUJyVXRLMDBHU1JWczFCU25LS2k3bVNEOEhsQzVG?=
 =?utf-8?B?d0gxamY2akFISms1OXNjWDJlOXNveGZIeUxkTTlyWmtVVlhMQlozaVc3RGhH?=
 =?utf-8?B?RDlTZmQzbEtQQW01QUkvZ01NS0lNWjlwRXJIUmt1aENtY1NENDQ1MkFzOFMv?=
 =?utf-8?B?MjlTSkx0c2c2bVQreVlrSlRHV29sbkpweXFQMVJkbnd4MjFsRDRLbm1aYVZQ?=
 =?utf-8?B?Q2t1U2VPbFVCcjhPZmQxZlR4czhsaUtTQ1hVSUdPclI3UUpYWThrVkpxNFJr?=
 =?utf-8?B?ajMvRFdRNlBpblRPSUFoWkpBYXZQTkdqQkZJS0k0Rk1keSt0dkFCQ1BaYWxq?=
 =?utf-8?B?WWJPemJmRHJHdmlVd0syQ1QzUXgvNlUvZVJoQ01DK29sK0wzMU9YOSt1ZzND?=
 =?utf-8?B?S2tHbzhJUStqTWFWdExMZG5DeEQ5UjVBNmUzQWZ0YzlMNzFOeGpxeEpnZy9L?=
 =?utf-8?B?WFVSTnRuQ1V5WDZ6bVhyakJEMko2VXRIMWlsRDhIL2hMeC8vVTNKODkwZHF4?=
 =?utf-8?B?Rjc2Rk1pRFJGZ0J2RHhTdVdINi9XZkxsWW9zSElFK1BweTgzNzRlWUFBanM4?=
 =?utf-8?B?ZXZ5MEo3Nk02eUYzVk04QWE4ZmdyZDZPN2lTOHlkRW1iQjdHazJvdXZ5TFJx?=
 =?utf-8?B?TmNWRmlMaUxrU0I0ZU1sVlJ1U1lBb3U4cGlPUTVWZnpCRWd5SkpOY1ovWjRO?=
 =?utf-8?B?ZkU2aHpYNGQxVytHTzcrLzZ5K3phM3FadzlyS3hBdWNBN0xyNUgrSXhERXl4?=
 =?utf-8?B?RkhHNmptbGZYdUJHdlVMZHN0ZnZhdlE2a1dleDZicVFqRGRtdjlIa3phdG54?=
 =?utf-8?B?UFdmUmVYWnpwb2pFeEtWVnJselozR3NQdmNFS1czWWJYaWJSVjhreWxEa2RK?=
 =?utf-8?B?OXpJWGViQ3NmWmdpV3FLZFViMVFRUHNKRzJxTVFTdHN6U1BZanRkYzdGSCtu?=
 =?utf-8?B?aW1HL1FtMXFDQjhobnA3ZmdkOXdwSkFGanBSeHl5WEQ0cGlhQ3UwNG5naU1m?=
 =?utf-8?B?WGZLTFNHUm90QndVUnVTclhTTGY4RWM4TmVRczllOHJtK2EzSWFMa09OZitV?=
 =?utf-8?B?c3ArWUdCSmIyaFNPOG8veUt6WlhLT2RNYVJFN1gwdmZJU1FrZzNSRVgrRHhN?=
 =?utf-8?B?SjVLYWEyakFxc1l0MndncHJVbk9ra2V2UHEvRjRRL2ZPUjlpWGpaaS9IZzBx?=
 =?utf-8?B?NHlDb3kxUkFOY1BmQUwyTzN2SmhUSG9GTzFuY3Jxa0ptR2cvK2VsOW9CR0J2?=
 =?utf-8?B?V1Y0L3NQT0Z1ckl4eWY0WDlYZGF0b3JhUGNmNEhuZitkQmJtTmZER0RhU0kv?=
 =?utf-8?Q?PrvbeuqlS5LIo9t/ytOPfHuh5yhhf32YyoZC7xa7DuJ7?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 382e6da5-a3ce-4b44-b22f-08db02cf0bd3
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 14:34:08.7965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gSt9M8ut6pBntc1TPioguN1P8B5qI/AN9zhdNukOk3bvfj4DF6/EDc1/HWN0UrVCp7iLAYv95J3iN0zLMFfr6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4101
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30/01/2023 14:35, Christoph Hellwig wrote:
> On Wed, Jan 18, 2023 at 04:20:27PM +0200, Max Gurtovoy wrote:
>> Today, if one would like to run both features using a capable device then
>> the PI will be offloaded (no SW fallback) and the Encryption will be using
>> SW fallback.
> It's not just running both - it's offering both as currently registering
> these fatures is mutally incompatible.

For sure we would like to offer both, but as mentioned before, this will 
require blk layer instrumentation and ib_core instrumentation to some 
pipeline_mr or something like that.
We are interested in doing this IO path but doing all in 1 series 
doesn't sounds possible.

First we would like to have at least the mutual exclusive solution since 
there are users that may want only one type of acceleration.

re-designing, both blk layer and ib_core for the PI + CRYPTO case in 
this series is not feasible IMO.