Date:   Mon, 30 Jan 2023 22:39:03 +0800
From:   Dawei Li <set_pte_at@outlook.com>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     npiggin@gmail.com, christophe.leroy@csgroup.eu,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc: macio: Make remove callback of macio driver
 void returned
Message-ID: <TYCP286MB2323A8880DE1D1EDFCF58F05CAD39@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
References: <TYCP286MB2323FA245F0C35C5D7486CC9CAC09@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
 <87sffssk5g.fsf@mpe.ellerman.id.au>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87sffssk5g.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYCP286MB2323:EE_|TY3P286MB3513:EE_
X-MS-Office365-Filtering-Correlation-Id: 265e8c20-47a7-44c4-d0ab-08db02cfbd1d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +1z1Tt2Vaku7XAL6cTxptickbYZ5pcc+3VYnxEkRasqNWQBIIUiUijsaCsm5bposohywsp+Kvfr/24fa7Q7XEiaE2nFZ9hRd5iYQhpAYhf1CMTsOACiKRnBr7H2YL+8ig1Az4ejl96aUeGHEZy6krKzbWKd+MKRI94pMmilRfjR9eyI8WJoZnc+/1pEos8wu7Nwtj17G8JNI+3COSEDr8tEB89FgwguAJxUg+t5+RmVcflSsdBdNj/jZFrWGiYLvlPurcwP/bOnFQcmYDfh528Y5BZ/ykyM9VYWIfjoRTyffsV/ywd8L1PTwFAy2cRN7NOz3X1wMslT3CG3TDp08+jNx0Ne5kV8i9rDvw34jYmv4D/4ekyoaDD46KEoRDf/HnZa1nN4Z5cxdU/3yrtl7crQ0BoXTVc8JSnETaCrvPMUF9dYJS7YOuisYVzUfPQpmExWEQablS2NAwQKMvSFuEVlyFmNBIgxw+u4BYTNJWjU8Md278amz+jHmWESTquxkFtHZ4IvSLaKDuByWuP6dItiaWuGVNnZVnq8ijd4LyXu5Pw/9Gmq0TBXpkEfT+9rJB/CkZzOQFoJ1V5SoGFOojDwkGXe90vvqDr1PVfF6DWn3Hdb53GsCRVSDj4gc905bmhj49xVJTOwCa6Cg6jE3Cw==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZLXEzZ1ufmT80KiR8PMjrnJccn5gsphaH1p5Ug2mflJ24oCt0tmlFtsjXRQo?=
 =?us-ascii?Q?+ZQ7zz4zx+S82QlazAojaZxu3Q6scHARnTiYEjtINBX/pwvVZ3J7AYAEUiDL?=
 =?us-ascii?Q?uiC3uthSx0tFSMGt0PqVESKWGaTV5v1JR1vDa88GORBRpYvrmCZ4QO8G73QV?=
 =?us-ascii?Q?srmqF8E9SUGjUiBzG8MkAGW+iib4XgbIsTalktPXf2XIAdxHWonNMX2OW/Hf?=
 =?us-ascii?Q?ncRsvKJ58Bc3iEJtql4svwpkDgFyxWsxqx/j0sQ5g1bdvHAyKQGHw8beOoK7?=
 =?us-ascii?Q?VUKeULqLSmH8fKang5vrpzmWfWv1/Xtyjsph9tlVGonDmM3aIicSzJtc4Env?=
 =?us-ascii?Q?kHaHc+lvILlNoUvKIlXAIn/2wdVwKU99THLJ04yHbDohw7wC4nb3SwT8kDMB?=
 =?us-ascii?Q?v2XiqFsdAVetzPgc94hu2IYwnId+ZhSCJ8/XqZ38xPD7mZ7yZVT5hA9gcLvW?=
 =?us-ascii?Q?DIRlojMVIIwAgerJuBPl2pidC30fPi7WmfKg60pDW+hpQ2s5mcfjeDwelsBp?=
 =?us-ascii?Q?7lA8w+UZ7XPHOECYYyQSoTj22UJ0ZD5KdVvCx08BvIuguMgql75IuGNxOrWN?=
 =?us-ascii?Q?AFUR00VbqGUOCSFgi58TM4/6KRIBv307THz7wjlTxhG5QdYIcMhV46zyFhIz?=
 =?us-ascii?Q?JNJtLguEDXQKPcQp8ECGsiSbRTQFo5pQLmUN2MYpC2F/1TPRJUtwF+ae2rrm?=
 =?us-ascii?Q?i3+F4JcNt8S0d/xjgUKGnE8LOHMA2191OifeGw0Ivp5qTGX0LADQseZuEE8/?=
 =?us-ascii?Q?0X2IHCeuM7OEOeW7OAIuI9sexitDkxlTn1KwVk10w3gp1iO4PX6PfDwm6mnX?=
 =?us-ascii?Q?fvwXjpG93vKrwF+lwBAuEjpggChyv7Tci5LicspxlkGXQb5flqG4N6xJqqEK?=
 =?us-ascii?Q?761OHL0yv0SI6tq4buHp2OQp2Q6eGst9nVg3hZlIda8YG2cyZ7QENYpWSurr?=
 =?us-ascii?Q?9P0xYrkA9oEgO2g2K5wnoui/uXkZJIHjpsJoRA8Nwow/CeXLJZxVtXgVpYKd?=
 =?us-ascii?Q?Qo031GD1PIGNZ8hafOKURlUZYgm03SKslQ6DQww7ezI7M20LRy8qs21IGfDA?=
 =?us-ascii?Q?VerkA5Gcw1hWDCif3nwQrJRO6GrZfo2Y9nOGA2YKeYbIAs6smkvxO6+qqXiQ?=
 =?us-ascii?Q?nWDTYrVpWJhJ+yQY27vbvACLHHaBGeFHAUY0/iQkzKN+4FzAzB6CwPCAgTbo?=
 =?us-ascii?Q?MBlaJE+zbqMODqNZgmezpkIMnlRz9UzH524iTVWLVa8yqop0G0nPZTh/fbSI?=
 =?us-ascii?Q?cTbwAx2gyeusS0ibQ+rURhdmmcZCgkFAFuTp5DEmsg=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 265e8c20-47a7-44c4-d0ab-08db02cfbd1d
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 14:39:05.9890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB3513
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

Thanks for reviewing,

On Mon, Jan 30, 2023 at 03:47:55PM +1100, Michael Ellerman wrote:
> Dawei Li <set_pte_at@outlook.com> writes:
> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> > bus_type::remove be void-returned, it doesn't make much sense for any
> > bus based driver implementing remove callbalk to return non-void to
> > its caller.
> >
> > This change is for macio bus based drivers.
> >
> > Signed-off-by: Dawei Li <set_pte_at@outlook.com>
> > ---
> > v1 -> v2
> > - Revert unneeded changes.
> > - Rebased on latest powerpc/next.
> >
> > v1
> > - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/
> > ---
> >  arch/powerpc/include/asm/macio.h                | 2 +-
> >  drivers/ata/pata_macio.c                        | 4 +---
> >  drivers/macintosh/rack-meter.c                  | 4 +---
> >  drivers/net/ethernet/apple/bmac.c               | 4 +---
> >  drivers/net/ethernet/apple/mace.c               | 4 +---
> >  drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
> >  drivers/scsi/mac53c94.c                         | 5 +----
> >  drivers/scsi/mesh.c                             | 5 +----
> >  drivers/tty/serial/pmac_zilog.c                 | 7 ++-----
> >  sound/aoa/soundbus/i2sbus/core.c                | 4 +---
> >  10 files changed, 11 insertions(+), 32 deletions(-)
> 
> I realise the patch has to be merged via a single subsystem, and powerpc
> is probably the most appropriate, but please Cc the relevant lists for
> the drivers touched.

Copy that. Relevant lists will be cc'ed in v3.

Thanks,
        Dawei 
> 
> AFAICS neither this version or v1 was Cc'ed to relevant lists, eg.
> netdev, linux-wireless, linux-scsi, alsa-devel etc.
> 
> cheers