Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40425C54EAA for ; Mon, 30 Jan 2023 14:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237897AbjA3OzM (ORCPT ); Mon, 30 Jan 2023 09:55:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235737AbjA3OzJ (ORCPT ); Mon, 30 Jan 2023 09:55:09 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E69129435 for ; Mon, 30 Jan 2023 06:55:07 -0800 (PST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30UDhMNo019849; Mon, 30 Jan 2023 14:54:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : reply-to : references : content-type : in-reply-to : mime-version; s=pp1; bh=Qd783FI+66KLV4KUVTHdqFl4rRs0Bb+0OylJCdv6snE=; b=dZg3lTDrpt3DqoMor/SdVaTsMOYva8EdKEPSTLWBhSWWyCTzZhfTFDULBaAxLzZJhKSG gCQe4iodbKS446jOJHJi76tpuOxezzknr6j3yTokpW9HTcbZm3XMPlqqmsDGILFRuRwG HA+JHI3BxakK2E8TdN4YPzmWmyYVyXuxtGbOVmpLgRe4viETycmbBWjx1LBjisEbwsns KPDNvyWfYzvHQs85tZRYdF+8tBwBkmfBTXk5fTCDpaQ9IaH7YTnJ9Ym9Xyd2lrvGR+MP OGzUjYVJR7E3DuM4WrgZS4eYZRanFVgzDFlRxGJQaYlLIukBJXgfrKgpSKk2aPnhWTVR NA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nef1a1xen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 14:54:58 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30UDiIf7022127; Mon, 30 Jan 2023 14:54:58 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nef1a1xdv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 14:54:58 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30TKQZHp009758; Mon, 30 Jan 2023 14:54:56 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3ncvt7hps1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Jan 2023 14:54:56 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30UEsrbi47645076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Jan 2023 14:54:53 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C95A12004B; Mon, 30 Jan 2023 14:54:53 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD73620043; Mon, 30 Jan 2023 14:54:51 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.126.150.29]) by smtpav02.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 30 Jan 2023 14:54:51 +0000 (GMT) Date: Mon, 30 Jan 2023 20:24:51 +0530 From: Srikar Dronamraju To: Phil Auld Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, mingo@redhat.com, peterz@infradead.org, ritesh.list@gmail.com, sshegde@linux.ibm.com, vincent.guittot@linaro.org, vishalc@linux.vnet.ibm.com, vschneid@redhat.com Subject: Re: [PATCH v2] sched/debug: Put sched/domains files under the verbose flag Message-ID: <20230130145451.GB159593@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20230119150758.880189-1-pauld@redhat.com> <20230120163330.1334128-1-pauld@redhat.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20230120163330.1334128-1-pauld@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5F67FU_FCzxA-D37xGwKQXxAQXZ1feEr X-Proofpoint-GUID: 8P6H9sz_QwJrbjcQGrqPnbKssUOLi3NK X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-30_13,2023-01-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxscore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301300141 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Phil Auld [2023-01-20 11:33:30]: > The debug files under sched/domains can take a long time to regenerate, > especially when updates are done one at a time. Move these files under > the sched verbose debug flag. Allow changes to verbose to trigger > generation of the files. This lets a user batch the updates but still > have the information available. The detailed topology printk messages > are also under verbose. > > Discussion that lead to this approach can be found in the link below. > > Simplified code to maintain use of debugfs bool routines suggested by > Michael Ellerman . > > Signed-off-by: Phil Auld > Cc: Michael Ellerman > Cc: Greg Kroah-Hartman > Cc: Ingo Molnar > Cc: Peter Zijlstra (Intel) > Cc: Srikar Dronamraju > Cc: Valentin Schneider > Cc: Vishal Chourasia > Cc: Vincent Guittot > Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@li-05afa54c-330e-11b2-a85c-e3f3aa0db1e9.ibm.com/ > --- > Looks good to me. Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju