MIME-Version: 1.0
References: <20230128055214.33648-1-jamiemdouglass@gmail.com>
 <CAB1t1CwzUCEL1josABxfyqX91Z6DsrbEuopsDYsgq-eNxh6Btw@mail.gmail.com> <fd879d4e-13d7-bb82-8668-a1423fc7e428@linaro.org>
In-Reply-To: <fd879d4e-13d7-bb82-8668-a1423fc7e428@linaro.org>
From:   Petr Vorel <petr.vorel@gmail.com>
Date:   Mon, 30 Jan 2023 16:03:27 +0100
Message-ID: <CAB1t1CyGeXev-nfvgAfK+Wpny0EfyAiovNc6rH0miHzAWEoM=g@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory
 overlap with SMEM region
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Jamie Douglass <jamiemdouglass@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Dominik Kobinski <dominikkobinski314@gmail.com>,
        Konrad Dybico <konrad.dybico@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 30 Jan 2023 at 15:21, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 30.01.2023 15:19, Petr Vorel wrote:
> > Hi Jamie,
> >
> > On Sat, 28 Jan 2023 at 06:53, Jamie Douglass <jamiemdouglass@gmail.com> wrote:
> >>
> >> A previously committed reserved memory region was overlapping with the
> >
> > IMHO there should be marked commit which you're fixing:
> > Fixes: 22c7e1a0fa45 ("arm64: dts: msm8992-bullhead: add memory hole region")
> Yes
>
> >
> >> SMEM memory region, causing an error message in dmesg:
> >>         OF: reserved mem: OVERLAP DETECTED!
> >>         reserved@5000000 (0x0000000005000000--0x0000000007200000)
> >>         overlaps with smem_region@6a00000
> >>         (0x0000000006a00000--0x0000000006c00000)
> >> This patch splits the previous reserved memory region into two
> >> reserved sections either side of the SMEM memory region.
> >
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Tested-by: Petr Vorel <pvorel@suse.cz>
> > ...
> >> +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> >> @@ -53,8 +53,13 @@ cont_splash_mem: memory@3400000 {
> >>                         no-map;
> >>                 };
> >>
> >> -               removed_region: reserved@5000000 {
> >> -                       reg = <0 0x05000000 0 0x2200000>;
> >> +               reserved@5000000 {
> > Can we keep "removed_region:" ?
> > removed_region: reserved@5000000 {
> >
> >> +                       reg = <0x0 0x05000000 0x0 0x1a00000>;
> >> +                       no-map;
> >> +               };
> >> +
> >> +               reserved@6c00000 {
> > Not sure which label to add, maybe append 2?
> > removed_region2: reserved@6c00000 {
> > @Konrad @Krzysztof WDYT?
> Generally, if you don't expect that there'll be a need to
> amend/reference the node from somewhere else, the label is
> rather useless..

Thank you for info. To be honest I have no idea. Previously the label
was added, but that does not mean that it's used.
'git grep -l removed_region' shows only labels in few dts/dtsi, IMHO
it's not used. IMHO it looks ok to avoid it.

Kind regards,
Petr

>
> Konrad
>
> >
> > Kind regards,
> > Petr
> >
> >> +                       reg = <0x0 0x06c00000 0x0 0x400000>;
> >>                         no-map;
> >>                 };
> >>         };