Date:   Mon, 30 Jan 2023 16:07:50 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Jason Xing <kerneljasonxing@gmail.com>
CC:     <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <richardcochran@gmail.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <alexandr.lobakin@intel.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <bpf@vger.kernel.org>,
        Jason Xing <kernelxing@tencent.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 net] ixgbe: allow to increase MTU to
 some extent with XDP enabled
Message-ID: <Y9fdRqHp7sVFYbr6@boxer>
References: <20230127122018.2839-1-kerneljasonxing@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230127122018.2839-1-kerneljasonxing@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tph1CS7yuICvQ0/mpTe5+GguSyT+ofuq/g5pf7O2KxwYzTUvbRZ3XTto1hqs?=
 =?us-ascii?Q?sAuNBEF84J+Bq6aSnciITFl11s1/Tlo/c8E1hxyksGHx9AR0lSiW4JvEy02K?=
 =?us-ascii?Q?6w514wlHK9WSe3qfh+veVswRRd5SPccVd7uJlcOEbYDFmA6F/7igrNdR1l8C?=
 =?us-ascii?Q?aU0lBcSLoC23W0WBheHUmdt24qZnCJzAiHno2GrMHQhIQjjkM5r+jloPbO7I?=
 =?us-ascii?Q?0vtYRiYsaRpyBZK96GTh0Xf36bh/hQgGVx63974/thP+/cwpHl8mUrr+yUsd?=
 =?us-ascii?Q?c4XlF7eu+AX7v8NFRWl4QDWHV1NyBua75FJxUNlNdNl8HXPjxDg2DqZ84chd?=
 =?us-ascii?Q?x+YYOR5dtnT+AQMo7ea4vPbeKB2sy8pRKnzeFxGAzT962HtKflHKZV1Xn25z?=
 =?us-ascii?Q?rWS8OphYwrh5RcCHwj0hkrc4HWLx2WQJc/bunxCsjANNKRkNUnfFC8SDP0kY?=
 =?us-ascii?Q?YKDSdNTCYsEdUerJqgTbB8PbZD4qCdd4ZChefcgEY9chxd0DY4IXLY8f60Bi?=
 =?us-ascii?Q?fWlogHVY1N1ygPJzVnfejXtb/9RhYkNHw20HTVWeY+kqKJM0unofimZoFFGW?=
 =?us-ascii?Q?ndqEmDyH2Al5GfLOyq3JgoGGSriDFcMfEtDYeTHu8BLjH9yCv1DBOguo306p?=
 =?us-ascii?Q?AGepEAl8zuH1cDG4JI88N0bbZhIcpi9afkq2jC22wp5AfeIkDwnMuM0Gvsmm?=
 =?us-ascii?Q?QAR/bjYCb6dwcMFcYS+b4Pl+KSOMOQXoWUeJcSKaqk57pQFQs1vVeSDzo8h5?=
 =?us-ascii?Q?p9aDC54oYX16/wVh8ZJAWyUitPhNXder4QUMov/N3LpVONvL9/FB5nY0PzTQ?=
 =?us-ascii?Q?8hZZFzTleyUbY06i296nLGMwq1sxWq7FQy78ooYBoWmtzqVR37Fv+G3Ze4yg?=
 =?us-ascii?Q?e3yw965qQMYSAfENIAbbcOpy4Q3G03PrW7FF+kH+rsteIDNPnpKZtJobT2Nt?=
 =?us-ascii?Q?R8TeKBHIXey42iz26l5iySj7wNHEFXCYpFk72L3vkVlBctW1Jd57Isik9RB7?=
 =?us-ascii?Q?FN+SL8C6c76EsK/ixJaCD9WDB5bi7STEYCmdJF1g3wWyvz3e9rkVOA40z+1G?=
 =?us-ascii?Q?3KxQz0zH4WtYj2bUKIMISzuRVWk4144oCaNmV8ylTqHZP6Zdy7sDr41g8k4b?=
 =?us-ascii?Q?+FbnAz3IwcM8ARUcXqtHaao9h+wSsc/t+iW/qb967A8o0/oVu3nKLyYJc5hL?=
 =?us-ascii?Q?XCHFnQjQu8WtEcMVt9yXgp6c2TdrPkNF0oBxM7YOklV0zLgDFiuJ4YCHqysJ?=
 =?us-ascii?Q?wF6Qu3PNEGZJiglHaSobDRn+QRkOrp/e6slkgtg8lU6oqCqgNiB3sH6wqx5X?=
 =?us-ascii?Q?L/GCmYM9JAaPuOgIdNidoZnTuTU/CzPyQjC/QUnX0t5S6J47eXH4HKdT5nTK?=
 =?us-ascii?Q?KnKsf+orJyL+PLme5PFiZfpzSwzBMjKUtMT/iYUY8uoGfiTkPDXTqxw9W6I7?=
 =?us-ascii?Q?wMz/g6B4gNfTK0ka/y22miPrtQUWew1Y/gZfUGjVwecpWelkSgMn4KuTs8lZ?=
 =?us-ascii?Q?yuJCCIMTwd86FeleGfSaf4NcmR0lYcu/oZq2skUIGQHi3KCvfwMB67t51CWc?=
 =?us-ascii?Q?/W4XXldgyCg8CbrLMeq2XcYkQ5yBqQ6TmPnKViEXaoJEgyP76oIUjZp3DkOU?=
 =?us-ascii?Q?9+UNqo4bsyV7gYzxDuDjNEM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd75438-7f1e-429d-b606-08db02d3c5d7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 15:07:58.5535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W4lpoKg3cIq0FtpI1cIapUCevVobZvl8Px9o30QT1p6Dda64fxnANrpOeLjQ2bpAS6ut7E0UUMBNzfX7f0h3DCzFqtLnGjvOtJ+Lig9PiK8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5821
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 27, 2023 at 08:20:18PM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> I encountered one case where I cannot increase the MTU size directly
> from 1500 to 2000 with XDP enabled if the server is equipped with
> IXGBE card, which happened on thousands of servers in production
> environment.

You said in this thread that you've done several tests - what were they?
Now that you're following logic from other drivers, have you tested 3k MTU
against XDP? Because your commit msg still refer to 2k as your target. If
3k is fine then i would reflect that in the subject of the patch.

> 
> This patch follows the behavior of changing MTU as i40e/ice does.
> 
> Referrences:
> commit 23b44513c3e6f ("ice: allow 3k MTU for XDP")
> commit 0c8493d90b6bb ("i40e: add XDP support for pass and drop actions")
> 
> Link: https://lore.kernel.org/lkml/20230121085521.9566-1-kerneljasonxing@gmail.com/

Why do you share a link to v1 here?

You're also missing Fixes: tag, as you're targetting the net tree.

> Signed-off-by: Jason Xing <kernelxing@tencent.com>
> ---
> v2:
> 1) change the commit message.
> 2) modify the logic when changing MTU size suggested by Maciej and Alexander.
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 ++++++++++++-------
>  1 file changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index ab8370c413f3..2c1b6eb60436 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -6777,6 +6777,18 @@ static void ixgbe_free_all_rx_resources(struct ixgbe_adapter *adapter)
>  			ixgbe_free_rx_resources(adapter->rx_ring[i]);
>  }
>  
> +/**
> + * ixgbe_max_xdp_frame_size - returns the maximum allowed frame size for XDP
> + * @adapter - device handle, pointer to adapter
> + */
> +static int ixgbe_max_xdp_frame_size(struct ixgbe_adapter *adapter)
> +{
> +	if (PAGE_SIZE >= 8192 || adapter->flags2 & IXGBE_FLAG2_RX_LEGACY)
> +		return IXGBE_RXBUFFER_2K;
> +	else
> +		return IXGBE_RXBUFFER_3K;
> +}
> +
>  /**
>   * ixgbe_change_mtu - Change the Maximum Transfer Unit
>   * @netdev: network interface device structure
> @@ -6788,18 +6800,13 @@ static int ixgbe_change_mtu(struct net_device *netdev, int new_mtu)
>  {
>  	struct ixgbe_adapter *adapter = netdev_priv(netdev);
>  
> -	if (adapter->xdp_prog) {
> +	if (ixgbe_enabled_xdp_adapter(adapter)) {
>  		int new_frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN +
>  				     VLAN_HLEN;
> -		int i;
> -
> -		for (i = 0; i < adapter->num_rx_queues; i++) {
> -			struct ixgbe_ring *ring = adapter->rx_ring[i];
>  
> -			if (new_frame_size > ixgbe_rx_bufsz(ring)) {
> -				e_warn(probe, "Requested MTU size is not supported with XDP\n");
> -				return -EINVAL;
> -			}
> +		if (new_frame_size > ixgbe_max_xdp_frame_size(adapter)) {
> +			e_warn(probe, "Requested MTU size is not supported with XDP\n");
> +			return -EINVAL;
>  		}
>  	}
>  
> -- 
> 2.37.3
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan