Date:   Mon, 30 Jan 2023 17:31:04 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
        Richard Cochran <richardcochran@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v5 net-next 00/13] add support for the the vsc7512
 internal copper phys
Message-ID: <20230130153104.ab6u7efjg4fi4dua@skbuf>
References: <20230127193559.1001051-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230127193559.1001051-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wv7YY9IEdylfn3XSkicQ92UaJPTzWOGtaz9kqx8BgL5VqQlAjVQXQTCl6Acp?=
 =?us-ascii?Q?15yDKq706xnMOpxfDNhlz4iX0hFKhIdZneQtQDdaa+smqJqQVODDfc9kVfB9?=
 =?us-ascii?Q?r9IxC+FaIKc4G5K+PNhfaTpWjsQk80yOT7Mn5DiNWwUobFtJUAT2SX/c71XE?=
 =?us-ascii?Q?BJ4xsoV1UTNpcRLQX3sZ4ozXuiXHr+BFpKXxUz+UeWvjSSsahZNcw2CcWcNn?=
 =?us-ascii?Q?7toRFdOKjf0hFKA9MVkuugIDduu2i86dWCTUDUn2RlE5Pe1jzmFqCJm5rVmR?=
 =?us-ascii?Q?a+11dCEHzDV4OJZEH1LqI8Las5pZVUCGVcT5a/8oEm2LI2ElpdzRN3itK7x2?=
 =?us-ascii?Q?xJUAeHOmMfwdtamfB/ysCYi8JVK8oWWiDpeodAYUOm5iBjYIU+KYZW2H3GWT?=
 =?us-ascii?Q?eN1s/pc+HTqcXa6SlUb3LqTRf2+MttNxXNu6MZCsI67OkILQLA7RqG7vEWYG?=
 =?us-ascii?Q?nJH1/WIeVwrmj/9Rzeh6R1Wj06q1iAZSlCyO1PKCGFpnLKVDuh9UwIqeBrbz?=
 =?us-ascii?Q?7Idmv0/70SmrVKBo5eKzYZcjmFnP8e4/zdhKZc2q4USQc84C9NT2cY/NCk6q?=
 =?us-ascii?Q?P661Z8e0iuErbOSWBM/R031wzGYr5lr6mLlY83RqFW3+zvgaG+0OE0joefzp?=
 =?us-ascii?Q?6QaUF1qEf+wy4oD2c35yvawQ483jAXsPGFkT0eVsilvo2vRQ32uj4vgEfcAO?=
 =?us-ascii?Q?BUEs804KFbXwcj0tu2FnNaixEHDu9Gj3wrZJzEVW+b0PjhNywnXHP36qlksP?=
 =?us-ascii?Q?+itXRLVsxG4mERYDg9sKXE//4r8yFy0x2YTRKVvUbvUt37BvDXXpRo8HfagJ?=
 =?us-ascii?Q?zr75r1D5rqm5y/m1yG0wGHW6up/VyUbFgyKGCi0zhu/yoRoRdCcIS14G6Kao?=
 =?us-ascii?Q?1NmkeTPAWdpTreIen2FkIEXbnDOi+LcOGZTZK+OvanPdiQHWhOI8HMmxZjJJ?=
 =?us-ascii?Q?6G4rVAfDLyJEOANHDAFFjfxaqz+NbuvKA/Ndd1pPudzqN9kthYU+xn/hJSCo?=
 =?us-ascii?Q?bFznMvetfF55jcOnmtbhKLGf7k1zEpEsaeVK1j7HqHswyfSGULoCr+IMo///?=
 =?us-ascii?Q?C8T3ax0WQoITpBNngMcDSiWZtkWy9RCTxcwSmQc071Ow5ZwVMUeLJQVoPS/O?=
 =?us-ascii?Q?x2ud4tTxDgV+aMpOJG7JILfAnv33GkNvqqw9PXzIEpRwlLK3WOPFG++y35ZW?=
 =?us-ascii?Q?1II5nm0zrfS3S3wpLDpQoOnCmnpte8gjV1QE+N2SfT2K7qQROM65M+O3UY2A?=
 =?us-ascii?Q?8aatp+zLitcEr0dCG8/BbOC9KHmaUDMin0h52sy+dGNxWSiEjJXMcHvdLpkr?=
 =?us-ascii?Q?J+ua6bHu7P0FushrHI9SbT2fuiv/mSmE6BGyxiHS6hMMj68DfRJowRAFwZA6?=
 =?us-ascii?Q?7FjgRe4mmrhIwj21K08mkaarhz3ibnKddrEyPiUY8k9jXOGJVGYlotd4adlF?=
 =?us-ascii?Q?0ydCpVkFCPKuztDBdPVihS7+V7Q8e8OqjEVUyJJJtC8IQVO9cHXCt282zLlA?=
 =?us-ascii?Q?P5E9oTB+Snn3UkWPwBqV4OMtNu3NfJH/P6QQFYtswtL4NzkgAh1iOhiiqNf2?=
 =?us-ascii?Q?RMToBWvlaKOPKIfEuWBMhQPX5tcHJDkfLVQLHnLC8bE0u19TTGHy+JIlplqT?=
 =?us-ascii?Q?Fg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d551bd36-aae4-41a6-c75a-08db02d7039e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 15:31:10.7674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f9gC3oWqUobmbVEkNFKRH+a2oDkWOOTIh50CCs0IzC8EY5yiBHHw3n7m3UGJsS6U3hvhL13JHtATsOeIoZBb7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8091
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 27, 2023 at 11:35:46AM -0800, Colin Foster wrote:
> This patch series is a continuation to add support for the VSC7512:
> https://patchwork.kernel.org/project/netdevbpf/list/?series=674168&state=*
> 
> That series added the framework and initial functionality for the
> VSC7512 chip. Several of these patches grew during the initial
> development of the framework, which is why v1 will include changelogs.
> It was during v9 of that original MFD patch set that these were dropped.
> 
> With that out of the way, the VSC7512 is mainly a subset of the VSC7514
> chip. The 7512 lacks an internal MIPS processor, but otherwise many of
> the register definitions are identical. That is why several of these
> patches are simply to expose common resources from
> drivers/net/ethernet/mscc/*.
> 
> This patch only adds support for the first four ports (swp0-swp3). The
> remaining ports require more significant changes to the felix driver,
> and will be handled in the future.

For the whole series:

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # regression

A minor nitpick after this is merged: please clean up and unexport stuff
from include/soc/mscc/vsc7514_regs.h which was added with your previous
approaches and then we steered mid-way.

Congratulations!