Date:   Mon, 30 Jan 2023 16:54:56 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        matthias.bgg@gmail.com, john@phrozen.org, sean.wang@mediatek.com,
        linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing
 pwm-cells to pwm node
Message-ID: <Y9foUMtlMZfZ18nr@orome>
References: <20221128112028.58021-1-angelogioacchino.delregno@collabora.com>
 <20221128112028.58021-2-angelogioacchino.delregno@collabora.com>
 <20221202180932.5k3vymrwds5ssivq@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Tt+4zDA4srW5HLc6"
Content-Disposition: inline
In-Reply-To: <20221202180932.5k3vymrwds5ssivq@pengutronix.de>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--Tt+4zDA4srW5HLc6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-K=C3=B6nig wrote:
> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrot=
e:
> > Specify #pwm-cells on pwm@11006000 to make it actually usable.
> >=20
> > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral relate=
d device nodes")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@co=
llabora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot=
/dts/mediatek/mt7622.dtsi
> > index 146e18b5b1f4..f321c6d0fd7c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -435,6 +435,7 @@ uart3: serial@11005000 {
> >  	pwm: pwm@11006000 {
> >  		compatible =3D "mediatek,mt7622-pwm";
> >  		reg =3D <0 0x11006000 0 0x1000>;
> > +		#pwm-cells =3D <2>;
>=20
> 3 should be possible, too. The driver does only support one
> polarity, so it's not really needed, but would be nice for consistency?
>=20
> Thierry, what's your take here?

There's little point in setting this to 3 if the driver doesn't support
it. The core should catch misconfiguration, but that's more of a fail-
safe and if we can just avoid this from the start by not allowing anyone
to specify inversed polarity that seems like a good idea.

Thierry

--Tt+4zDA4srW5HLc6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPX6FAACgkQ3SOs138+
s6GHKg//ZEgZo9vAqHU2RnhvwzEqB5Lj0Ga0bH0vzXcHSsZDpr8YSGqWraBHHppV
UJuzylMJGnmJnNkz6YsDWLiZaUgtGcUUxSMHeDC6iYvc+HjlZfvHf4xxEA7IQauE
UwYDyXVHCKxsWtvRR4VO/l93LasCoA1Qt1CP4mfUOZ3gvbiFP6BR1iTKZ8balc6C
izOytiVpiXsIUTiJN4dJvkEcTUgysLuUIRfYtVigBckcf8nmNEvfNHzTUJ2p8QTQ
14PSEIsfJAkcOXIyl2PYajd5L6Nn72rxH8vgoF6aX4PhPSXMknjeIzNtMAebmmd4
2tLGNaB0MliHCRmjDjcd7ELY9dNuzH8drODRsMzoIPG5HLSBftUmVhVC5elZKtjb
xq069ysSwdSKEa2/emVmFWTgt+G7XQ67ZYOhUxPTJXgNq5J3HA7bKffOleXIaUvX
Dqj83mJu6mE+dHsoGYyoIuV+YO74bsaKGqP3CK8xHHZUs2n28h2OIEGxQh2vLkja
CH3d/T0Awdqr7VqUQp5rWGnwylKnx8RkjDC73tyVzTn5ld4NmJMqnfEpatuwvzjG
iSowdQrNiyZIdofe+S8qiNy1vNBPOWio5miVRRfm30678h0hVYMEe+745wSBMkp/
oidl1RGU72RmnK+ySUPPomygTW13jOimthZSfo3DIdpqRdMSJxI=
=g4sq
-----END PGP SIGNATURE-----

--Tt+4zDA4srW5HLc6--