From:   Brian Cain <bcain@quicinc.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0
Thread-Topic: [PATCH] trap: Fix warning comparing pointer to 0
Thread-Index: AQHZMvx1VNpDD0t5kkeohxxgqDFCAq63Lcrw
Date:   Mon, 30 Jan 2023 16:43:15 +0000
Message-ID: <SN6PR02MB4205F8504967B809BA7EEFBFB8D39@SN6PR02MB4205.namprd02.prod.outlook.com>
References: <20230128093920.2729-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230128093920.2729-1-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?inpk2xrAWlL+ygMg07IL3NFniMev56U7WatBH2/aotev5+1z+K0GUKo2LSFp?=
 =?us-ascii?Q?6t8MqHKaSa/JCs7nBjOYG6Sgd9cy6ZtZqP9VxsbKqorR4d4fXgUq7WBT2UCD?=
 =?us-ascii?Q?EqzQBLys/abKhcptbhCbAn4Ibs639Qyk+/7HlDpvCv/CjyZETQ2qTWKX4Tri?=
 =?us-ascii?Q?xJfR74T7TBEPPGiq7QlorqnZYPdVS6+NMUkIVfI3t93wdhJYuiFYbBXedFht?=
 =?us-ascii?Q?shMKTKA+Reg23/FLxRQRDzwza/5ELuB8Nj3TiAUXSCMI+i2S2yMtOvZUsdPd?=
 =?us-ascii?Q?0R9ap4Qqum3NsuN9/Pwc/Cm+fFqpK1ACohHyXXuWh7wvN2JZ5aWp6V1cCm53?=
 =?us-ascii?Q?n8RcgNYUiiM/sPj4a5Xpg6BUz4LrzcA6OzD9BS5LI7ZItneVbi20YVXjp2EW?=
 =?us-ascii?Q?5C33kqIAeYQTuhvs69OoWlHU7CuKn20JqrSOWQbYeLczu3x4XUD28UVOXR3v?=
 =?us-ascii?Q?gSAipUZJ0yn/Tic5ZZqAKoAm38M+RixEuNuK2NislalAOmKOBfqcOg90ADfM?=
 =?us-ascii?Q?/KpQqq1J9cJmSPNCFW3VFsoGTqFdMZeKzbLPBOmj4Qr1103M7zzIs77GRVfa?=
 =?us-ascii?Q?kh2U5x9HPVqRXIDe62QARnBza+LgL3KPAqK6lc/MO7Us+mb+4zm6AGb0MAEf?=
 =?us-ascii?Q?nz9e9iJereHs3wX3OKrj4JQX4icFoMbN95owA/1YYUAUUo03lv8r0FxsOS+K?=
 =?us-ascii?Q?ihiYUs48Tnevk6vBX/8X2QaMnVHa16MQtxFUD2gnCPDEV9EQZ1qU5ORaxi5e?=
 =?us-ascii?Q?e0RaeU7fftE/bQi2bIeDgRSzkb6XLat5bNTwYw20Rj5D2eXHxvP1oHv5/07d?=
 =?us-ascii?Q?7cwSmS1hT2UPtqI00UWOP4bKtBfJ+He+uE4FpH79lPLQPRuHnIQfW1xSbQzF?=
 =?us-ascii?Q?mXhFJ86hIa/yzNQwrtocyarNdCop1qBYKRYTeMVTdYAWAeZyqeyH6TvfhQMN?=
 =?us-ascii?Q?U/Ilmd1Xydl6nlV1bfl7YTJZU+1W/9qytK3tbP2/NhKcw55Jbi0Tyyg4/4yy?=
 =?us-ascii?Q?92m4liO+TiIF4ACRZ1vhr1WfZev1tu+BUDjaUaPP/7+RF4Ylx/SwT1dWEYMM?=
 =?us-ascii?Q?QjZz0fQ3X4tc9FGUGvZzDIJB2IEQnX7j5hFgZSYdzHtPUVyyJ8GtYDPfWKh9?=
 =?us-ascii?Q?LNmTyXuq/fJzg3TiRuXyqEiVjabyD8IrT6x69pk3IP9n6oGbxWr58WXXmHyW?=
 =?us-ascii?Q?++uqHc6FCO3uB4c37bgCShHc8YoBal+hRMLCt/mHuQdSPzuTNFG1H7L8VREL?=
 =?us-ascii?Q?awAlq7LfLXfcJgMd2PKG04YJvJo+kZE0m103QgDEuj4jkYZ+SE75QH6gRYKd?=
 =?us-ascii?Q?zi2W0LI5zzXkZ5mV0Pbgu+TrpAU2roM5rSvNHE9YEJMCH5opgGB35ge4by/8?=
 =?us-ascii?Q?Ii5dgMgD3N/7ihek6sDhLFle3Dc1k7wM5IVm20AxQGkcY94dpzhAPyGY+uXM?=
 =?us-ascii?Q?JoirVBwnc2dTwh/Q4KIYE4kqsc63U+4Oy0nMkmTedD8CZPbWmsY+YkRHYxrY?=
 =?us-ascii?Q?h402CjP7E+1P/Rj4VlmQf7r0YwNJ3P3YpWH1lxooGLet47LVpnwl+vypV0Gt?=
 =?us-ascii?Q?f5AD4PKkdYZsnkjxa5dbYIZGC0xxtphB8hvY9sdn?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6InZKcfeIDT88/7+SlPcF0DCFslvj4hiv5QDrDfjNqx222ywQMC8wGTrpePY3SacJ9qcMOfXx6OcLqApfMNDZSbXQ/vU3oeSKA6u4FNg/6oVA98aHu5635ple/81Abt1CyUyQq74b0SDoiNKtHZ+XB0RLxX8K82nzFlHxFg4MdioIpJRIyoSQ99jBI0vCUWN1NU4EGtCdxC1uKF/ToBJoIs72F3Wgv0BOoYUgo5K7nc874/iSKDq324i3FTsgXGLaZMTeztOGMpFVaP1pJKZdkHiqc9zcRmRjoaUXHsExdmKeQtuErAdNpCDX8OzYrzhVj1xQaS7oToGsqt1k8zqdAXR4Yp/iVyZZi8MDbcIBUrurA+2fGmtgtu10HAxdylAQBjIByIcudC3EQc+vGpImq3DpJAh1pEVIz+kdN4dVrfarqA+naN00AW2lUFVYNrcmv6X0KFFgJLl3AC7oI76UKZSZDRkP7p/4UdH7HLkoZGFZAd/74/uNVJt2jxDGUzPKu7q2Z6DwjvHhCTpBiIjEvdgOWiXJdZurmAxIQ9JBq8W1lfGEWDxmAn6q43hWZYIuUM9IvpDANAQ7agxjlyg1bbUbsOftFQIILEmgm0fKxpTt+3E7FavpMQxp+1k+inyyiusIdggbAsFjODq1GPquU6H0Toc23aYS2bVoc+jl6rDMNLOHRzz/oQhwweYHjPAEMDEmccQfuHuLKDB9dDrO3tDu5K2HyQ2GFaEaa+K9W5zbyAiNV8vGm4Cxu24WigPCydjriQN8qfsovD2R80Xd0cVe28WC1+Ra2lDWM6+3voP7krLYzOYmwa9P6QTb6ZEZY1EfFSEtEdZ5upioGrw1g==
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4205.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25d89554-9450-4b2c-6b9f-08db02e11584
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 16:43:15.4485
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PvwCwi/0NIFwxhO3YijRX5ktF6xyyaUJbNCtKpYhZPzcPn91TkHBHvN0ac83IFPLk0v0SBHzxLiMJbsnYz4cuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8275
X-Proofpoint-ORIG-GUID: e0GAe1C_Vzh4_eai4F1QKOkCateV5Kpq
X-Proofpoint-GUID: e0GAe1C_Vzh4_eai4F1QKOkCateV5Kpq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-30_16,2023-01-30_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 priorityscore=1501 suspectscore=0 clxscore=1011 mlxscore=0 spamscore=0
 malwarescore=0 mlxlogscore=610 phishscore=0 bulkscore=0 impostorscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301300161
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
...
>=20
> Avoid pointer type value compared with 0 to make code clear.
>=20
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D3860
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/hexagon/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index 6447763ce5a9..fdbbf78b4ce0 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
>                 }
>=20
>                 /* Attempt to continue past exception. */
> -               if (0 =3D=3D newfp) {
> +               if (!newfp) {
>                         struct pt_regs *regs =3D (struct pt_regs *) (((vo=
id *)fp)
>                                                 + 8);
>=20
> --
> 2.20.1.7.g153144c

Acked-by: Brian Cain <bcain@quicinc.com>