MIME-Version: 1.0
References: <20230130141553.3825449-1-jlu@pengutronix.de> <20230130141553.3825449-2-jlu@pengutronix.de>
 <CAK7LNAReD_97qWRT8f47VKx9cScTWUJcHNkUyhXQoMAYPwAPUQ@mail.gmail.com> <faf0b767d910f11c0e9b458614e002534880e12a.camel@pengutronix.de>
In-Reply-To: <faf0b767d910f11c0e9b458614e002534880e12a.camel@pengutronix.de>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 31 Jan 2023 02:21:37 +0900
Message-ID: <CAK7LNATa8jxRzbf7Wec3WYtBW7-DF2c+uMi+wjJddHziWquQ3g@mail.gmail.com>
Subject: Re: [PATCH 1/2] certs: Fix build error when PKCS#11 URI contains semicolon
To:     =?UTF-8?Q?Jan_L=C3=BCbbe?= <jlu@pengutronix.de>
Cc:     David Howells <dhowells@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        keyrings@vger.kernel.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jan 31, 2023 at 1:43 AM Jan L=C3=BCbbe <jlu@pengutronix.de> wrote:
>
> On Tue, 2023-01-31 at 00:18 +0900, Masahiro Yamada wrote:
> > On Mon, Jan 30, 2023 at 11:16 PM Jan Luebbe <jlu@pengutronix.de> wrote:
> > >
> > > When CONFIG_MODULE_SIG_KEY is PKCS#11 URI (pkcs11:*) and contains a
> > > semicolon, signing_key.x509 fails to build:
> > >
> > >   certs/extract-cert pkcs11:token=3Dfoo;object=3Dbar;pin-value=3D1111=
 certs/signing_key.x509
> > >   Usage: extract-cert <source> <dest>
> > >
> > > Add quotes to the PKCS11_URI variable to avoid splitting by the shell=
.
> > >
> > > Fixes: 129ab0d2d9f3 ("kbuild: do not quote string values in include/c=
onfig/auto.conf")
> > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> > > ---
> > >  certs/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/certs/Makefile b/certs/Makefile
> > > index 9486ed924731..cda21811ed88 100644
> > > --- a/certs/Makefile
> > > +++ b/certs/Makefile
> > > @@ -67,7 +67,7 @@ $(obj)/system_certificates.o: $(obj)/signing_key.x5=
09
> > >
> > >  PKCS11_URI :=3D $(filter pkcs11:%, $(CONFIG_MODULE_SIG_KEY))
> > >  ifdef PKCS11_URI
> > > -$(obj)/signing_key.x509: extract-cert-in :=3D $(PKCS11_URI)
> > > +$(obj)/signing_key.x509: extract-cert-in :=3D "$(PKCS11_URI)"
> > >  endif
> > >
> > >  $(obj)/signing_key.x509: $(filter-out $(PKCS11_URI),$(CONFIG_MODULE_=
SIG_KEY)) $(obj)/extract-cert FORCE
> > > --
> > > 2.30.2
> > >
> >
> > Instead, how about this?
> >
> >
> >
> >
> > diff --git a/certs/Makefile b/certs/Makefile
> > index 9486ed924731..799ad7b9e68a 100644
> > --- a/certs/Makefile
> > +++ b/certs/Makefile
> > @@ -23,8 +23,8 @@ $(obj)/blacklist_hash_list:
> > $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) FORCE
> >  targets +=3D blacklist_hash_list
> >
> >  quiet_cmd_extract_certs  =3D CERT    $@
> > -      cmd_extract_certs  =3D $(obj)/extract-cert $(extract-cert-in) $@
> > -extract-cert-in =3D $(or $(filter-out $(obj)/extract-cert, $(real-prer=
eqs)),"")
> > +      cmd_extract_certs  =3D $(obj)/extract-cert "$(extract-cert-in)" =
$@
> > +extract-cert-in =3D $(filter-out $(obj)/extract-cert, $(real-prereqs))
> >
> >  $(obj)/system_certificates.o: $(obj)/x509_certificate_list
>
> Thanks, this works im my tests, too.


Can you send v2, please?

I do not come up with a cleaner way for 2/2,
so I am fine with it.


>
> Regards,
> Jan
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  =
|
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|


--=20
Best Regards
Masahiro Yamada