Date:   Thu, 26 Jan 2023 17:59:03 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     <alison.schofield@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>
CC:     Alison Schofield <alison.schofield@intel.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Message-ID: <63d32fe783ee2_ea2222949f@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1674070170.git.alison.schofield@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <cover.1674070170.git.alison.schofield@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M2cwbQ37Z7CUJ3kb2feL3rDKJ6h3+ansikyF+UBtow/6VpgLy6je96gRuuRv?=
 =?us-ascii?Q?qd4LvNB0lfopfZPt1fNjIxpIoqbSLk1LuoLSI9WDoXfFpmSFMO48PxKVLArc?=
 =?us-ascii?Q?DpQ2TXJHDSx5ME0Jq2cmsFlvYW52+zq/BVOl9U5dOBghMabeVYWQ0KZwCRMl?=
 =?us-ascii?Q?Vb27s2m0/v9jfCLrcvLXDxr+fo3chWSPiMNEhoBNjAQ/4u2XDyRAMm4nKxPn?=
 =?us-ascii?Q?vHE7re7LR9CisSDhlU21KLKquciPSXdYkDMLH7NiFlsUEisGkJ9Cj67GwL9T?=
 =?us-ascii?Q?lWcbaKCN+O4+WWvRbv1VFGmT4WiJsCZT6kNOci3C9koVVUlL0bsfM/EqyBQ2?=
 =?us-ascii?Q?qzTamnsn//MABl9X0aqMoai+47WZSOkCzpsIjpWqwXKECZQ4DF8Qq7KZzhb2?=
 =?us-ascii?Q?f3HJScNdnVaCaSED7EewJc7kPbPEv3QAt6X/NGY9yR0tWlF9ZV6O783QxXeR?=
 =?us-ascii?Q?sXoCj1P8Pjn7GtAM/AQnePTAy3RaoBNZx0cfzHvn97ly/w93QoBRYQ81W5sJ?=
 =?us-ascii?Q?V+OHKWgVdxuDjLy7vkfd7BiLeJ93W7K2JlgQdAWwE+oPC/SOQf43yt7SDfCL?=
 =?us-ascii?Q?9Kp/cTsr1gUevhcA8M1gK4A3t7H7qG7ScwsE4qNkgI5ISSFKaQDlqxkQuc/p?=
 =?us-ascii?Q?2asREhuzfg0ZdT5tIYDzY3WYHBqJzuBe9uaoxiy8u2dhHfJQ9ZlmVb6Rqro3?=
 =?us-ascii?Q?g9uJR5Aa4jbAULTTpc9BOwioNrP85h06afQHiT3yCBYmdAFsCaxD21OFOa7C?=
 =?us-ascii?Q?77y18gxzuuySkdXkt7CsaCcECQVDClUUD6EU/JzzqU9KgxoYvQ1V2DJLcxHU?=
 =?us-ascii?Q?rcMf28K0UD01b07/zVt1IsfU74pGetuKqMl8cxu870KersbUUNoPgKi9pNNc?=
 =?us-ascii?Q?Njgetomu4p7dp5NZY414SdTl3YupfMwdvGqOsg8YTglgeaHxMqitYJigbPL4?=
 =?us-ascii?Q?b3gdP0Xg+7wzR1lk7EaRactrSoHchQZhJ//7r/b0Rp401eh2+kP+b7saLccw?=
 =?us-ascii?Q?pGkJhtpCFSNfq8jx7BENtrSLAZLBuvkZ3y/vSn5MMXDYw/ntnS5Onl7kyhPT?=
 =?us-ascii?Q?3zD3iJZdn8Ohyfx/Z06trz9OjdIsh+sJujCA2k8UMiPQr/+/9kwceEJjR9dN?=
 =?us-ascii?Q?WRFNOeVbTKr89ZDkB3IWgv2DyB3Tsu0VdI8anOKGtt6ubNKxRaQkiG9wEpyB?=
 =?us-ascii?Q?0P881nYJXu/h+woqaQ0Vv6GmrPsHdPQLS0Q2OEcNoiB+/WThUK2xp54bie6c?=
 =?us-ascii?Q?BjUtu6lr9p1eWk9caK7y+meSP4oFy8jlwqmN/vU3EY4y7FS0MFJ5R5z9pAra?=
 =?us-ascii?Q?Ls1PVgBZ9yaaFPBmgEH8cldM8OL5sV7W+W5SeW/USU81lWOesTTB7v/9GLAE?=
 =?us-ascii?Q?VNNbt0FoyFV/ZTwtHIE4D9muIaPpfahbQ7DyJTA4H+466HLaCWUNAyhxN/Yy?=
 =?us-ascii?Q?Dvr0pUxKHJe3Eo01P1tSwWHC2pVhI/3B3YrjhRh4Q3mg7W8s4PYjyEU96inu?=
 =?us-ascii?Q?mGbkMPqE7bOtq+CDWJj9+djFz7Kh8C9xLY7cg9yHLNFRZJM7kmWSAUZ23Pxj?=
 =?us-ascii?Q?RSy2kRVmgBF5M/GyTTzt86UlCdFNjx8aVKQU16dvIoxKRLjmCZYaziDEHH7D?=
 =?us-ascii?Q?Nw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6842b977-2767-4764-8caa-08db000a1224
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 01:59:05.9615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0AcB9tckRe5PYppX41Dy8cuw1UvsGwCUJKojzIU8OpwuPiZgVxYN6BkRZWWwQW5GOtBETgoCUfLMPYwR4uoDxUSNhRjWh0Y1SqiLZzRwiBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4962
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> Subject: [PATCH v5 0/5] CXL Poison List Retrieval & Tracing
> 
> Changes in v5:
> - Rebase on cxl/next 
> - Use struct_size() to calc mbox cmd payload .min_out
> - s/INTERNAL/INJECTED mocked poison record source
> - Added Jonathan Reviewed-by tag on Patch 3
> 
> Link to v4:
> https://lore.kernel.org/linux-cxl/cover.1671135967.git.alison.schofield@intel.com/
> 
> Add support for retrieving device poison lists and store the returned
> error records as kernel trace events.
> 
> The handling of the poison list is guided by the CXL 3.0 Specification
> Section 8.2.9.8.4.1. [1] 
> 
> Example, triggered by memdev:
> $ echo 1 > /sys/bus/cxl/devices/mem3/trigger_poison_list
> cxl_poison: memdev=mem3 pcidev=cxl_mem.3 region= region_uuid=00000000-0000-0000-0000-000000000000 dpa=0x0 length=0x40 source=Internal flags= overflow_time=0

I think the pcidev= field wants to be called something like "host" or
"parent", because there is no strict requirement that a 'struct
cxl_memdev' is related to a 'struct pci_dev'. In fact in that example
"cxl_mem.3" is a 'struct platform_device'. Now that I think about it, I
think all CXL device events should be emitting the PCIe serial number
for the memdev.

I will look in the implementation, but do region= and region_uuid= get
populated when mem3 is a member of the region?

> 
> Example, triggered by region:
> $ echo 1 > /sys/bus/cxl/devices/region5/trigger_poison_list
> cxl_poison: memdev=mem0 pcidev=cxl_mem.0 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> cxl_poison: memdev=mem1 pcidev=cxl_mem.1 region=region5 region_uuid=bfcb7a29-890e-4a41-8236-fe22221fc75c dpa=0x0 length=0x40 source=Internal flags= overflow_time=0
> 
> [1]: https://www.computeexpresslink.org/download-the-specification
> 
> Alison Schofield (5):
>   cxl/mbox: Add GET_POISON_LIST mailbox command
>   cxl/trace: Add TRACE support for CXL media-error records
>   cxl/memdev: Add trigger_poison_list sysfs attribute
>   cxl/region: Add trigger_poison_list sysfs attribute
>   tools/testing/cxl: Mock support for Get Poison List
> 
>  Documentation/ABI/testing/sysfs-bus-cxl | 28 +++++++++
>  drivers/cxl/core/mbox.c                 | 78 +++++++++++++++++++++++
>  drivers/cxl/core/memdev.c               | 45 ++++++++++++++
>  drivers/cxl/core/region.c               | 33 ++++++++++
>  drivers/cxl/core/trace.h                | 83 +++++++++++++++++++++++++
>  drivers/cxl/cxlmem.h                    | 69 +++++++++++++++++++-
>  drivers/cxl/pci.c                       |  4 ++
>  tools/testing/cxl/test/mem.c            | 42 +++++++++++++
>  8 files changed, 381 insertions(+), 1 deletion(-)
> 
> 
> base-commit: 589c3357370a596ef7c99c00baca8ac799fce531
> -- 
> 2.37.3
>