Date:   Mon, 30 Jan 2023 18:44:52 +0100
From:   Jeroen Roovers <jer@xs4all.nl>
To:     Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= <j.neuschaefer@gmx.net>
Cc:     netdev@vger.kernel.org, Simon Horman <simon.horman@corigine.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")
Message-ID: <20230130184452.396762f8@wim.fritz.box>
In-Reply-To: <20230129195309.1941497-1-j.neuschaefer@gmx.net>
References: <20230129195309.1941497-1-j.neuschaefer@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 29 Jan 2023 20:53:08 +0100
Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:

> Spell them as "default" and "heartbeat".
>=20
> Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> ---
>=20
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
>  drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h
> b/drivers/net/ethernet/dec/tulip/tulip.h index
> 0ed598dc7569c..10d7d8de93660 100644 ---
> a/drivers/net/ethernet/dec/tulip/tulip.h +++
> b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum
> t21143_csr6_bits { csr6_ttm =3D (1<<22),  /* Transmit Threshold Mode,
> set for 10baseT, 0 for 100BaseTX */ csr6_sf =3D (1<<21),   /* Store and
> forward. If set ignores TR bits */ csr6_hbd =3D (1<<19),  /* Heart beat
> disable. Disables SQE function in 10baseT */

If you are going to put "heartbeat" in the title of the patch, you may
want to fix "Heart beat" to match here as well. :-)


Kind regards,
     jer