Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-106-gfe3ab13a96-fm-20230124.001-gfe3ab13a
Mime-Version: 1.0
Message-Id: <14e7d2ba-1a24-42a1-b19e-842e0fd8286e@app.fastmail.com>
In-Reply-To: <Y9f7/q3aS5nlY7nJ@smile.fi.intel.com>
References: <20230130131003.668888-1-arnd@kernel.org>
 <Y9f7/q3aS5nlY7nJ@smile.fi.intel.com>
Date:   Mon, 30 Jan 2023 19:17:32 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Patrice Chotard" <patrice.chotard@foss.st.com>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
        "Hugues Fruchet" <hugues.fruchet@st.com>,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors
Content-Type: text/plain
Precedence: bulk

On Mon, Jan 30, 2023, at 18:18, Andy Shevchenko wrote:
> On Mon, Jan 30, 2023 at 02:09:47PM +0100, Arnd Bergmann wrote:

>> +		ret = PTR_ERR_OR_ZERO(tsin->rst_gpio);
>>  		if (ret && ret != -EBUSY) {
>> -			dev_err(dev, "Can't request tsin%d reset gpio\n"
>> -				, fei->channel_data[index]->tsin_id);
>> +			dev_err_probe(dev, ret,
>> +				      "reset gpio for tsin%d not valid\n",
>> +				      tsin->tsin_id);
>>  			goto err_node_put;
>>  		}
>>  
>>  		if (!ret) {
>
> Can be 
>
> 	if (IS_ERR() && PTR_ERR() != -EBUSY) {
> 		ret = dev_err_probe(dev, PTR_ERR(), ...);
> 		...
> 	}
>
> 	if (!IS_ERR())
>
> (Up to you)

I prefer the version that only has one PTR_ERR(), but
either way is fine with me.

> But -EBUSY check seems strange to me. What was the motivation behind?
> (As far as I can read the code the possibility to get this if and only
>  if we have requested GPIO too early at initcall level. Would it be
>  ever a possibility to get it in real life?)

I noticed this part as being odd as well, no idea why the
code is like this. I just left the logic unchanged here.

      Arnd