Date:   Mon, 30 Jan 2023 14:47:32 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Baolu Lu <baolu.lu@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Joerg Roedel <jroedel@suse.de>,
        Matt Fagnani <matt.fagnani@bell.net>,
        Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Vasant Hegde <vasant.hegde@amd.com>,
        Tony Zhu <tony.zhu@intel.com>, linux-pci@vger.kernel.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] PCI: Add translated request only flag for
 pci_enable_pasid()
Message-ID: <Y9gQxCmzqq6WXZK4@nvidia.com>
References: <647de371-fe11-15b4-5e11-8ca43a754180@linux.intel.com>
 <20230130183810.GA1692786@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230130183810.GA1692786@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QBcVX8p7qKbaqbrtNJPGBZGyMiSv5e57RVCNEHGEQ3zob0MPWfaCLNlssMTS?=
 =?us-ascii?Q?5W0v/Fao3fhUPi0jzKItjBvXqO53yol6KHLJLMpOLMiNkbeUhFO5kRjEPnyh?=
 =?us-ascii?Q?i9zy2F+5x5tLf990tU0db8z292yj/AU3EeZk3oU1TDyqOFgS6zshijQ2Ek47?=
 =?us-ascii?Q?YfLM4OhtZzTcAw1n27fG7dDdQXNUmsr0Yy/eSI1d2LQr1er5kklHGzS8YkJh?=
 =?us-ascii?Q?jz77nAW5C0uBkEdOJBMk/aN0WDl8/pCvOS8V8e+BaWV9eNpiEF/Qnx2WxezR?=
 =?us-ascii?Q?YAQzNtAE/9b9mPD0cvipG90cnxwXBbsKv8h7HpsILJ2EQAInSKnYjoRwyr3V?=
 =?us-ascii?Q?36llEZA09GXcThMdp+DfmTiJfr2MsiiaDe1RwOeJtSNrs66KnQ06LatT2gev?=
 =?us-ascii?Q?HRuskan7AJawTjOSb1k7cpJxlCs3QwCKRg+RKE544YX6QMzKQYA0WCxygsy3?=
 =?us-ascii?Q?A+SmNEhYWg+kEO0rgPAorVN8gtWeW83fo5joAy+/z3itY26HGzhIWPcbXjgT?=
 =?us-ascii?Q?Ti3eE7aKqSu+uWCWK97hvLCBtu2ZpxbAMQVq10ZBQ559242hmAngWA9hYhMf?=
 =?us-ascii?Q?lwXzcwVkJfIvNj9/EwQZcgE+9UNFEGZ+7PjoYvozOFe+jy1IPQ3F8Ogu6b/Y?=
 =?us-ascii?Q?2Pgx7+bSoaLP4FuytCuHBK9hc/Z2GXXgTZryNz6qt3nK2As7P5yz4eXbVRhC?=
 =?us-ascii?Q?HSUNMh+RilJu2AUwBxUWguHr82NrWvduscX/zchSft5jmQhGmUQL8q4Y5ZH8?=
 =?us-ascii?Q?Jc6j2ECP7blh0NhpqbK8gEafQ0fJVdHmv7kQt+q47GHLk8l5Qy34L5DKjzMM?=
 =?us-ascii?Q?zK3rMjOL51iGVB1rcp6BTWDDE+DugmNezanZ7G7TDzzeVH9olBfACdbKlPrf?=
 =?us-ascii?Q?6bxIjH+uAjt9O+DhVg4FgoZoez24R4oscJoC0H/acbyvn4F/fnITaTLlCN9q?=
 =?us-ascii?Q?EnSsnoBALwQ9Iy8XXD24qRa1fabDW2AeBuNYidtnNHcwoV+Q1EfEe3BorC62?=
 =?us-ascii?Q?l4HzaWbmKE2FcUEvDwt3FslQX5gh6asg1vPu6QwZcNk3DJ8pYqAXVwp5FFN/?=
 =?us-ascii?Q?gsy31acduBw15oZe5HTGamqmydS85vBNNglGcmQR+TDYwTZtVoN+AebmEJER?=
 =?us-ascii?Q?SHhQGWQne4QXuuBm61sZ9avuB4NnK7THMyv7iMDxxhVFlRoC0nLHTGhDYR34?=
 =?us-ascii?Q?R/xd4FH8ejFLm6xN26tgUeAXqz4mR1VFP4OkrLFPD343YhEgMjD08N/A+klG?=
 =?us-ascii?Q?/L2657zktLDka3gI4Tmt7vZjqu8N6lSVmgEkKgrDChf6TK539KF3lBr0KSK7?=
 =?us-ascii?Q?a+jlz+rtvJN4i1k0TsOG1cAPORz/R9gd80RsOQL3VvJl8UQkUYiKedSudrEk?=
 =?us-ascii?Q?6nQcLFzDrUzMge1lzvKeOPk8IapEU9rfZ3+KsmA5kwIlT3unp3BQ9mM9p9nC?=
 =?us-ascii?Q?JQMLnpR/gbTbzd67crSsicnAqi0Q2djh/1btY7T2ICCoUerJsRJWQdeQEsLN?=
 =?us-ascii?Q?WxPrMDqWkvC8YL+asUTg9hbUn0pNcz+kBtdxZ9g1Rmk8uivhYWycexppDnIt?=
 =?us-ascii?Q?a2ovciB4SodE0uLCTgPer35ugiJm7RxgnyLEXy2T?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb9956a-be43-409f-9dfa-08db02f27263
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 18:47:32.8466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xmtbSgHk7Bb8Utpq8v9b6GzgFC5V+QwmYc76uDvjA+1Lji1YxJD0YDPodMmJHhBl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5661
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2023 at 12:38:10PM -0600, Bjorn Helgaas wrote:

> Sorry, I'm still confused.  PCI_PASID_XLATED_REQ_ONLY is a
> device-specific property, and you want to opt-in AMD graphics devices.
> Where's the AMD graphics-specific change?  The current patch does
> this:
> 
>   pdev_pri_ats_enable
>     pci_enable_pasid(pdev, 0, PCI_PASID_XLATED_REQ_ONLY)
> 
> which looks like it does it for *all* devices below an AMD IOMMU,
> without any device or driver input.

AMD GPU has a private interface to AMD IOMMU to support PASID support
that only it uses.

When AMD's IOMMU driver is cleaned up to use the common PASID API this
will have to be moved into the GPU driver.

But we are not there yet..

Jason