Date:   Mon, 30 Jan 2023 12:42:15 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     esben@geanix.com
Cc:     Jonas Suhr Christensen <jsc@umbraculum.org>,
        netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, michal.simek@xilinx.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: ll_temac: improve reset of buffer on dma
 mapping
Message-ID: <20230130124215.1a06c5af@kernel.org>
In-Reply-To: <87edrc8aav.fsf@geanix.com>
References: <20230126101607.88407-1-jsc@umbraculum.org>
        <20230126101607.88407-2-jsc@umbraculum.org>
        <20230127231322.08b75b36@kernel.org>
        <87edrc8aav.fsf@geanix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 30 Jan 2023 13:40:56 +0100 esben@geanix.com wrote:
> > On Thu, 26 Jan 2023 11:16:07 +0100 Jonas Suhr Christensen wrote:  
> >> Free buffer and set pointer to null on dma mapping error.  
> >
> > Why? I don't see a leak. You should provide motivation in the commit
> > message.  
> 
> I don't think there is a leak.  But if one of the dma_map_single() calls
> in temac_dma_bd_init() fails, the error handling calls into
> temac_dma_bd_release(), which will then call dma_unmap_single() on the
> address that failed to be mapped.

I see, seems worth fixing. Please explain that in the commit message,
it's not immediately clear what the concern is, otherwise.
On top of that please add a Fixes tag here as well and repost.

> Can we be sure that doing so is always safe?  If not, this change
> ensures that we only unmap buffers that were succesfully mapped.