Date:   Mon, 30 Jan 2023 20:43:47 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: Disable kernel stack offset randomization for
 !TSC
In-Reply-To: <CAHmME9p9emE9WXBJyxCuCF64GqTPKqhMEJO9kpts-OdE8_2=pg@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2301302034340.55843@angie.orcam.me.uk>
References: <alpine.DEB.2.21.2301082113350.65308@angie.orcam.me.uk> <Y72CByxvewQv78YH@zx2c4.com> <alpine.DEB.2.21.2301120129020.65308@angie.orcam.me.uk> <CAHmME9p9emE9WXBJyxCuCF64GqTPKqhMEJO9kpts-OdE8_2=pg@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

Hi Jason,

> >  Thank you for your input.  I've had a look at the function and it seems a
> > bit heavyweight compared to a mere single CPU instruction, but I guess why
> > not.  Do you have any performance figures (in terms of CPU cycles) for the
> > usual cases?  Offhand I'm not sure how I could benchmark it myself.
> 
> Generally it's very very fast, as most cases wind up being only a
> memcpy -- in this case, a single byte copy. So by and large it should
> be suitable. It's fast enough now that most networking things are able
> to use it. And lots of other places where you'd want really high
> performance. So I'd expect it's okay to use here too. And if it is too
> slow, we should figure out how to make it faster. But I don't suspect
> it'll be too slow.

 Thank you for your explanation.  I have v3 ready for submission; would 
you mind if I added you with a Suggested-by: tag?

  Maciej