Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
Message-ID: <e68c5cab-c3a6-1872-98fa-9f909f23be79@nvidia.com>
Date:   Mon, 30 Jan 2023 14:02:52 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [GIT PULL] iov_iter: Improve page extraction (pin or just list)
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>, David Howells <dhowells@redhat.com>
CC:     Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
        "David Hildenbrand" <david@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "Logan Gunthorpe" <logang@deltatee.com>,
        Jeff Layton <jlayton@kernel.org>,
        <linux-block@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <3351099.1675077249@warthog.procyon.org.uk>
 <fd0003a0-a133-3daf-891c-ba7deafad768@kernel.dk>
 <f57ee72f-38e9-6afa-182f-2794638eadcb@kernel.dk>
 <e8480b18-08af-d101-a721-50d213893492@kernel.dk>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <e8480b18-08af-d101-a721-50d213893492@kernel.dk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2023 22:03:06.5757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f44794c7-033e-4685-b9d7-08db030dc462
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT100.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4870
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/30/23 13:57, Jens Axboe wrote:
>> This does cause about a 2.7% regression for me, using O_DIRECT on a raw
>> block device. Looking at a perf diff, here's the top:
>>
>>                 +2.71%  [kernel.vmlinux]  [k] mod_node_page_state
>>                 +2.22%  [kernel.vmlinux]  [k] iov_iter_extract_pages
>>
>> and these two are gone:
>>
>>       2.14%             [kernel.vmlinux]  [k] __iov_iter_get_pages_alloc
>>       1.53%             [kernel.vmlinux]  [k] iov_iter_get_pages
>>
>> rest is mostly in the noise, but mod_node_page_state() sticks out like
>> a sore thumb. They seem to be caused by the node stat accounting done
>> in gup.c for FOLL_PIN.
> 
> Confirmed just disabling the node_stat bits in mm/gup.c and now the
> performance is back to the same levels as before.
> 
> An almost 3% regression is a bit hard to swallow...

This is something that we say when adding pin_user_pages_fast(),
yes. I doubt that I can quickly find the email thread, but we
measured it and weren't immediately able to come up with a way
to make it faster.

At this point, it's a good time to consider if there is any
way to speed it up. But I wanted to confirm that you're absolutely
right: the measurement sounds about right, and that's also the
hotspot that we say, too.
  

thanks,
-- 
John Hubbard
NVIDIA