Message-ID: <d532dc0c-4a5d-986e-19d4-1c90071d2cdb@linuxfoundation.org>
Date:   Mon, 30 Jan 2023 16:19:48 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2] docs: add workload-tracing document to admin-guide
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>, corbet@lwn.net
Cc:     sshefali021@gmail.com, kstewart@linuxfoundation.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230127234616.55137-1-skhan@linuxfoundation.org>
 <Y9STCwt2FnYf4/X4@debian.me>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <Y9STCwt2FnYf4/X4@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/27/23 20:14, Bagas Sanjaya wrote:
> On Fri, Jan 27, 2023 at 04:46:16PM -0700, Shuah Khan wrote:
>> +strace tool can be used to trace system calls made by a process and signals
>> +it receives. a process to the perf, stress-ng, paxtest workloads. System
> 
> "... to trace system calls made by a process (which can be perf, stress-ng,
> paxtest workloads, or neither)."
> 
>> +Before we can get started we will have to get our system ready. We assume
> 
> "Before we can get started the system must be prepared first."
> 
>> +Browsing kernel sources ::
> 
> "To browse kernel sources, you will need:"
> 
>> +Workload overview
>> +=================
>> +
>> +We used strace to trace perf bench, stress-ng and paxtest workloads to
> 
> "In this section, we use strace to trace ..."
> 

Thank you for the review. I will address them in v3.

thanks,
-- Shuah