Message-ID: <3811dce6-ce81-2a2b-1891-a6ecaddfecdb@intel.com>
Date:   Tue, 31 Jan 2023 09:30:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH mm-unstable v4 1/6] mm: add folio_estimated_sharers()
Content-Language: en-US
To:     "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
        <linux-mm@kvack.org>
CC:     <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>
References: <20230130201833.27042-1-vishal.moola@gmail.com>
 <20230130201833.27042-2-vishal.moola@gmail.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20230130201833.27042-2-vishal.moola@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWRsUFJudGorSkFiSWtMd1NFR3hFN2hCdG1rQ3UxQmYrRHpRZTdRbFBpZ1R4?=
 =?utf-8?B?eVl6NFhrMlBkdmo3UHljeHQ1RGtYaVRhVElBbUVJc0NyVkliaG9Wa0EwMEJv?=
 =?utf-8?B?MGdEMHRMOEpZL2g3bGtjc3RrbDZaaG91N3REVGh0QjE2L0NEb2NRTytGZkl1?=
 =?utf-8?B?a1ZwcHl6bmZBeWd2bGJ5WHJidUF1V1BzZ2plRmZmU2YxbzNhb0VodSsvL3k0?=
 =?utf-8?B?cHBSRFVVT3hvV3NLQ1lHSkY1UVpMZ1J4NEgycHZmSXk2bEIvbDZwUUl0ei9T?=
 =?utf-8?B?Qm04TC9XZURMNTJOeEFjYTFvK2pJMkkranNmMDhYWi9rL1ZqdUNWbWdFUXdT?=
 =?utf-8?B?Ykd1dFZ2eW52c2hyR2FvSTlhcmllVUVyWEdDVjdwaTlzSnVnZTN2VGtvd2hL?=
 =?utf-8?B?a2VKcVV2K2FnYUNwS20yWlovODVLZFo3cUVWRVJBN3daUW5teGRnYTNsSTY3?=
 =?utf-8?B?OTFWWmtrSHhFb2hxNmNYdnZSbVJCUFo5dlVQN3ZsNWVyY0NNZlpuNmNXUlVo?=
 =?utf-8?B?WUFrenJLa1kzVlhzSUZWeDlxNlM5K0dadkZHTHlhS25QbjF6V1JHeVltL0E1?=
 =?utf-8?B?QnhsVCt4aUF5SDlhSXR5S1ljN2VMQVhBNk5wSlFnQ1lHMzArejB6Nm9KZnZG?=
 =?utf-8?B?aHdoM2JheGVIZXJiNlNabFhQMFRkTlMrYVltTEIyWGhiSSs4YXYvaVVNc3Rt?=
 =?utf-8?B?cjMyUjh0eWt3c3hrbmw2Wk90VnZWcGZCSTNhZklrN1R0bkgvMFF6Z2JldlI1?=
 =?utf-8?B?VXlsb3hja0ROQVhaRjIrMXNOandVMjcxNmlKNzV0VFJUT2NoVnBZRmxyTGJT?=
 =?utf-8?B?TldlbkpNRXBjUjRuN2hyWWllRlNrZFo0VnNRc1IyMUpqVHcxaUdvS3BBRVZK?=
 =?utf-8?B?ZEczNGNEUFM4WmREWUdtckdGZ3ZoRUl0dTB3dWUwUXFPMU04M2R6OXZiY2Zp?=
 =?utf-8?B?eUZhZTFBczVSOWl6cUxrRXJsbS9NYW5Pekt4MGVwaFNIZTdZZnp1b0FVc3RI?=
 =?utf-8?B?alBCYXBIVnl6MkhWRmwxNjVlN3RQTDJ6d0ZpK292ZG9WL0d2c2NPM1B6YXpp?=
 =?utf-8?B?VmRJSGdpaEVQM2RneitFa2J2RTNheU10VGFXblEvUnp3ek5ia2ZDNVNmQkNo?=
 =?utf-8?B?NnFBSzNNVjFQYWVhNmt0elBDcnUwUkg3NmtpQUNreGtWYXpyT1M4NGoyYjlO?=
 =?utf-8?B?S3NySEYyNVVkaTZSanpyODBOY081WDl6MXdYZUYrOHliUWlnalArOXJkV01K?=
 =?utf-8?B?WWN1WlppR3R5NndqU2hWdnBabzk1emhPaGJWcmE0NGkzMitLS0laVGRNODZh?=
 =?utf-8?B?N0pTbmM5b2F1REtrTFpNallLQkg2YXVOZUF2T3RqRHZqakx6c2hteW95cjVl?=
 =?utf-8?B?VWUvZW1sdW1mQnBZQlFqdlQ5RVVNNjdNKytKWjF5RmxCU2VPbjMzbG1JeWJk?=
 =?utf-8?B?MXJkcE1XTUgxQ1V3Y2dxZnQ0Z1R1OFZCTmRnLzhaVDBseWljaEF2eGJpQnhj?=
 =?utf-8?B?amNqZkNzcEVZWExyMzFTN2dJVTB5L0xvWEpsY2liVzB3eFFqem1rSjd0Rzlt?=
 =?utf-8?B?aGpGOGlCUVNkSGxFMmwxZWJzc2dYaW5QTFFCaTNnNDAxcXNYaVJhcHl1Y2NF?=
 =?utf-8?B?SStUdUs1K3VzaVhENkM5Y2xmYWxIVjExdHg1ZFIzbGRDUHBLYnB2a1c2L2J2?=
 =?utf-8?B?NHlWVDRZdmVYV1QyQyt5VVlEaTZpaFB5WkZtQjN6c1orbnQvSHlRaktibVJh?=
 =?utf-8?B?cDF1dGZqSzZqUVdnTmF4UnR0aXlQS3lXblZJbGV6cFd6TkJGVGlKWUFYQmMz?=
 =?utf-8?B?Z2FnWUtMUTdxUXVPMUVReit0VUxXVXR4WWdybnBscTQ2Wk5sYk1uNUhJUGlt?=
 =?utf-8?B?K0k1MW93TjRNTjAzK08zbndoMHRQN29uZXdMb0FVOEg0cG9rR2lSakhmcTlP?=
 =?utf-8?B?U214N3JUUTJCYzE2c281UVhFRER2dGI4NDQxdmZ1bThyMSs5aWx1VFhYcUNn?=
 =?utf-8?B?M3hYTFFkbFdyYzBFSlNWVk5saXl4N1pzVkFNc1pUL21icDZDSFZQVW1yVy91?=
 =?utf-8?B?Zjg2VHdRelV2ZlhCK3BGTjI1M3lpZ0F5OFp6TkNMMzlqMGFCZWVraVFwUFlH?=
 =?utf-8?B?UXRXbTFob0xvRVBTOGpBaWdxQ3d4Q0JtNGdCa3RSczU5eE40QXFMYzZ3dWhS?=
 =?utf-8?B?Znc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbbf84af-3ae3-4be4-dec8-08db032ac37d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 01:31:04.4089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0UDLvuYOIGGnCI9YfK3+OEmGuzonCpRFIWCkGHOKHC1WjHuJClLH67lvEmDkJGx8zu/pCBXAMAfPh1AIQriLaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5896
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/31/2023 4:18 AM, Vishal Moola (Oracle) wrote:
> folio_estimated_sharers() takes in a folio and returns the precise
> number of times the first subpage of the folio is mapped.
> 
> This function aims to provide an estimate for the number of sharers of a
> folio. This is necessary for folio conversions where we care
> about the number of processes that share a folio, but don't necessarily
> want to check every single page within that folio.
> 
> This is in contrast to folio_mapcount() which calculates the total
> number of the times a folio and all its subpages are mapped.
> 
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>


Regards
Yin, Fengwei

> ---
>  include/linux/mm.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 27b34f7730e7..c91bf9cdb3d0 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1905,6 +1905,24 @@ static inline size_t folio_size(struct folio *folio)
>  	return PAGE_SIZE << folio_order(folio);
>  }
>  
> +/**
> + * folio_estimated_sharers - Estimate the number of sharers of a folio.
> + * @folio: The folio.
> + *
> + * folio_estimated_sharers() aims to serve as a function to efficiently
> + * estimate the number of processes sharing a folio. This is done by
> + * looking at the precise mapcount of the first subpage in the folio, and
> + * assuming the other subpages are the same. This may not be true for large
> + * folios. If you want exact mapcounts for exact calculations, look at
> + * page_mapcount() or folio_total_mapcount().
> + *
> + * Return: The estimated number of processes sharing a folio.
> + */
> +static inline int folio_estimated_sharers(struct folio *folio)
> +{
> +	return page_mapcount(folio_page(folio, 0));
> +}
> +
>  #ifndef HAVE_ARCH_MAKE_PAGE_ACCESSIBLE
>  static inline int arch_make_page_accessible(struct page *page)
>  {