Message-ID: <4a48ffda-ab14-9b4b-ddc0-504f9f9f3b27@intel.com>
Date:   Tue, 31 Jan 2023 09:32:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH mm-unstable v4 6/6] mm/mempolicy: convert
 migrate_page_add() to migrate_folio_add()
Content-Language: en-US
To:     "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
        <linux-mm@kvack.org>
CC:     <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>
References: <20230130201833.27042-1-vishal.moola@gmail.com>
 <20230130201833.27042-7-vishal.moola@gmail.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20230130201833.27042-7-vishal.moola@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWJZOWs1bjV6QlliYVJrRDN1a292enhhZkE3RTlOZndMYVB3N0JUQkJwam1j?=
 =?utf-8?B?WjRxTVptRmVlVE9JY2dxdzNiNk9KaGhjUFRQZWJWL05oa3ZqTE83SWV0OEpz?=
 =?utf-8?B?UlcyU0RSLzYyTThNSXZ5dFJVcHRybFZmdXZsZzgwOXRIZTNUd1VBbXBUQjE2?=
 =?utf-8?B?SHdsY3ExOEI0eUdKcEhzaUJwNkxWckYxNW1uSkdnem0zSlNlV3JTK1NhaGFm?=
 =?utf-8?B?ZVB3VTJrNTZFa2t0VE5iQ29mMkdtYS9oeXptUHpsZ0tnY2t1aE9ySkhtanhC?=
 =?utf-8?B?YVVWTlZWSTREWVQ0dmtoM2dqWHNySEhsRzBLKyt2SFBxdXZtdUUwcWxmaWVy?=
 =?utf-8?B?TjRNVHNEMmpLanlBRFcwcjBmN1NoMlEyb1cwd2o5RWY4TVNLTThiem5kcEh3?=
 =?utf-8?B?ZTVrV1psenhCMDdzaCs5bVZGZUY1a254eEpSL1M0S0NSUG8zOHNrNTFxd1pl?=
 =?utf-8?B?V3hxU3I4cVpITlBDM3FxWkpZcU9hR2VBYUFPaVd5eFU1OEk4Mll3RXEvYjNR?=
 =?utf-8?B?TG5qUUNsMGJoZUhHdGRIMGQzVkhzRkJVYk9QSjI1Wk9aMVR3OWY3THc2OTVo?=
 =?utf-8?B?OTl2TVdVVmxhQ2JNQVdjbFAvWDJrLzFkcW1idW5IbXQySnk5MjNSMTBJYzVm?=
 =?utf-8?B?dEczNHNrN2NGM0ZUaVdocUVZUnpnTHByU3BvV2VQVzh3ZEJiU0RVdjg0a0VN?=
 =?utf-8?B?SjdwZ2crWmprSWZENkRYMUV6QWZjZzNUT01xck5XakJ5NFJIc2VEUklyOGcw?=
 =?utf-8?B?UjNWMUZ1NHlpUW9ycUNieUxSeisvcTZpWDh6bm1BZXNnd29qTlRDSWJLV3hF?=
 =?utf-8?B?ekJXSk45TmRxWFliVzN3dEdwbUtPYU5VK25ibmZrcW1kQnlUTHRxYjBJeWlT?=
 =?utf-8?B?a0ZLY3RKTzJkMHJudlJmcFUwU2JlanVpUE85bURHRDFBL2tWTFNOelY3amxi?=
 =?utf-8?B?MW9jaXJ6RW9qWlFiUUZGcXliZEcrOGVMc2VpczFJeVJIWExSUlhCQXR0Yys3?=
 =?utf-8?B?aUxNWmFXK1JxandZQ0I1dUdBQjUrYnd5UHYveEN1eW5CeWVHNTI4eFcxMjly?=
 =?utf-8?B?bDY5U1pvdmxCTmJOK0ZJQzAxYU1JSUo0SUE1Z0s5Mkp6Q1Z4TTdDWFAvMkxn?=
 =?utf-8?B?czc4WGFTUkRYU3dvMFdiWTJWQmxnQ0RZcEhPeWNXVW1aTnRLSDE3S0c4eXdH?=
 =?utf-8?B?R2RGelFOOURKZ2Jlb09qclhoTWRxUSthYUx3T1dweVZVekVtTlNmQS94RUFh?=
 =?utf-8?B?eENuWUdYR0ZUeWM2K0JjVzBTdlRBb3FaazdoTW9LRENVcUR0WGlOOVlVeXlF?=
 =?utf-8?B?c0FESmJTaGlIZUJnUlpaYVl3Q3BOK0MvdDIwcmZ1ZUhIekE5SEI5eE9idWtn?=
 =?utf-8?B?N2l0TVlFa1NBMUFEU0xWdFhqNWhTbVdUYWJ5bE5Pem9zcjh4Q0U4Zzl0Zjhr?=
 =?utf-8?B?NVJuWUhWSzJtT1lVUk80bWJCKzBBcEp4WGViUFFPamp0ZFZuNXV5K0VwYVhq?=
 =?utf-8?B?UkNvSk12V1g3dFlYMDBTcTN1NjZxT1hlNEFRK3JpS2RTSXJPL2d3aVZ6Qjh1?=
 =?utf-8?B?MllkSlIxeERaRis0SzdKQkJnaDRVS3h2OUVkMkV3RHN6YlgxSkEvdFhQZEJv?=
 =?utf-8?B?dXBFRDBsb2dvYmVxd3RJN0hRR2xjRXNQWjVhZ3cySmFOSVBtZnJqOTdGN3oy?=
 =?utf-8?B?ciswSDJwUjMyMk96WEs5and3ZGc1WisyNXhmWWFYRytQanhLZnB4TU5XT3h0?=
 =?utf-8?B?c3FTdFlJWFBKQ1A1TTRHS0ZCOU9sTm5GTU4yTlQrTng3dXZ2UGlxWGxteC9E?=
 =?utf-8?B?RUdoY2pzbjM0WURUejlCQmg5N2VJcEI2bDVmTnFZMHo5WHphYktCdUgxdTNR?=
 =?utf-8?B?RDFDa1JEeWNZUjVGSks3MUMzNXlOeGFHbDJ1ck51OWhDeUwrSXk1czVOU203?=
 =?utf-8?B?YzZJbW1mbnJSRzRqY29HYWRoc3RXTHd0ditRYzhvNjlaQWh5YUJVVXVjb0R5?=
 =?utf-8?B?RWltZ2NZeUxvMS9OVVNoMmlBN1RwTHZVdG01UHJnNEtOd25lZTZ4M0xYNmt6?=
 =?utf-8?B?cnZZNjZ3b015T0JFUERMVVJwQlJwYlhiMVd5R0svZHRYUUlUUHVjS0lOYTE5?=
 =?utf-8?B?OGUwbmpPc1RzTldtdkJUNVBGYXV6ZkdFaEErZTFib2U5SHFqT1pCMWJSZENY?=
 =?utf-8?B?Y1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 44cfbccf-1a0d-41db-d4d3-08db032b03e5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 01:32:29.0521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yNm9tg9gaAVr5qTHKXrI7vzHdsbHhdsl7V1tSrPG9d5VHAtcoycSq06pCakN8AQY9F9B9BxNvbaWKkUnNULMKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5896
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/31/2023 4:18 AM, Vishal Moola (Oracle) wrote:
> Replace migrate_page_add() with migrate_folio_add().  migrate_folio_add()
> does the same a migrate_page_add() but takes in a folio instead of a page.
> This removes a couple of calls to compound_head().
> 
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

Regards
Yin, Fengwei

> ---
>  mm/mempolicy.c | 39 ++++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 6a68dbce3b70..0919c7a719d4 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -414,7 +414,7 @@ static const struct mempolicy_operations mpol_ops[MPOL_MAX] = {
>  	},
>  };
>  
> -static int migrate_page_add(struct page *page, struct list_head *pagelist,
> +static int migrate_folio_add(struct folio *folio, struct list_head *foliolist,
>  				unsigned long flags);
>  
>  struct queue_pages {
> @@ -476,7 +476,7 @@ static int queue_folios_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr,
>  	/* go to folio migration */
>  	if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) {
>  		if (!vma_migratable(walk->vma) ||
> -		    migrate_page_add(&folio->page, qp->pagelist, flags)) {
> +		    migrate_folio_add(folio, qp->pagelist, flags)) {
>  			ret = 1;
>  			goto unlock;
>  		}
> @@ -544,7 +544,7 @@ static int queue_folios_pte_range(pmd_t *pmd, unsigned long addr,
>  			 * temporary off LRU pages in the range.  Still
>  			 * need migrate other LRU pages.
>  			 */
> -			if (migrate_page_add(&folio->page, qp->pagelist, flags))
> +			if (migrate_folio_add(folio, qp->pagelist, flags))
>  				has_unmovable = true;
>  		} else
>  			break;
> @@ -1021,27 +1021,28 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask,
>  }
>  
>  #ifdef CONFIG_MIGRATION
> -/*
> - * page migration, thp tail pages can be passed.
> - */
> -static int migrate_page_add(struct page *page, struct list_head *pagelist,
> +static int migrate_folio_add(struct folio *folio, struct list_head *foliolist,
>  				unsigned long flags)
>  {
> -	struct page *head = compound_head(page);
>  	/*
> -	 * Avoid migrating a page that is shared with others.
> +	 * We try to migrate only unshared folios. If it is shared it
> +	 * is likely not worth migrating.
> +	 *
> +	 * To check if the folio is shared, ideally we want to make sure
> +	 * every page is mapped to the same process. Doing that is very
> +	 * expensive, so check the estimated mapcount of the folio instead.
>  	 */
> -	if ((flags & MPOL_MF_MOVE_ALL) || page_mapcount(head) == 1) {
> -		if (!isolate_lru_page(head)) {
> -			list_add_tail(&head->lru, pagelist);
> -			mod_node_page_state(page_pgdat(head),
> -				NR_ISOLATED_ANON + page_is_file_lru(head),
> -				thp_nr_pages(head));
> +	if ((flags & MPOL_MF_MOVE_ALL) || folio_estimated_sharers(folio) == 1) {
> +		if (!folio_isolate_lru(folio)) {
> +			list_add_tail(&folio->lru, foliolist);
> +			node_stat_mod_folio(folio,
> +				NR_ISOLATED_ANON + folio_is_file_lru(folio),
> +				folio_nr_pages(folio));
>  		} else if (flags & MPOL_MF_STRICT) {
>  			/*
> -			 * Non-movable page may reach here.  And, there may be
> -			 * temporary off LRU pages or non-LRU movable pages.
> -			 * Treat them as unmovable pages since they can't be
> +			 * Non-movable folio may reach here.  And, there may be
> +			 * temporary off LRU folios or non-LRU movable folios.
> +			 * Treat them as unmovable folios since they can't be
>  			 * isolated, so they can't be moved at the moment.  It
>  			 * should return -EIO for this case too.
>  			 */
> @@ -1235,7 +1236,7 @@ static struct page *new_page(struct page *page, unsigned long start)
>  }
>  #else
>  
> -static int migrate_page_add(struct page *page, struct list_head *pagelist,
> +static int migrate_folio_add(struct folio *folio, struct list_head *foliolist,
>  				unsigned long flags)
>  {
>  	return -EIO;