MIME-Version: 1.0
References: <CAH2r5muSiYCHbHg8zgF1jNiEyafXBhH_pcytudU-4_LQ6DyUmg@mail.gmail.com>
In-Reply-To: <CAH2r5muSiYCHbHg8zgF1jNiEyafXBhH_pcytudU-4_LQ6DyUmg@mail.gmail.com>
From:   Steve French <smfrench@gmail.com>
Date:   Mon, 30 Jan 2023 20:01:06 -0600
Message-ID: <CAH2r5mstTSBJLRht6QRoJy3yy0pmNxg_CFS0Pid=bikLWzp8_Q@mail.gmail.com>
Subject: Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
To:     Namjae Jeon <linkinjeon@kernel.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>
Content-Type: multipart/mixed; boundary="0000000000001b584805f385b531"
Precedence: bulk

--0000000000001b584805f385b531
Content-Type: text/plain; charset="UTF-8"

updated version following David Howell's suggestion for using if/endif
to fix the indentation


On Sun, Jan 29, 2023 at 6:01 PM Steve French <smfrench@gmail.com> wrote:
>
> Fix indentation of server config options, and also since
> support for very old, less secure, NTLM authentication was removed
> (and quite a while ago), remove the mention of that in Kconfig, but
> do note Kerberos (not just NTLMv2) which are supported and much
> more secure.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/ksmbd/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> index e1fe17747ed6..4153e5491435 100644
> --- a/fs/ksmbd/Kconfig
> +++ b/fs/ksmbd/Kconfig
> @@ -33,17 +33,18 @@ config SMB_SERVER
>     in ksmbd-tools, available from
>     https://github.com/cifsd-team/ksmbd-tools.
>     More detail about how to run the ksmbd kernel server is
> -   available via README file
> +   available via the README file
>     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>
>     ksmbd kernel server includes support for auto-negotiation,
>     Secure negotiate, Pre-authentication integrity, oplock/lease,
>     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>     smb3 encryption, copy-offload, secure per-user session
> -   establishment via NTLM or NTLMv2.
> +   establishment via Kerberos or NTLMv2.
>
>  config SMB_SERVER_SMBDIRECT
>   bool "Support for SMB Direct protocol"
> + depends on SMB_SERVER
>   depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS ||
> SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
>   select SG_POOL
>   default n
>
> --
> Thanks,
>
> Steve


-- 
Thanks,

Steve

--0000000000001b584805f385b531
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-ksmbd-update-Kconfig-to-note-Kerberos-support-and-fi.patch"
Content-Disposition: attachment; 
	filename="0001-ksmbd-update-Kconfig-to-note-Kerberos-support-and-fi.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_ldjlfbgc0>
X-Attachment-Id: f_ldjlfbgc0

RnJvbSBhMzM3MWIzNmQzNDZmOTc1NjAxNmU1MzIxYWNlYmMyZGFhYjk2ODZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBGcmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+
CkRhdGU6IFN1biwgMjkgSmFuIDIwMjMgMTc6NDk6NTkgLTA2MDAKU3ViamVjdDogW1BBVENIIDEv
Ml0ga3NtYmQ6IHVwZGF0ZSBLY29uZmlnIHRvIG5vdGUgS2VyYmVyb3Mgc3VwcG9ydCBhbmQgZml4
CiBpbmRlbnRhdGlvbgoKRml4IGluZGVudGF0aW9uIG9mIHNlcnZlciBjb25maWcgb3B0aW9ucywg
YW5kIGFsc28gc2luY2UKc3VwcG9ydCBmb3IgdmVyeSBvbGQsIGxlc3Mgc2VjdXJlLCBOVExNIGF1
dGhlbnRpY2F0aW9uIHdhcyByZW1vdmVkCihhbmQgcXVpdGUgYSB3aGlsZSBhZ28pLCByZW1vdmUg
dGhlIG1lbnRpb24gb2YgdGhhdCBpbiBLY29uZmlnLCBidXQKZG8gbm90ZSBLZXJiZXJvcyAobm90
IGp1c3QgTlRMTXYyKSB3aGljaCBhcmUgc3VwcG9ydGVkIGFuZCBtdWNoCm1vcmUgc2VjdXJlLgoK
QWNrZWQtYnk6IE5hbWphZSBKZW9uIDxsaW5raW5qZW9uQGtlcm5lbC5vcmc+CkFja2VkLWJ5OiBE
YXZpZCBIb3dlbGxzIDxkaG93ZWxsc0ByZWRoYXQuY29tPgpTaWduZWQtb2ZmLWJ5OiBTdGV2ZSBG
cmVuY2ggPHN0ZnJlbmNoQG1pY3Jvc29mdC5jb20+Ci0tLQogZnMva3NtYmQvS2NvbmZpZyB8IDgg
KysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvZnMva3NtYmQvS2NvbmZpZyBiL2ZzL2tzbWJkL0tjb25maWcKaW5kZXgg
ZTFmZTE3NzQ3ZWQ2Li43MDU1Y2I1ZDI4ODAgMTAwNjQ0Ci0tLSBhL2ZzL2tzbWJkL0tjb25maWcK
KysrIGIvZnMva3NtYmQvS2NvbmZpZwpAQCAtMzMsMTQgKzMzLDE2IEBAIGNvbmZpZyBTTUJfU0VS
VkVSCiAJICBpbiBrc21iZC10b29scywgYXZhaWxhYmxlIGZyb20KIAkgIGh0dHBzOi8vZ2l0aHVi
LmNvbS9jaWZzZC10ZWFtL2tzbWJkLXRvb2xzLgogCSAgTW9yZSBkZXRhaWwgYWJvdXQgaG93IHRv
IHJ1biB0aGUga3NtYmQga2VybmVsIHNlcnZlciBpcwotCSAgYXZhaWxhYmxlIHZpYSBSRUFETUUg
ZmlsZQorCSAgYXZhaWxhYmxlIHZpYSB0aGUgUkVBRE1FIGZpbGUKIAkgIChodHRwczovL2dpdGh1
Yi5jb20vY2lmc2QtdGVhbS9rc21iZC10b29scy9ibG9iL21hc3Rlci9SRUFETUUpLgogCiAJICBr
c21iZCBrZXJuZWwgc2VydmVyIGluY2x1ZGVzIHN1cHBvcnQgZm9yIGF1dG8tbmVnb3RpYXRpb24s
CiAJICBTZWN1cmUgbmVnb3RpYXRlLCBQcmUtYXV0aGVudGljYXRpb24gaW50ZWdyaXR5LCBvcGxv
Y2svbGVhc2UsCiAJICBjb21wb3VuZCByZXF1ZXN0cywgbXVsdGktY3JlZGl0LCBwYWNrZXQgc2ln
bmluZywgUkRNQShzbWJkaXJlY3QpLAogCSAgc21iMyBlbmNyeXB0aW9uLCBjb3B5LW9mZmxvYWQs
IHNlY3VyZSBwZXItdXNlciBzZXNzaW9uCi0JICBlc3RhYmxpc2htZW50IHZpYSBOVExNIG9yIE5U
TE12Mi4KKwkgIGVzdGFibGlzaG1lbnQgdmlhIEtlcmJlcm9zIG9yIE5UTE12Mi4KKworaWYgU01C
X1NFUlZFUgogCiBjb25maWcgU01CX1NFUlZFUl9TTUJESVJFQ1QKIAlib29sICJTdXBwb3J0IGZv
ciBTTUIgRGlyZWN0IHByb3RvY29sIgpAQCAtNTQsNiArNTYsOCBAQCBjb25maWcgU01CX1NFUlZF
Ul9TTUJESVJFQ1QKIAkgIFNNQiBEaXJlY3QgYWxsb3dzIHRyYW5zZmVycmluZyBTTUIgcGFja2V0
cyBvdmVyIFJETUEuIElmIHVuc3VyZSwKIAkgIHNheSBOLgogCitlbmRpZgorCiBjb25maWcgU01C
X1NFUlZFUl9DSEVDS19DQVBfTkVUX0FETUlOCiAJYm9vbCAiRW5hYmxlIGNoZWNrIG5ldHdvcmsg
YWRtaW5pc3RyYXRpb24gY2FwYWJpbGl0eSIKIAlkZXBlbmRzIG9uIFNNQl9TRVJWRVIKLS0gCjIu
MzQuMQoK
--0000000000001b584805f385b531--