Message-ID: <a4a83fd2-b1e6-3dce-6881-8abe71c7e934@amd.com>
Date:   Tue, 31 Jan 2023 08:38:31 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [RFC PATCH 03/11] virt: sev-guest: Add snp_guest_req structure
Content-Language: en-US
To:     Dionna Amalie Glaze <dionnaglaze@google.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, bp@alien8.de,
        thomas.lendacky@amd.com, pgonda@google.com, jroedel@suse.de,
        mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com,
        seanjc@google.com, pbonzini@redhat.com, michael.roth@amd.com,
        ketanch@iitk.ac.in
References: <20230130120327.977460-1-nikunj@amd.com>
 <20230130120327.977460-4-nikunj@amd.com>
 <CAAH4kHbJEcg9p=mXi2aQZFs1bopZgeqWKiwGWu2V4YsgmwHmmw@mail.gmail.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <CAAH4kHbJEcg9p=mXi2aQZFs1bopZgeqWKiwGWu2V4YsgmwHmmw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUNXZHNBTTM0SlF1aG10dlpZY1JRNFR6ZDZqZDBNL2Z6Z2pTNXVRYmN0QVB4?=
 =?utf-8?B?Z1NEMVRLTzVqSVRBNGlJblFHWHMwZVpGS1BLL3cxeUh2dzlOSVJWeUJad1lR?=
 =?utf-8?B?T3NIKzFybWl1ODVDN1pWS2JMNDgvSmVPc1p2TEFJenc5M2ZSTFlKb2I4ekdX?=
 =?utf-8?B?MzF1Ymc2L2dSSzlIdnhaNERYVjg0OThpNnVHMWxRWVZCTUFESTYwNDNRaDNs?=
 =?utf-8?B?UGpQaTV6VXpwK0wvMHVuVFNSZDliaFZxT0Rjb1Q4NXhoWFE2SkZ1Ti9WZHhO?=
 =?utf-8?B?M053cnUyM2VrSzY4M3ZWbVEyKzJJYVFnLzc5UUNRMFkzNkNVUVJHUDQ5QXdj?=
 =?utf-8?B?YmxmYUt3a2hMYW1BY1lRUGprRisvTnh6eDVackIzU1Z6Umg5WUpodURmKzds?=
 =?utf-8?B?WU5PbGlXMTVyb1l5cjg3R3lTaW12MnRKSEo1YWc4NHV6VGxBcTlPTzVWUVp2?=
 =?utf-8?B?QjUyanN4a3lEM3p6aXJML3J2Z29wTzZqNUc3b1BIYU1SSWg1Sk00Rng2TUoz?=
 =?utf-8?B?MjJxT3p5di9VcCtNOFJCNWFCb0FKOE5SOEJ6QWlRQVdXVDBrSGN2RnB6czlX?=
 =?utf-8?B?QkF5U2JhL3lWdDJvOTNRSVRpcTVhaTlvaXp6dmlwTG1tNHdpUkIwUHF6N2ph?=
 =?utf-8?B?WllDbVN1L1VQR3BueHg0S0J5VldpS1k1UVArelFzaUtnRDZLb3dhWnYzb3BY?=
 =?utf-8?B?cE40U25lZTFYZXNIbE54cUZRQUMxeXBzSXBQNU9zblJTTHRkWmNhNFVHYW5F?=
 =?utf-8?B?RGNYSEdEWllGYzQ0NWYwSVhUNi82R1BhS2ZEVDRPN3JDZjE3dlFwS3V5cGw4?=
 =?utf-8?B?QkFtd2J3TUY2S3FoKy9nOUVXY1g4SGJIeWZUZWZDK2xFOStYazhtaUVCVzE3?=
 =?utf-8?B?MTQyMmlqRW8yd3NtaVNNZkQ3QUxxS08wVjFYMVFLcDdhaVV0WHYwME9hN3lY?=
 =?utf-8?B?U0JRMjBaK2lxTnY0bG1vVFV5bzN0RWNWd1UwWUdRMnI4SC9rRCsxV0tVNmFB?=
 =?utf-8?B?SW81NjZpeXJOSFRadmZJcWVwS1dXKzZWNnNwUXdiaytSTUlqaGd4UmhFb2pN?=
 =?utf-8?B?c29ZbENiK0RIekVsUFRLMCtIc1FIWVprSG54ZXoyQVBRaS81cm5WVnRlb3U5?=
 =?utf-8?B?Qm5OOTJ5UzNpQnh0MDhWQVdvWHI1WnBJVHltdno3aUFhbkd1bjdQSWRWdC8w?=
 =?utf-8?B?M0twcDNwQmYrdUlOQTYwcXRjS2Vrd0h0QkF6YWJFdGNiYnlFS3IxMGszajI5?=
 =?utf-8?B?UUFwTitNN1prQ0JoZXJDZk45TzZ6dUZCVjhkcVdRMjh3cWdtVXNUOG9hVlZJ?=
 =?utf-8?B?SmRRc1pUZlFhekpRdlViQUdqQ2VTZzRGZnUzYmcybUJCUUxlQS9yV09uYzFl?=
 =?utf-8?B?ZHp3TVduNkdERDFKVXlCV0ZsQy9WTDFKVmpVbE9qSm5NWit6NHQ4L1VtOUU1?=
 =?utf-8?B?elNkWVE3U0xqbVJHcFFXY3NXTUlwSitPandmdE53WG5peEhoaERhbHNHblZ4?=
 =?utf-8?B?aTgrbTlSYXAyZWIrZGVkRGZKTEp1WE9TMkpsYnQ5OVlaOEZyYnB6SFdJUk1p?=
 =?utf-8?B?RDBlT05XT05nQWloWlIrOCt0OHkzcisxM1J5UCs4Ykt3cUI4LzFsR1hVUTJi?=
 =?utf-8?B?MFE0dVNxY0FCQlNQT01DR2doZjFnWENPdjdUci82RjFzQXZGOVAwbXRQV2Iy?=
 =?utf-8?B?S3QzSGJ3L3QwbnBVaUlEUGVRc1NpMUdFWFVvMlpSNllZYnVLa3lJVzdnS0c2?=
 =?utf-8?B?MUp3NjI3RlpaNDVYdER3V0kwQXAyWjZ3NlZMSU1pcGZTS1NQcXY5QkV0THF0?=
 =?utf-8?B?VUw4cDRBMytXSWRRVXJESWtxYng3bjNHdjlDZzBqSzN5SHV2MnltTUJ2dXlq?=
 =?utf-8?B?MGtsVENkNlJ4QlhpR3hXN3BmM3lTWGVONXFLeHNQbWkzUWphMGFQS0lJTUE1?=
 =?utf-8?B?amRRcFJyZlZsVEhZS2htZmNwQVNSdUx0b0Z4RVBrZDFMYlc2M21ZeG1IaG01?=
 =?utf-8?B?bE5MNlk4K2wvYXlsRmlEZFViSlhMUFBoTlhhVFFnakN5WTVDQUZhckt4eStq?=
 =?utf-8?B?T1lTdVFFbmFNNXRoUG96alcyckQweTQzSmFvbXkvdGRta0d3eFlyTmxRMFNr?=
 =?utf-8?Q?t8QVVt7gzW8JXaeAqbixoESrt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ad8712b-b78c-41b6-b296-08db0338774f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 03:08:46.2194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: su18K+MhUuvKj+B9Zy0sBehKtw3cgR93F+MHIPm6KNISWfhpFbrc55FnnEzhwOd5YGXvnT6uqgVWdpVUMuPmqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5030
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 31/01/23 00:15, Dionna Amalie Glaze wrote:
>> +static int snp_send_guest_request(struct snp_guest_dev *snp_dev, struct snp_guest_req *req)
>>  {
>>         unsigned long err;
>>         u64 seqno;
>>         int rc;
>>
>> +       if (!snp_dev || !req)
>> +               return -ENODEV;
>> +
>>         /* Get message sequence and verify that its a non-zero */
>>         seqno = snp_get_msg_seqno(snp_dev);
>>         if (!seqno)
>> @@ -261,7 +253,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
>>         memset(snp_dev->response, 0, sizeof(struct snp_guest_msg));
>>
>>         /* Encrypt the userspace provided payload */
>> -       rc = enc_payload(snp_dev, seqno, msg_ver, type, req_buf, req_sz);
>> +       rc = enc_payload(snp_dev, seqno, req, vmpck_id);
>>         if (rc)
>>                 return rc;
>>
>> @@ -271,7 +263,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
>>          * sequence number must be incremented or the VMPCK must be deleted to
>>          * prevent reuse of the IV.
>>          */
>> -       rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
>> +       rc = snp_issue_guest_request(req->exit_code, &snp_dev->input, &err);
>>
>>         /*
>>          * If the extended guest request fails due to having too small of a
>> @@ -279,11 +271,11 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
>>          * extended data request in order to increment the sequence number
>>          * and thus avoid IV reuse.
>>          */
>> -       if (exit_code == SVM_VMGEXIT_EXT_GUEST_REQUEST &&
>> +       if (req->exit_code == SVM_VMGEXIT_EXT_GUEST_REQUEST &&
>>             err == SNP_GUEST_REQ_INVALID_LEN) {
>>                 const unsigned int certs_npages = snp_dev->input.data_npages;
>>
>> -               exit_code = SVM_VMGEXIT_GUEST_REQUEST;
>> +               req->exit_code = SVM_VMGEXIT_GUEST_REQUEST;
>>
>>                 /*
>>                  * If this call to the firmware succeeds, the sequence number can
>> @@ -293,7 +285,7 @@ static int handle_guest_request(struct snp_guest_dev *snp_dev, u64 exit_code, in
>>                  * of the VMPCK and the error code being propagated back to the
>>                  * user as an ioctl() return code.
>>                  */
>> -               rc = snp_issue_guest_request(exit_code, &snp_dev->input, &err);
>> +               rc = snp_issue_guest_request(req->exit_code, &snp_dev->input, &err);
>>
> 
> This is going to have a merge conflict with "[PATCH v13 1/4]
> virt/coco/sev-guest: Add throttling awareness", which is an important
> fix to ensure hosts are allowed to throttle guest requests and guests
> are able to retry instead of disabling the vmpck. I think that set of
> patches, or at least the first patch, is going to be going in before
> this series. Please be aware.

Yes, I am aware of the series. I can rebase my patches once that goes in.

Regards
Nikunj