From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Daniel Vacek <neelx@redhat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v3] ice/ptp: fix the PTP worker retrying
 indefinitely if the link went down
Thread-Topic: [Intel-wired-lan] [PATCH v3] ice/ptp: fix the PTP worker
 retrying indefinitely if the link went down
Thread-Index: AQHZLEqNzb+bO6iWF0af7DRt8fYlYq63/dcA
Date:   Tue, 31 Jan 2023 04:20:02 +0000
Message-ID: <BYAPR11MB3367C4727A544546409E8403FCD09@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230117181533.2350335-1-neelx@redhat.com>
 <20230119202317.2741092-1-neelx@redhat.com>
In-Reply-To: <20230119202317.2741092-1-neelx@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zuum+lhwCrzJTsvVNVPwwC8oDY/b/9vtDMJF2m+wl3qbcziAIrseWrbPpovY?=
 =?us-ascii?Q?9TlecKzSp5tMX2S8Yvuiszxi8J44SUZv4e3UHk/Yo5iIebpy3mXZs2GsbEyZ?=
 =?us-ascii?Q?dUnpHcRBp2NMLZI5bUbSk0G5sgN7Mj9NJWEZfkDIH2ZKXDUDbPk4Ws7TDmCQ?=
 =?us-ascii?Q?L2nRyvayq6bp19x7GwiVY2EN3UWB1ukTsggjX5lqaB6cwSkCTAcvC3EKZLtl?=
 =?us-ascii?Q?XJaNvl1JOnqX7wKzkI8xJFTKZj0EIcHF+0HV2pdhMV+Sqe0CTvig24rNCjbN?=
 =?us-ascii?Q?VrskE3Ogiw9cepojZpLDWWYBHLoRQI7As9CB73TAmxUNfDns3eZ1DIntpO3l?=
 =?us-ascii?Q?47Syx0wD0axSYNjfb9zo64Zuy9aAgsQSoeRXuNuyh3vC0SFb/nN20rkkpC0A?=
 =?us-ascii?Q?V2a8JjDkh10aGZ32c+fTr8coI69BVJ40BGV+X1TNnfaGf2g5VNzW/FHxZ+yY?=
 =?us-ascii?Q?1a1p214xO8uY6v86E6stq5wOKeG7InKRwgN3tsBtU2QbEJcbU8u2hdSTTDXj?=
 =?us-ascii?Q?vSIH2ItenN5dHLV9flQZh4zNlf8HU973Z5QUjRVSOiFXKjFnrh3P+Mcy9qTY?=
 =?us-ascii?Q?W6tWar5++UQF2/t9WW/+WgF+Z/pnM/+yVhuo+zl6YdzTGGYKEV+4/bHuH5vR?=
 =?us-ascii?Q?RMFZ+bFYpbViomk6oigK4upfeOoB8D5q3OUa6VyOEurS+hZfX2r54CCle6Ow?=
 =?us-ascii?Q?wQqb0djcrwkHE4xqAyRImTTN7RFPdjYFgu5lymn2i5jXE6Eocm5F/L3PNntc?=
 =?us-ascii?Q?AbTuD+Lrm1dJN5ra4nH/M3xxkHu1Oj1pdKDhio6uogT+GAIiNTthTWcWaEER?=
 =?us-ascii?Q?+NBSLZb3gMInw13KEbviwz0jvi1OrH3tAtyuUCI07fSgZl+kRM5hVIbuk9NE?=
 =?us-ascii?Q?SFSpGV85pTZAd2wKi/3BrgcvWJTEvU1Ellh4Nx3dCdjufi5dcXqGzNTanK1Q?=
 =?us-ascii?Q?wTPg1mDYjsmLGBN9TgRNuT6DI9XpXGxGSIDhQuwE40+WCCLF3pNy78gXouZu?=
 =?us-ascii?Q?YCEHMRl6NsjHjfe3vMKTOaR4V6piBRf3x4Diko53ttjAmQmipxBZvnUtVwuy?=
 =?us-ascii?Q?4miuYrTFaHGjaxHD8WVLzoYafOTp2pvZGCPC0njc4xcQkDMkPTYHateoaj+U?=
 =?us-ascii?Q?VeTz2g+RA9uMTH6oFtF5C1xL+jwLuyqVHpk1LubbtDGJg8Qklu7xSZkkCuQH?=
 =?us-ascii?Q?bCwPrf5f0NHqeqMADEX4A2UlGvJR7Av5XALZAACO+h7R+BkY/nagfN06H0Az?=
 =?us-ascii?Q?hF+HkgSezqEX+5ITzGhZHq0DMVIKZ2MkZXJ76oIcWi4sx9RZ9Ju7t0mdSU/n?=
 =?us-ascii?Q?hQcS7D910Ej/trRdv2DatnWAZonUmK16d4hue7AVNgeONiWaTjGWwEjIZJ5f?=
 =?us-ascii?Q?oIUb7RINvwGtSt0hvqjWjoLhFcbm2I9I0Op9b/R7ePmiwAWcK9yFrHYQdJB5?=
 =?us-ascii?Q?3HMpVR0SVBBQ7C2gotZyjAZki6dpxQkYfDxmydZmo7XFzjAJ5o/he3DIVxYL?=
 =?us-ascii?Q?VBGRGrG57FcQ4YjKNoWi1dGiG+2x6qwH92Om0wq/niuabeluufEumr5rXl9E?=
 =?us-ascii?Q?Gtd3rWst1hEf/vUxFgBlVogmKt6sY621LzTXf2i6?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b79e72b9-495c-48b2-4020-08db03426ca2
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 04:20:02.8042
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uc97JgE+UVRQsaBYyA9LMvm/eCccH1WzJu1Y/66kA/Zb0tTWkwGvHWB72V4g2NQc86JPuyMaUb1kkl56JY0NPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4875
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Daniel Vacek
> Sent: Friday, January 20, 2023 1:53 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Richard Cochran
> <richardcochran@gmail.com>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Daniel Vace=
k
> <neelx@redhat.com>; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v3] ice/ptp: fix the PTP worker retryin=
g
> indefinitely if the link went down
>=20
> When the link goes down the ice_ptp_tx_tstamp() may loop re-trying to
> process the packets till the 2 seconds timeout finally drops them.
> In such a case it makes sense to just drop them right away.
>=20
> Signed-off-by: Daniel Vacek <neelx@redhat.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)