Date:   Tue, 31 Jan 2023 05:34:27 +0000
From:   Wyes Karny <wyes.karny@amd.com>
To:     Tor Vic <torvic9@mailbox.org>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Huang Rui <ray.huang@amd.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Mario.Limonciello@amd.com, Perry.Yuan@amd.com,
        Ananth Narayan <ananth.narayan@amd.com>,
        gautham.shenoy@amd.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Bagas Sanjaya <bagasdotme@gmail.com>, santosh.shukla@amd.com,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v3 0/6] amd_pstate: Add guided autonomous mode support
Message-ID: <20230131053427.cdpg5zaqyxf7ou2f@beas>
References: <20230119115017.10188-1-wyes.karny@amd.com>
 <8c09f806-b00d-515b-bd1d-2f433e44b1a4@mailbox.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c09f806-b00d-515b-bd1d-2f433e44b1a4@mailbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gAVue0XIByMFizkYV1R5Ib38pXfb6lZr6y9mrIC4N3aXv1JgP8fDVjQrt610?=
 =?us-ascii?Q?foWL1fELNDPBfbHDfG1zbmeL+eK87as6Bpf3obYm22bB6XVLdiZYDMNbnLAd?=
 =?us-ascii?Q?E0x132Zz41c56nUK9q4WweeI14Rzq6G1wBNg5Rn95Clj5GitRJVhwgcXPtA1?=
 =?us-ascii?Q?9kAxHRKtdivU487q92jxRAXSk4cOjDfUewv+xAg+gzc2qu3Tv+ftBh5RT5S+?=
 =?us-ascii?Q?kuA5oXs4Z6b9y+xGoUl8MLV2ocoXJ6Gq8k7jn29B7m8/GMfWQIK9H+PMx04B?=
 =?us-ascii?Q?znRjK2BlzlJrzpBy5eIpNGIc2XCdVYwvA9cwLTS7aaPcPKWw0sFmbhHfz9Vl?=
 =?us-ascii?Q?a5E2ZtjY5D38quR5cDDs3YOct5YH2vmi+kxNkchhakXG5viseTsLsKN85Dit?=
 =?us-ascii?Q?wcoSjpumgdHYIGUAVCbgKmjySKYAfZ+zhOu/9MLqikWguznSpkWUbT2UudsO?=
 =?us-ascii?Q?83hSiALFAZm77oUO4XGgfOH8/nM+0EUFpz38DTvDuGpTsd81kJwk1XFUfRIs?=
 =?us-ascii?Q?7IOkCRNFfSezZwCw2xw38JOjXxzsklhvyYMnVBJo0SzoRvMiIN2jbFOa2TOv?=
 =?us-ascii?Q?b/LuiI0TGSQ1iA5iHFvhXEae3mZEAxYd+/dBJw+/HOvv6DSZcbxCz08hm1a3?=
 =?us-ascii?Q?THieE6D99nYN0JdCu+GsBW8a/NrD/ADlfDKN2t3vILe5MlhAI6YuwJQhFTTg?=
 =?us-ascii?Q?gvN+CyGNBo2fBhv0YqX6vyS0HgscoDpv0F4JS9Vo288ajUXq8RD2jyJEcpws?=
 =?us-ascii?Q?YUxm52vTkZvujAQu9DlkfavLZP2scoM8iWsrkvYnuy2+sar5+ZxowxI4kgg8?=
 =?us-ascii?Q?bHR2xqPZwa0pyzVh+p/oWz6SX3J/6eIrTrajNeMsiVv8K0Ym21hZT0akwH6+?=
 =?us-ascii?Q?ptOaNbOWGqD/QmElNI9ODXH9iRmPpmca3nzD5pncsfBIo0Rlk64vxN2b5qmB?=
 =?us-ascii?Q?7m5tUqpCeaIJTi/WYV1MYK895jboIXXdm74baBbgrLqHInWi1QbAphyFYXu8?=
 =?us-ascii?Q?8dV66fSLG2Lw7byP80FdFQWTs+iUirAztyFpQIc8afGGg21yQIRqbWb5v/Te?=
 =?us-ascii?Q?Qaly1cYNfKyZmB95WThw/QwPszTAocaZpWsoNoJv7Axu3+xTnEG5tCgAiAjz?=
 =?us-ascii?Q?XcjpKkaTOAIeXkuwGUiDd0fdDn17QWgRWi6jjpEOo33i5gor6Hq68wZTexnn?=
 =?us-ascii?Q?mX5ISnOJBqOPskcGA0xvjdYGuWPZVvKvbmlM/B9g9MnuHBjXckvl2EylQkn1?=
 =?us-ascii?Q?NMyMk1sjGBxG8g4FrwrDEXVY5NJi0bNnDi73tjKFpR8K3SuA1s6aFb4+mazw?=
 =?us-ascii?Q?+JyDrLHlD1lh/mNKArSCLKFDZyFuoIERPzow4+gtk3W09um38FtGCa4uoHVP?=
 =?us-ascii?Q?YmTlhQQ0CSA/hbfu3gmSqqkgCzZn2kh4AcijU/CwNL17imXQkus+zuYnsvIf?=
 =?us-ascii?Q?xz25s0U+It6OG6aWinwRCXZQ+/v2k/tU/VD/+2rvCmzYycDvynp7WZrU87YX?=
 =?us-ascii?Q?ftMmqovzb7Gl2O5z2C+BT1aiiycaHBiJAkhQD90qvxkY3LfNCUaFOxkCmRPq?=
 =?us-ascii?Q?CbY473uUx4WZtjSmzGs37b+5DGXQV9ifJjHyBvpv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0253af-8c2e-40e9-87e4-08db034cd93c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 05:34:40.2733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 83Zvlhcd+gAx81k7MfLLCV/DK8mph6Fa3wfWdpA3gADwRG0ccOa/DWRraXn/lEUfl+tJYozt/Yd3+WYrA3yqig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8150
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tor Vic,

On 24 Jan 20:40, Tor Vic wrote:
--------------------------------->8----------------------------- 
> 
> The "active" mode seems to be broken here on a Zen2 3900X running Linux 6.1.
> Frequency remains stuck at minimum which is +-500 MHz.

I've fixed this in v4.

> 
> Some queries of the new /sys devices lead to I/O error:
> 
>   # LANG=C cat /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_*
>   166
>   cat:
> /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_lowest_nonlinear_freq:
> Input/output error
>   cat: /sys/devices/system/cpu/cpufreq/policy0/amd_pstate_max_freq:
> Input/output error
> 
This issue I'm not able to reproduce. Is this issue seen with only EPP
patches also?
Could you please check if this issue still there with v4?

Thanks,
Wyes

> The "guided" mode seems to work fine with no stuck frequency, but also
> produces I/O error on some /sys files.
> 
> I haven't tested "passive".
> 
> Cheers,
> 
> Tor Vic