From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: RE: [EXT] Re: [net-next PATCH] octeontx2-af: Removed unnecessary
 debug messages.
Thread-Topic: [EXT] Re: [net-next PATCH] octeontx2-af: Removed unnecessary
 debug messages.
Thread-Index: AQHZNF7SaOrNgLzIG0SBpaC4MYgBqa62uU2AgAFjW6A=
Date:   Tue, 31 Jan 2023 07:11:10 +0000
Message-ID: <MWHPR1801MB1918AEE92F5D6FEC4D19F923D3D09@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20230130035556.694814-1-rkannoth@marvell.com>
 <Y9eUIfUkwf69ntJm@unreal>
In-Reply-To: <Y9eUIfUkwf69ntJm@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OOIGeXMxPRIhPgertSgqWbsnyg+9o1YUSHCW7h2Sz6IldDB/zYutehrXENIA?=
 =?us-ascii?Q?IA7YCqeo1FB2NT6RcGagGH74FPOQ5nsSsjwwyPxWNb4QW06Du3v2gIibs+6w?=
 =?us-ascii?Q?KeaEMd9zdZbuvT16tH0mqK1wpIkN2OQijLGOQWrq6EQpkWRkf9g5RsmzyD1k?=
 =?us-ascii?Q?ceZKuzbbaYWkOKwOjPqtyVuvuYf+CZHrBrGkWQmJmQG91AmEvrlVjd3K1JdL?=
 =?us-ascii?Q?lSG89ArWNz5YRm9jsc+4u0kxZsnAonPcZGaHsHXebnzlhxn8SpslzOo8KCJx?=
 =?us-ascii?Q?0FjN/1NkyAPHAybeDt5BYLW/KmgmiIKyVPgABM5UIBCIjQg8IpPOwVqeElcC?=
 =?us-ascii?Q?0jsCZffsIDLOIiEKEnOzUJzFj165CZhf68LwYLXWnOET0y3fARoufZMXfeDq?=
 =?us-ascii?Q?la7L86wLW+/UAsQuKrvIAXMCOYIxh9lv45tAnrdcDwALpZJ7MtdHnkDLvu9X?=
 =?us-ascii?Q?CsnWdkppVGaCt5gMJW5VAOHopuTZR1CsP7Kw9AkBCJyeSAF+dDtMQklJRSCw?=
 =?us-ascii?Q?g6t6lWjjM/nHi4dip6veVeNymeFuH7STpHwbeLHIU4mOVlhcrUZ9IB1PhaB4?=
 =?us-ascii?Q?OcE/qUxwEnzAw4G/bEMJDNncnuNbWI3tuayqYw/uUtkSC0WE9Uy/dLSqGjI9?=
 =?us-ascii?Q?qZmIrDjpLuChOxMhgEnCeW4nmRXHqEUotfM3OFDvWUPXbMCROpsFX2rZ3KWB?=
 =?us-ascii?Q?zykv9px/uk1Jh4TAyl8s6lYlK2OrYaX08jZYLSqb4EG5ER0YgGZYFuHnCM7E?=
 =?us-ascii?Q?lUoEO47TUQHB1GvP3zCc7+rSxvpuQIE2qBdWhs0xzvOPzOcoaZE6yzHTQKVF?=
 =?us-ascii?Q?3dviykMKvAffwO1iScMkS94bKOP7MjJ+gCus7Id8JWmHd/axti/HOgW9owYC?=
 =?us-ascii?Q?wo/Es7OAAF6sa2dkjGriCJYdyjlnU69aPvZrorV0LT0wvx8x8O35Tt6HLRP0?=
 =?us-ascii?Q?39HT/y70qXtLEPJMCx8a/sQFqd0fVgaNWbu5AOdhsvx8WU2y/vqjR21aBTEc?=
 =?us-ascii?Q?o8FgnT+dxiEgxxxdCP13U7uR2fc49gkt69afM0Tx6uhCobff2WxxLKP06uf5?=
 =?us-ascii?Q?787KpQ87ukxSWbce+stMrbL4Dd6ItxOgxAvYC8wvIJY+v6GJ3VggqQHcT6fS?=
 =?us-ascii?Q?Wa5mLR9JlDEtnmLcmjx2mvq49oX6+Hqnw7lIHl+27jyU9GD1PB7/uqIrq+Rt?=
 =?us-ascii?Q?lXs31aA/1NZHUccyLVDWu4Cv2WnMjZ3D2rHLY/+Q8mxsmcX65wIaoZ0dHHlr?=
 =?us-ascii?Q?Lk8hiyEK0O05KBm6Ja30CiNIJMXJ+fPUIbXaqUoZP8At4TGjhzAqJnYgE3LE?=
 =?us-ascii?Q?bXtiLhqDviyd5adSIdDHHpDI77z/I3pqoh/cwyLYJnf0bkissQ396ON90Qwl?=
 =?us-ascii?Q?zldztIshG/NoUmGDFsbTCKLsnFNfQMAOsIVRfYvRo3XQdIFPq/gdr1t3RxD5?=
 =?us-ascii?Q?RBFbT34TDh33+Qtoi8lG6UfGA55A5orbESyGoyRrQtML/+RNz6+7aMeTK31U?=
 =?us-ascii?Q?H/SalcUVW9KtLntOyfV5wA3Lj+ijQSKggUc6/gpucFdlyGDr1ODcVfj1pVSb?=
 =?us-ascii?Q?TCWa+f3zZ7myYDvLPEYhNGzbQWmq6aIA/fCv/Czr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45e919c4-0793-4bda-4273-08db035a549a
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 07:11:10.4236
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3Q4V9oGEtVP+5WVfL/9hNL9dodZMfVw/R8yd7mJO/QBBCqH2EI7nCMt1gmQDT101dDik8QuJybOi5nZcYgoONA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4186
X-Proofpoint-GUID: SEDiOkmK3kzXfg6Zt3MXmXK8UL3Gpnye
X-Proofpoint-ORIG-GUID: SEDiOkmK3kzXfg6Zt3MXmXK8UL3Gpnye
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-31_02,2023-01-30_01,2022-06-22_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

----------------------------------------------------------------------
On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote:
> From: Sunil Goutham <sgoutham@marvell.com>
>=20
> NPC exact match feature is supported only on one silicon variant,=20
> removed debug messages which print that this feature is not available=20
> on all other silicon variants.
>=20
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
>  .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12=20
> ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c=20
> b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> index f69102d20c90..ad1374a12a40 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blka=
ddr)
>  	struct rvu_hwinfo *hw =3D rvu->hw;
>  	u8 intf;
> =20
> -	if (!hwcap->npc_hash_extract) {
> -		dev_info(rvu->dev, "HW does not support secret key configuration\n");
> +	if (!hwcap->npc_hash_extract)
>  		return;
> -	}
> =20
>  	for (intf =3D 0; intf < hw->npc_intfs; intf++) {
>  		rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), @@=20
> -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr=
)
>  	struct rvu_hwinfo *hw =3D rvu->hw;
>  	u8 intf;
> =20
> -	if (!hwcap->npc_hash_extract) {
> -		dev_dbg(rvu->dev, "Field hash extract feature is not supported\n");
> +	if (!hwcap->npc_hash_extract)
>  		return;
> -	}
> =20
>  	for (intf =3D 0; intf < hw->npc_intfs; intf++) {
>  		npc_program_mkex_hash_rx(rvu, blkaddr, intf); @@ -1854,16 +1850,12=20
> @@ int rvu_npc_exact_init(struct rvu *rvu)
>  	/* Check exact match feature is supported */
>  	npc_const3 =3D rvu_read64(rvu, blkaddr, NPC_AF_CONST3);
>  	if (!(npc_const3 & BIT_ULL(62))) {
> -		dev_info(rvu->dev, "%s: No support for exact match support\n",
> -			 __func__);
>  		return 0;
>  	}

>You should remove () brackets here too.
Ratheesh ->  Sorry , I did not get you. We have more than one statement in =
this "if" loop. How can we remove brackets ?

> =20
>  	/* Check if kex profile has enabled EXACT match nibble */
>  	cfg =3D rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX));
>  	if (!(cfg & NPC_EXACT_NIBBLE_HIT)) {
> -		dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX prof=
ile\n",
> -			 __func__);
>  		return 0;
>  	}

>Same comment.
Ratheesh -> same comment.=20

> =20
> --
> 2.25.1
>=20