From:   Thomas Gleixner <tglx@linutronix.de>
To:     Shanker Donthineni <sdonthineni@nvidia.com>,
        Marc Zyngier <maz@kernel.org>, Michael Walle <michael@walle.cc>
Cc:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Hans de Goede <hdegoede@redhat.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Shanker Donthineni <sdonthineni@nvidia.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] genirq: Introduce two helper functions
In-Reply-To: <20230130005725.3517597-4-sdonthineni@nvidia.com>
References: <20230130005725.3517597-1-sdonthineni@nvidia.com>
 <20230130005725.3517597-4-sdonthineni@nvidia.com>
Date:   Tue, 31 Jan 2023 10:20:49 +0100
Message-ID: <87k01312mm.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Sun, Jan 29 2023 at 18:57, Shanker Donthineni wrote:
> Introduce helper functions irq_find_free_area() and irq_find_next_irq().
> The first function is used to locate available free space for a new IRQ,
> and the second one is used to find the next valid IRQ.
>
> These helper functions will be later modified to utilize the Maple data

So you first introduce helpers just to modify them in the next patch?

What you want to say here in this changelog is:

     genirq: Encapsulate sparse bitmap handling

     Move the open coded sparse bitmap handling into helper functions as
     a preparatory step for converting the sparse interrupt management
     to a maple tree.

     No functional change.

Hmm?

Thanks,

        tglx