Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C55AAC636CD for ; Tue, 31 Jan 2023 10:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbjAaKbG (ORCPT ); Tue, 31 Jan 2023 05:31:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230472AbjAaKbE (ORCPT ); Tue, 31 Jan 2023 05:31:04 -0500 Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C21793F2BE for ; Tue, 31 Jan 2023 02:31:03 -0800 (PST) Received: by mail-vk1-xa2f.google.com with SMTP id 22so7159972vkn.2 for ; Tue, 31 Jan 2023 02:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=biRptAnS/23/d1sfZT7OvK0Nsb2kEXEG2iefSRQIeYE=; b=N4W0VQzf/QKJ6ONvniC2q/NvKJd+XXlmKEn46E/k278t7UNFa9Vcja4Q5Uoviduf1A 62OmwHUqF876n1Ml7aNMGN6Mkfys5arnC0CMD13LwK7oOglYKD9Rj9mphMsOQb5vNxHP XFvrqQxNYijZ6oupnsOE7wlEbT2FFAIVqjev1NxAlqah8Cg2rWi4ZrEVlBMbmRC7KyWM Mgth4/XThgiKdtx4/O+6GCQdWAuVPXDmGEk7I8xGUWQRUzKTNDG+0/r4uDidaxzIb98M pHRVCdCX6jxt9gu0a37ofWJRheHTQyts/ZBrtbXSZKiEe1fugC+AfJmNIxQzIum53dvQ K/cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=biRptAnS/23/d1sfZT7OvK0Nsb2kEXEG2iefSRQIeYE=; b=KxdF6sXahGWOG1NQMkLLWSwS661z93moq95Vvrk1XwLdcq8FlrHCmUgjowYbG1DKc2 EopLdlwoQZLydU8ybQxDDxQgARoy6iKGTqx+4UpmTaayvfg7zafiJO3mvpDWlq+fmy1e Jtrk+bmrVjpd4iheVLyRU1TZBXelCfpnGyMx8z5ggeLBxiFz3xqYZ1iCeqDEK2fUdcdq BUCBwGmaz7ZIth/BxFhv3eEaYvdWaoEi0L22e4reVYMefiDQWfa0cJCfNir037yQuWvS AFe4CF75vhA4Pc8SoCCpVw0Zxe5AxGII+N+EnV4u90GVdZxZaI9AGEwW8Qv2evNgcpz4 wj3g== X-Gm-Message-State: AFqh2koejBlE/W/uUwdg2l2bvVlKdOmQ0uepQOiiPMTCTJx4fQwnntx2 Jum+spuvCB9Dm4t+Dcuay3a806r3NWUow+Wg2CgG/w== X-Google-Smtp-Source: AMrXdXtA+nQqDbRIGryG5iub+Xzha80yKCFEITt1L/ujGSq+l3Ow5201zNt6pfcrxFe3paPOA51MxPiHEIgf1d0NJ7c= X-Received: by 2002:a1f:ac0a:0:b0:3d5:911f:daed with SMTP id v10-20020a1fac0a000000b003d5911fdaedmr7024011vke.39.1675161062850; Tue, 31 Jan 2023 02:31:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Tue, 31 Jan 2023 11:30:26 +0100 Message-ID: Subject: Re: [PATCH 06/18] lib/stackdepot: annotate init and early init functions To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2023 at 9:50 PM wrote: > > From: Andrey Konovalov > > Add comments to stack_depot_early_init and stack_depot_init to explain > certain parts of their implementation. > > Also add a pr_info message to stack_depot_early_init similar to the one > in stack_depot_init. > > Also move the scale variable in stack_depot_init to the scope where it > is being used. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko ... > > +/* Allocates a hash table via kvmalloc. Can be used after boot. */ Nit: kvcalloc? (Doesn't really matter much)