Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-106-gfe3ab13a96-fm-20230124.001-gfe3ab13a
Mime-Version: 1.0
Message-Id: <9d2450ce-6ba2-49eb-9f00-bcb1b8590eeb@app.fastmail.com>
In-Reply-To: <35c0fc4ba93b11c4b8a55c2907f736a840cd12a3.1675161286.git.geert+renesas@glider.be>
References: <35c0fc4ba93b11c4b8a55c2907f736a840cd12a3.1675161286.git.geert+renesas@glider.be>
Date:   Tue, 31 Jan 2023 11:41:08 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Geert Uytterhoeven" <geert+renesas@glider.be>,
        "Masahiro Yamada" <masahiroy@kernel.org>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] compiler-intel: Remove duplicate RELOC_HIDE()
Content-Type: text/plain
Precedence: bulk

On Tue, Jan 31, 2023, at 11:37, Geert Uytterhoeven wrote:
> The RELOC_HIDE() implementation for the Intel compiler is identical to
> the generic version in <linux/compiler.h>, so the former can just be
> removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not even compile-tested.
> ---
>  include/linux/compiler-intel.h | 5 -----
>  1 file changed, 5 deletions(-)

I thought the entire file was gone already. I don't see anyone
objecting to the earlier patch

https://lore.kernel.org/all/20221016182349.49308-1-masahiroy@kernel.org/

but it never made it in. Maybe we can revive that instead?

Otherwise, your patch looks obviously correct as well.

Acked-by: Arnd Bergmann <arnd@arndb.de>