Message-ID: <192d7154-78a6-e7a0-2810-109b864bbb4f@intel.com>
Date:   Tue, 31 Jan 2023 12:07:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [Intel-wired-lan] [PATCH v2 net] ixgbe: allow to increase MTU to
 some extent with XDP enabled
Content-Language: en-US
To:     Jason Xing <kerneljasonxing@gmail.com>
CC:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <richardcochran@gmail.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
        <bpf@vger.kernel.org>, Jason Xing <kernelxing@tencent.com>
References: <20230127122018.2839-1-kerneljasonxing@gmail.com>
 <Y9fdRqHp7sVFYbr6@boxer>
 <CAL+tcoBbUKO5Y_dOjZWa4iQyK2C2O76QOLtJ+dFQgr_cpqSiyQ@mail.gmail.com>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <CAL+tcoBbUKO5Y_dOjZWa4iQyK2C2O76QOLtJ+dFQgr_cpqSiyQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzFDdHFuL2dVWXlWaXd0dmlqZTdMNjcrVXFOd2V0UHZtbEwwendhRWVON2lR?=
 =?utf-8?B?dDg3K3I0bHBFOXhJcmxkeVVOSVErUkYvVXlyZXQvVTVDNkFnV0h6VlZsMzNK?=
 =?utf-8?B?Unp2SHcvMUd1UlRtUlJmWDF2TlBONDdjOW1icmVZZzZRcHBpZ1dxamplRk5R?=
 =?utf-8?B?RFA4UXJURElUeVJscEhCUXhkd1JmR2ZxMkhCY0hmVDcxWTdwdW1JSjhXV2lR?=
 =?utf-8?B?YXpDMkU1M2QxTWxjN00zWm40ekF6ak9lNGVqYnBGOUlEQTFQbWFvbXpXK3V0?=
 =?utf-8?B?N3JweW96alJvNkxwenRnd09KR2NlZjdUQWN4KysxelhRN1JRaFNJU09NTUtK?=
 =?utf-8?B?SDVJenR0OGxOY3pkWW82Wk44L3NRNkpVd3pTZGlteXJUb090S09iVCt6bFJH?=
 =?utf-8?B?bTV1R2Vud05QeXJKOUhIQWlpV0xHNVVjMXhPdzFpNzUzUlJxZmY1ekVQTElz?=
 =?utf-8?B?SjRaNUs4K0Nib1J6MjdiNitUTEJkQjZ0dmMvS3RmRitSRnkzWmJEN3lSSTh2?=
 =?utf-8?B?MWN5dGFlQjZpRnhndEoxdmdDZmhGUm10TjE4dkhXQlJrRm9KSGdaQ3VDRTB0?=
 =?utf-8?B?cnVORC8vM1B6MXhoMlJoTjIySzlwN2ROZ0NLTlUzSk5oZkp0M3pxWE9hZnla?=
 =?utf-8?B?M3FFclhYRERGL0ZPbXZkQTNCTzd2VGd6UXNWbUxoYUJxR1BHOXhKMzVvWVhK?=
 =?utf-8?B?dUNPQUNUc2M3ZEdnNWNpVjVPUjNINi84eXg0c0lXZ1pldmZFSlc3emFibmpP?=
 =?utf-8?B?ODYrZ2NtWW12L2F5WGx4Mlp5cm9yaVVYWk9tb09JUGxMcGFXU3VwS0U1dWcz?=
 =?utf-8?B?RkRzZGdWZ2gyM2VaQ3RiRjhUZ2ZSU3lyNDJIcEEwcXlEcUMvbGhCK056S1M1?=
 =?utf-8?B?M1laT01pRjNxM0JiV2lCL3lQV0pFVGhJMWVTazViSW5BSUFrYlhGazhhUWJo?=
 =?utf-8?B?UVM1Q2FKS3p1UFZPVmNuUFV2OUNUM3dEL0ZQYldiU3hlRGxqRVJhME9ZZU9L?=
 =?utf-8?B?NkpNSldKOVpkbXgrTnBKNk8xSkpYblFVTlF6S2owd2NEb01QcnF5Q0IvUHVv?=
 =?utf-8?B?Rm0vQ2pmVEN3bVc4dGUrYXIzVHlXeVJjakhLQ1ZsVitrdUR4UnJpQXc0Z04v?=
 =?utf-8?B?aVBCM3JraXlva1gxRm0rSUMwaFoyc2xCcEhTNjM5OW0rTEpCejdFK05uWGs3?=
 =?utf-8?B?aHhyZGFzdm1uMEFtSFdZeUdBTm1NVkhrV2FoQWZUWWFkdjA2eTFVeCsxTHla?=
 =?utf-8?B?d0FFRkxkL3ZrNVhwRUxlSFhiVTdsNUFoU29vT3B6QnQ5YTdqV2w1UlkxNTN4?=
 =?utf-8?B?a3ErQWpUMWpBYy9mSnpoZ2hFN0NCNlVHZGJqWWZOQ0h0QktBYWk4QjlZOC9n?=
 =?utf-8?B?M0VMUlZvZDFTTlNiWmdNVm4vWGxpdmVrV3JsNEtzZGRQU3JZU1VFTjUwVjQy?=
 =?utf-8?B?MHo4YXpGR09pekl5dUlIMXc3RnNKWitVT2N1bGZpV1BYTWkvQTRTcHNiQ3lI?=
 =?utf-8?B?Y2RSQW5zN3IrZitadVlLV0Z3ZUMvSjZkNjZTTkliMzlEOFg1akNudEE3b3p1?=
 =?utf-8?B?QTZyMFlqc1RUODR4dWZsUzNoUlp0bTlFK3JKT29KRURYaTlxcUxMeGdJbk1t?=
 =?utf-8?B?ZlNmSkJ1b0hQbnBmRDF4V29UdDJscmFYT1o0dytkYWFQOS9lVTB6N2FWVHhM?=
 =?utf-8?B?bDM4OFZoWnd4MEg1ajhrUTZMekpWTm5idCtXN09DbFhnRFhPTUhydGZvWms4?=
 =?utf-8?B?TEt6OVZwb0RpMVBuR20zeWpzVi9CQ3RieEo4WlpGSWVPa2h2ZWIwYnVWZVM4?=
 =?utf-8?B?b0R1U3NxT1lRT2RKSG5YMFR0T2RrVVFNUWFYT2VUbFZmSnNBMU1CWldySmRB?=
 =?utf-8?B?QVJ3YkJGNlpETEprTUVmRENSSXhxeGRzd1d5SC91U1cwSkZTNkRrRWxxTXBl?=
 =?utf-8?B?VzVSa1N2R1Fxa2NIcDJmSEZwQUltN2lTOGwyNVVnTGMwTldDR1VaOE92dEN2?=
 =?utf-8?B?ZE5hUmlocHJnemN1SnRlOUdMV0VaMkhFRjdJcUhWVlNoRmlSZ1I3alFFTUhX?=
 =?utf-8?B?YU4zQVhYbFhwWTlFUSsvTTJPNXBKKzJWUVlPdEc3RFpPRlUybDZNdElFQ1po?=
 =?utf-8?B?MHpKSjU5akVnQ2gvZU5QWkVNQTBWNFVtWG1CZGtkUm5PTld0ZVkwTFloSk5Y?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 393f53da-68cc-4056-0bf1-08db037b5f98
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 11:07:42.5998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KTX8AAKBAtAjC72pz4tY9ktYsbvpxkYqCfWuyzRS4ACLKOIehy1U9ABmHmVMP3PWxmUX53qR5wFxWSridqojmyLlOXYKX1vyc8H5YlkWcvw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8121
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jason Xing <kerneljasonxing@gmail.com>
Date: Tue, 31 Jan 2023 11:00:05 +0800

> On Mon, Jan 30, 2023 at 11:09 PM Maciej Fijalkowski
> <maciej.fijalkowski@intel.com> wrote:
>>
>> On Fri, Jan 27, 2023 at 08:20:18PM +0800, Jason Xing wrote:
>>> From: Jason Xing <kernelxing@tencent.com>
>>>
>>> I encountered one case where I cannot increase the MTU size directly
>>> from 1500 to 2000 with XDP enabled if the server is equipped with
>>> IXGBE card, which happened on thousands of servers in production
>>> environment.
>>
> 
>> You said in this thread that you've done several tests - what were they?
> 
> Tests against XDP are running on the server side when MTU varies from
> 1500 to 3050 (not including ETH_HLEN, ETH_FCS_LEN and VLAN_HLEN) for a

BTW, if ixgbe allows you to set MTU of 3050, it needs to be fixed. Intel
drivers at some point didn't include the second VLAN tag into account,
thus it was possible to trigger issues on Q-in-Q setups. AICS, not all
of them were fixed.

> few days.
> I choose the iperf tool to test the maximum throughput and observe the
> behavior when the machines are under greater pressure. Also, I use
> netperf to send different size packets to the server side with
> different modes (TCP_RR/_STREAM) applied.
[...]

Thanks,
Olek