Date:   Tue, 31 Jan 2023 12:14:53 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Song Liu <song@kernel.org>
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@lst.de, kernel-team@meta.com,
        Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v4] module: replace module_layout with module_memory
Message-ID: <Y9j4LYijtFZzkKHa@hirez.programming.kicks-ass.net>
References: <20230130182109.3571524-1-song@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230130182109.3571524-1-song@kernel.org>
Precedence: bulk

On Mon, Jan 30, 2023 at 10:21:09AM -0800, Song Liu wrote:
> +#define for_each_mod_mem_type(type)	\
> +	for ((type) = MOD_TEXT;	\
> +	     (type) < MOD_MEM_NUM_TYPES; (type)++)
>  
> +#define for_core_mod_mem_type(type)		\
> +	for ((type) = MOD_TEXT;		\
> +	     (type) < MOD_INIT_TEXT; (type)++)
> +
> +#define for_init_mod_mem_type(type)		\
> +	for ((type) = MOD_INIT_TEXT;		\
> +	     (type) < MOD_MEM_NUM_TYPES; (type)++)

#define __for_each_mod_mem_types(type, _from, _to)	\
	for (enum mod_mem_type type = _from; type <= _to; type++;)

also to be used in the previously suggested within_module_mem_types()
function.

also note the C99 variable in for-loop decl thing

#define for_code_mod_mem_type(type)			\
	__for_each_mod_mem_types(type, MOD_TEXT, MOD_RO_AFTER_INIT)

#define for_code_mod_mem_type(type)			\
	__for_each_mod_mem_types(type, MOD_INIT_TEXT, MOD_INIT_RODATA)