Date:   Tue, 31 Jan 2023 12:26:23 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Song Liu <song@kernel.org>
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@lst.de, kernel-team@meta.com,
        Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v4] module: replace module_layout with module_memory
Message-ID: <Y9j63zD4P2LtIbyE@hirez.programming.kicks-ass.net>
References: <20230130182109.3571524-1-song@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230130182109.3571524-1-song@kernel.org>
Precedence: bulk

On Mon, Jan 30, 2023 at 10:21:09AM -0800, Song Liu wrote:
> +	if (type == MOD_DATA || type == MOD_RODATA ||
> +	    type == MOD_RO_AFTER_INIT) {

> +static bool mod_mem_use_vmalloc(enum mod_mem_type type)
> +{
> +	return type == MOD_DATA || type == MOD_RODATA || type == MOD_RO_AFTER_INIT;
> +}

perhaps a mod_mem_type_is_data() helper?