IronPort-SDR: xwpLLCtyP8DU4lS8fzsW6TK5HB5YbqPz7BX25zZUlOsM7dveNKCfRwEubWDYNCCN5RpEsvwzvK
 YWiK6wGpS35YbfwhTS9WjYlguahRnsM+bh3pTjOSRHn31qBehsQBxLzqu5gaZHRGurUH14HM1O
 iQnx73oXNEOHksyztEak8HR3sGCJNwu7gYOJc+OPzucOxeCpEkD/O3i1uKoUdOss6sZ+wdgB9f
 VpNL7C2D46WtRLyL6l3iRfHIca/GSWOC9ZQ3cQKBHDSPBXuIn6MAlJ5I8DG2hkxZ93CIQD0/eY
 ZMQ=
IronPort-SDR: ySvtv73CPo95aSqsx+kfdzoNBdiQrdG8yW30V6a/O67s+FY326fFbgzTVnmSsY+PcrKz1gMgNY
 hrXj6LL8288JpZloXOZZc00/OaDlTSlrbVM0Rl/F1/b9ppc7+plRmCZx6x/IOe7uo6/LFjskiL
 DRiehE1CbUVAbf5Q1Hpq9v0Zhj6NNSO50ep23POX8wL+xvClksKntzi29fbZK24fm4JT77yUQ2
 egxqTDaJakmc5xt8UnlcWiM1mL9kDzzDJfLnI/Et2xxS2maQC4+d8WheJ5DYEKVqaTMBCVPqvn
 waE=
WDCIronportException: Internal
Message-ID: <d8d117bf-4ab1-3473-85e2-00f1b1a85cba@opensource.wdc.com>
Date:   Tue, 31 Jan 2023 20:26:55 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] libata: clean up some inconsistent indenting
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, s.shtylyov@omp.ru
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20230131085431.30549-1-jiapeng.chong@linux.alibaba.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230131085431.30549-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/31/23 17:54, Jiapeng Chong wrote:
> No functional modification involved.
> 
> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/ata/pata_serverworks.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
> index c0bc4af0d196..c6bd9e95d4e8 100644
> --- a/drivers/ata/pata_serverworks.c
> +++ b/drivers/ata/pata_serverworks.c
> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>  
> -		 /* If the returned btr is the newer revision then
> -		    select the right info block */
> -		 if (rc == 3)
> -		 	ppi[0] = &info[3];
> +		/* If the returned btr is the newer revision then select the right info block */

Very long line. Please make that a proper multi-line comment.
And the patch title should be:

ata: pata_serverworks: clean up indentation

> +		if (rc == 3)
> +			ppi[0] = &info[3];
>  
>  		/* Is this the 3rd channel CSB6 IDE ? */
>  		if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)

-- 
Damien Le Moal
Western Digital Research