Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65D6C636CC for ; Tue, 31 Jan 2023 11:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbjAaLhB (ORCPT ); Tue, 31 Jan 2023 06:37:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjAaLg6 (ORCPT ); Tue, 31 Jan 2023 06:36:58 -0500 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1A7834014 for ; Tue, 31 Jan 2023 03:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1675165017; x=1706701017; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gA2pIWlMZlIKc4EJKQFR0wQk92xrlZIShxykKJ4in54=; b=kzBKBGcHu57LOfB6j7aeNbHVSdR3QC1HCwGJ5JC5XTcElsM5n0h1yerR 4X3l4Gn0oWodlP/T5To8D1y/USeUzaEelpyhEzH0YL4jPl9nSBh7E0EoH L5ks/WCItZKWTu8Kxu0DbuxkZj5F0tenvqtfq4OpRtc36e+0CwwOtxxK1 GhXrJqh9BOOhlYICN+ZzFBgiYWlMmPIYT8XDcV0nPQuqT2/jzjo8RCGye Z6tfjVITljV6j1nCmJYGidhPovXU86umZ3/Uqjqz3OzVbCnH+0dwBpywh 1QasATF1pcP2D94VvkabSoplCqCiqqlEOzMssRzTrhhhRbFM+YwVNdt9F A==; X-IronPort-AV: E=Sophos;i="5.97,261,1669046400"; d="scan'208";a="326459826" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 31 Jan 2023 19:36:57 +0800 IronPort-SDR: kKZaE/OgHxH8fQrJ5NyWiIm08qAgKuF4zOFxuqGVmoGxx9C7i5kHwu1zqvKif7c6b+uqKCNQHw z/4eyzWa4rIbPurzvuqBI48lewYMPfobB8RfBYJPzFW+/pwIJQ+6KlBT7FlyR84ksMWW9kfImY AS24rZo290NWbll1y5qdg7mEV09V/u9AOIVVUIVRFy2FIA1IAYht6nuzVdgUDqByfVxIgHT2Vj /Sp1CQya7aYcp8wLD6lXFQBs/9SBo4QoEkkR/eCKkRfI2MSJLItqvsnPYSBwwUq/fi9wvGdOpC 7Ys= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 Jan 2023 02:48:37 -0800 IronPort-SDR: 9es0KjrPW9LtQtHJo6nrSv5FPn7reIw3EaBMTgbZ9LWKpwSKfm8AxB4sRonsEfdWy24l4W+Z1z S5rcotTrlOu8Mt3nvsbjj4+SatUgDAH330XXUVreWLK70SAVxY8QjM4xQ7CRGFR5JQ7S+8qlHb EGYD7VxN/Y1guKZrhf6lwHD+jRO4IbCHqNEnf1+Lc+xjC6MSM62Wo6pIW89AAAbLHIDYsrIfF7 tn1jgx1OwSWpTCPSepW76epf6d6AvTbkaKpYABX/nKHRXNeBwgRPLuRSRtXkPtgkFwozm/j5bd x2w= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 Jan 2023 03:36:57 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4P5jgs0b8Lz1RwqL for ; Tue, 31 Jan 2023 03:36:57 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1675165016; x=1677757017; bh=gA2pIWlMZlIKc4EJKQFR0wQk92xrlZIShxy kKJ4in54=; b=hIWdUmu6yk9coI0UhFdgGB5/VD8gQosnLTC00nLyuZ8C7+yemTs /HNf+k2lJxLgAQmjsXrvJ5NeyTDbcgPJrQg0B1NyyGzgyxKwZ18Cp6V1+9/Q2KHC qc8OZTn6m2T6wIYynC52aWw3gNq3IzSRKHQfpyDCOAdSyo4oHSC+mUG+LI9s3+Z6 5n3rhKZT2AsK8uwWDTfFDhYodIvfOOS6/khgwMgmaSK76jwY5XbYtf1krcZEYjUB ZhNobySuQnW+r6N9RMZRzIDtVsy8dNquz6NTACu5JEkwEn25dKk3FnvAeaIaQ8xo mqD4PeLqtUv6j32jk1EkOThbFqvANbIb6JQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JLI43xBOmr26 for ; Tue, 31 Jan 2023 03:36:56 -0800 (PST) Received: from [10.225.163.70] (unknown [10.225.163.70]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4P5jgq0bmTz1RvLy; Tue, 31 Jan 2023 03:36:54 -0800 (PST) Message-ID: <1569ffb1-b23c-3f8c-6467-102f51426850@opensource.wdc.com> Date: Tue, 31 Jan 2023 20:36:53 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport Content-Language: en-US To: Ondrej Zary Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230130211050.16753-2-linux@zary.sk> <202301311124.23302.linux@zary.sk> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <202301311124.23302.linux@zary.sk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/23 19:24, Ondrej Zary wrote: > On Tuesday 31 January 2023, Damien Le Moal wrote: >> On 1/31/23 06:10, Ondrej Zary wrote: >>> diff --git a/drivers/Makefile b/drivers/Makefile >>> index f1365608bc8c..de8aa561c95c 100644 >>> --- a/drivers/Makefile >>> +++ b/drivers/Makefile >>> @@ -98,7 +98,7 @@ obj-$(CONFIG_DIO) += dio/ >>> obj-$(CONFIG_SBUS) += sbus/ >>> obj-$(CONFIG_ZORRO) += zorro/ >>> obj-$(CONFIG_ATA_OVER_ETH) += block/aoe/ >>> -obj-y += block/paride/ >>> +obj-$(CONFIG_PATA_PARPORT) += ata/pata_parport/ >> >> It would be better to have this in drivers/ata/Makefile, not here, so that doing >> something like: >> >> make -j64 M=drivers/ata W=1 >> or >> make -j64 M=drivers/ata C=1 >> >> actually also checks the parport protocol modules too. >> >> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile >> index 23588738cff0..2f85812e16ef 100644 >> --- a/drivers/ata/Makefile >> +++ b/drivers/ata/Makefile >> @@ -114,6 +114,7 @@ obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o >> >> obj-$(CONFIG_PATA_PXA) += pata_pxa.o >> >> +obj-$(CONFIG_PATA_PARPORT) += pata_parport/ >> obj-$(CONFIG_PATA_PARPORT) += pata_parport.o >> >> And then we could also have drivers/ata/pata_parport.c moved under >> drivers/ata/pata_parport/ to tidy things up. >> >> If you agree, I can fix that up, that is easy to do. > > OK, thank you. All queued now. Thanks ! -- Damien Le Moal Western Digital Research