Message-ID: <714b8b17-4936-08c9-767f-fb6292a39f72@marcan.st>
Date:   Tue, 31 Jan 2023 20:41:56 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] soc: apple: rtkit: Add a private pointer to
 apple_rtkit_shmem
Content-Language: en-US
To:     Asahi Lina <lina@asahilina.net>, Sven Peter <sven@svenpeter.dev>
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230121074253.9774-1-lina@asahilina.net>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20230121074253.9774-1-lina@asahilina.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/01/2023 16.42, Asahi Lina wrote:
> This allows downstream consumers to keep track of private data for shmem
> mappings. In particular, the Rust abstraction will use this to safely
> drop data associated with a mapping when it is unmapped.
> 
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> ---
>  include/linux/soc/apple/rtkit.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/soc/apple/rtkit.h b/include/linux/soc/apple/rtkit.h
> index 62bfa37b5adb..1a9888a1797a 100644
> --- a/include/linux/soc/apple/rtkit.h
> +++ b/include/linux/soc/apple/rtkit.h
> @@ -22,6 +22,7 @@
>   * @size:      Size of the shared memory buffer.
>   * @iova:      Device VA of shared memory buffer.
>   * @is_mapped: Shared memory buffer is managed by the co-processor.
> + * @private:   Private data pointer for the parent driver.
>   */
>  
>  struct apple_rtkit_shmem {
> @@ -30,6 +31,7 @@ struct apple_rtkit_shmem {
>  	size_t size;
>  	dma_addr_t iova;
>  	bool is_mapped;
> +	void *private;
>  };
>  
>  /*

Thanks, applied to asahi-soc/soc!

- Hector