Message-ID: <711dc967-b4cf-807b-6c74-5c9d914ab619@linux.vnet.ibm.com>
Date:   Tue, 31 Jan 2023 17:39:11 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC PATCH] hrtimer: interleave timers for improved single thread
 performance at low utilization
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     tglx@linutronix.de, peterz@infradead.org, arjan@linux.intel.com,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        svaidy@linux.ibm.com, linux-kernel@vger.kernel.org,
        bigeasy@linutronix.de
References: <5ae3cb09-8c9a-11e8-75a7-cc774d9bc283@linux.vnet.ibm.com>
 <Y9jvWCGGICsKGPFt@gmail.com>
From:   shrikanth hegde <sshegde@linux.vnet.ibm.com>
In-Reply-To: <Y9jvWCGGICsKGPFt@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/31/23 4:07 PM, Ingo Molnar wrote:
> 
> * shrikanth hegde <sshegde@linux.vnet.ibm.com> wrote:
> 
>> ---
>>  kernel/time/hrtimer.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
>> index 3ae661ab6260..d160f49f0cce 100644
>> --- a/kernel/time/hrtimer.c
>> +++ b/kernel/time/hrtimer.c
>> @@ -1055,6 +1055,17 @@ u64 hrtimer_forward(struct hrtimer *timer, ktime_t now, ktime_t interval)
>>
>>  		orun = ktime_divns(delta, incr);
>>  		hrtimer_add_expires_ns(timer, incr * orun);
>> +		/*
>> +		 * Avoid timer round-off, so that all cfs bandwidth timers
>> +		 * don't start at the same time
>> +		 */
>> +		if (incr >= 100000000ULL) {
>> +			s64 interleave = 0;
>> +			interleave = ktime_sub_ns(delta,  incr * orun);
>> +			interleave = interleave - (ktime_to_ns(delta) % (incr/10));
>> +			if (interleave > 0)
>> +				hrtimer_add_expires_ns(timer, interleave);
>> +		}
> 
> Any reason why you did this in the hrtimer code, instead of the 
> (sched_cfs_period_timer?) hrtimer handler itself?
> 
> Thanks,
> 
> 	Ingo


Yes. Thanks for making me think in that way.                                       
This can be done in start_cfs_bandwidth by setting an initial expiry value.     
Tried that change. it works in interleaving the timers.                         
                                                                                
Will do bit more testing and send out the patch.