Subject: Re: [PATCH] libata: clean up some inconsistent indenting
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20230131085431.30549-1-jiapeng.chong@linux.alibaba.com>
 <d8d117bf-4ab1-3473-85e2-00f1b1a85cba@opensource.wdc.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <d5a59ca8-1b17-9cf2-80d0-3e267e558fd5@omp.ru>
Date:   Tue, 31 Jan 2023 15:33:41 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <d8d117bf-4ab1-3473-85e2-00f1b1a85cba@opensource.wdc.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 1/31/2023 10:39:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/31/23 2:26 PM, Damien Le Moal wrote:
[...]
>> No functional modification involved.
>>
>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>>  drivers/ata/pata_serverworks.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>> index c0bc4af0d196..c6bd9e95d4e8 100644
>> --- a/drivers/ata/pata_serverworks.c
>> +++ b/drivers/ata/pata_serverworks.c
>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>>  		 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>  
>> -		 /* If the returned btr is the newer revision then
>> -		    select the right info block */
>> -		 if (rc == 3)
>> -		 	ppi[0] = &info[3];
>> +		/* If the returned btr is the newer revision then select the right info block */
> 
> Very long line. Please make that a proper multi-line comment.

   Perhaps the material of a separate patch?

> And the patch title should be:
> 
> ata: pata_serverworks: clean up indentation

   Yes!

[...]

MBR, Sergey