Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <Y9kJfPqtd98wIQ6r@gofer.mess.org>
Date:   Tue, 31 Jan 2023 17:00:59 +0400
Cc:     Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <34CD7297-AC0A-404D-B90C-D00FA861A43E@gmail.com>
References: <20230128034117.3983105-1-christianshewitt@gmail.com>
 <6e953652-4a24-6f3c-74e7-07c25fa1c6c1@linaro.org>
 <Y9YwbiJz9vOBejdL@gofer.mess.org> <20230130213020.GA3541260-robh@kernel.org>
 <Y9kJfPqtd98wIQ6r@gofer.mess.org>
To:     Sean Young <sean@mess.org>
Precedence: bulk


> On 31 Jan 2023, at 4:28 pm, Sean Young <sean@mess.org> wrote:
>=20
> On Mon, Jan 30, 2023 at 03:30:20PM -0600, Rob Herring wrote:
>> On Sun, Jan 29, 2023 at 08:38:06AM +0000, Sean Young wrote:
>>> On Sat, Jan 28, 2023 at 11:11:32AM +0100, Krzysztof Kozlowski wrote:
>>>> On 28/01/2023 04:41, Christian Hewitt wrote:
>>>>> Add a keymap and bindings for the simple IR (NEC) remote used with
>>>>> the Beelink Mini MXIII Android STB device.
>>>>>=20
>>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>>> ---
>>>>> .../devicetree/bindings/media/rc.yaml         |  1 +
>>>>> drivers/media/rc/keymaps/Makefile             |  1 +
>>>>> drivers/media/rc/keymaps/rc-beelink-mxiii.c   | 54 =
+++++++++++++++++++
>>>>> include/media/rc-map.h                        |  1 +
>>>>> 4 files changed, 57 insertions(+)
>>>>> create mode 100644 drivers/media/rc/keymaps/rc-beelink-mxiii.c
>>>>>=20
>>>>> diff --git a/Documentation/devicetree/bindings/media/rc.yaml =
b/Documentation/devicetree/bindings/media/rc.yaml
>>>>> index 266f1d5cae51..f390a5d2c82d 100644
>>>>> --- a/Documentation/devicetree/bindings/media/rc.yaml
>>>>> +++ b/Documentation/devicetree/bindings/media/rc.yaml
>>>>> @@ -39,6 +39,7 @@ properties:
>>>>>       - rc-avertv-303
>>>>>       - rc-azurewave-ad-tu700
>>>>>       - rc-beelink-gs1
>>>>> +      - rc-beelink-mxiii
>>>>=20
>>>> Bindings are separate patches. Didn't you get such feedback =
already?
>>>=20
>>> The only change for new keymaps is an added entry to the rc-map-name =
enum.
>>> In the past, new keymaps have been accepted with that single line in =
the
>>> same commit.
>>=20
>> It's been a checkpatch.pl warning since 2018. The separation is so =
that=20
>> commit messages in the DT only repo[1] make sense.
>=20
> Ok, makes sense.=20

I will resend v2 series(s) with the bindings separated. Are there any =
other
issues to address?

Christian=