Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541F6C636CC for ; Tue, 31 Jan 2023 13:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbjAaNOP (ORCPT ); Tue, 31 Jan 2023 08:14:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjAaNOH (ORCPT ); Tue, 31 Jan 2023 08:14:07 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B57F510C9 for ; Tue, 31 Jan 2023 05:13:56 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id x4so18005857ybp.1 for ; Tue, 31 Jan 2023 05:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lebX9VzQP7VMYHLa2vyK4hrBtzDqJ9eFCBgK4dZHGqY=; b=qXtrFvc8NPvibTzkOdKNUNcSgLQUKhwmE6ALIFFlhhema+9UDs2/xEAIp+1VFL2AAa 9YdIL9SgKkLhDEhuwRUiuvwE+TJRxMZaSHitbLSVMLJWtVAtYkK0GK6tJyPqTuRp+uQL z9Swhwf9izFHI+zJzgyEejUwavw8wqvwJqCFL7fTGGGc8rUk6bd8vUrsAR80S6dFW0CU hZiVxhUNlbWJv7m3ZE4fyFtpkBPjAJ3YI9uNsWLMWDjXerT9A5FLOXeafa1i88ACzgEk ucAdfE/0nfU4LAz+zOTnAF/Jz8srUae8pvFzBqYWFGMrKyNnJMDbovdndrXlESHtXAa3 /m+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lebX9VzQP7VMYHLa2vyK4hrBtzDqJ9eFCBgK4dZHGqY=; b=1d/QmN85uU+WOeQnPtmD9wMqGTdc35BpHx7MSnL3+5PkjF8dbVjOKg0CgC8uHuGxu+ O1TJA089qdzF22d7y+Ul5PyZ5kiZguBAzMhsogBR13LML6anQLnKAzTD1gKZuY8jMirw gRIC7t3EvbGRRpww+O7fmn9g1IMGkQg+E4uWD012n/mBpPCweCsjshwb/W71al0VJjAZ ZDuQeekTnv7nkl08gRnML/GBYSD3wGMbyhyQ6WSyFQFUxtfsfg1WyxwQKoLavidOVvxb rlRB7wJ2DEjW7HjVl5cD0LHc706EHDkG3UYH9bp5+mn1HoTRLdmT/93obTWLEcTbqARJ XWtw== X-Gm-Message-State: AO0yUKUgPy+RFxSAOan8OjYqImE7/+Hy1mzpAKtynv92MYvSv7kds26Y KJXjT24JaxltxAZCaxkWiGFDLuufxQ/jo2Z0bdoUIg== X-Google-Smtp-Source: AK7set/ssVUH1Rz89sAOJnKBoqT7NZMWXa8/qUnWnQSWqihB5+j26vSuiStV4rczYgZIb+D5YQtZAm1c0IjM0yuMuo4= X-Received: by 2002:a25:2fce:0:b0:83e:bd63:6dd7 with SMTP id v197-20020a252fce000000b0083ebd636dd7mr45490ybv.24.1675170835979; Tue, 31 Jan 2023 05:13:55 -0800 (PST) MIME-Version: 1.0 References: <20221220005529.34744-1-hal.feng@starfivetech.com> In-Reply-To: <20221220005529.34744-1-hal.feng@starfivetech.com> From: Linus Walleij Date: Tue, 31 Jan 2023 14:13:44 +0100 Message-ID: Subject: Re: [PATCH v3 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC To: Hal Feng Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Jianlong Huang , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 1:55 AM Hal Feng wrote: > This patch series adds basic pinctrl support for StarFive JH7110 SoC. > You can simply get or review the patches at the link [1]. > > [1]: https://github.com/hal-feng/linux/commits/visionfive2-minimal > > Changes since v2: > - Rebased on tag v6.1. Overall this looks OK, the DT bindings does not have any review from the DT people but I think they had enough time to do that and were properly CC:ed so not your fault. However when I try to apply this to the pinctrl tree it fails, for example it seems to depend on an entry in MAINTAINERS which isn't upstream. Can you please rebase the patches that are supposed to be applied to the pinctrl tree (for example normally not patch 1, the DTS patch) on my "devel" branch: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel If you resend this quickly I can apply it pronto. Yours, Linus Walleij