From:   "Sahin, Okan" <Okan.Sahin@analog.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        William Breathitt Gray <william.gray@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: RE: [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support
Thread-Topic: [PATCH v3 3/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support
Thread-Index: AQHZKwfLM9q3yL8ciUSLt6aTy9zYOq6j1SEAgBRcQ/CAACJtYIAANL4AgAAM2mA=
Date:   Tue, 31 Jan 2023 13:23:33 +0000
Message-ID: <BY5PR03MB5153C18E65B954E9FEFD96B1E7D09@BY5PR03MB5153.namprd03.prod.outlook.com>
References: <20230118063822.14521-1-okan.sahin@analog.com>
 <20230118063822.14521-4-okan.sahin@analog.com>
 <Y8erlpofdk24vwCC@smile.fi.intel.com>
 <MN2PR03MB5168EC97926AB33D4D806FCCE7D09@MN2PR03MB5168.namprd03.prod.outlook.com>
 <MN2PR03MB516865804044A798AEB5B6C0E7D09@MN2PR03MB5168.namprd03.prod.outlook.com>
 <Y9kJEsjkG8h79tcR@smile.fi.intel.com>
In-Reply-To: <Y9kJEsjkG8h79tcR@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tybOQNCf/jSB8XatZrA2ZE+6R0AtStgZHI63PFmv+f3+z83ykCOgH4V85kvF?=
 =?us-ascii?Q?UifvmYrQeYOV4U8h5CTHVIuZBjZD6pkWqDxEynUDjQy/OKdl5rpPJC8yAdYm?=
 =?us-ascii?Q?LSd3CHJxCuOGv40KWuhU9RUHajJ1Vu9XRClK5t1athL3xuUNgRGmAofsAvjP?=
 =?us-ascii?Q?FM+bEYoxxDAoc2lKzg3L3z27eO096wXcvgqTna6EUuL39jdUGEOus73F9iLU?=
 =?us-ascii?Q?8YVac2jUl4TcOA09MfvtjQBIpdD+ajqfDffj25ZDVIW+fdPyujnStaS9HL89?=
 =?us-ascii?Q?wuXf9RTje1i+gdwVMa82UwBssHwWUHYC8Yx0crppM6WZERT4/d2+r0MB7G+7?=
 =?us-ascii?Q?qb2Lqx6X0VZOUgvMsVzUUnmdmlpJ6KxVgghNDXx2d3M5prAf0homMqzWiWxV?=
 =?us-ascii?Q?QeZUzQm6QPBIubEn+zLh+23iLJdzahaMGR7liA+yZWvf3Au+D0vokW5jFu34?=
 =?us-ascii?Q?RLRi6XMKeaTZk78cL1gXqvWn79/SeXe1mqfMc1qFb0nKfkNn9dIWHe/7bFwZ?=
 =?us-ascii?Q?WpfT7NdbAzADiGWFppQ5uWIfy5qlpds8LBYoFKNdxRDIl5xKGTH9bgqW5kJM?=
 =?us-ascii?Q?ckVmvBQ0WuKlu42i15ha9kN1GUenuRgL8XAbjLZWb20veUHtLH/AO2kWi0s/?=
 =?us-ascii?Q?CX79RwrO7gJSjyYv5bWYrzyeo8fFk5hw1zBt0ExjP+1nAQq45/Tqtt9qhLIk?=
 =?us-ascii?Q?2dLFt79Xo7oYENvgo3f7tcIeNmcHq75zoL5/tOsTOQltBmhV5zOWNC5DaZJK?=
 =?us-ascii?Q?jZgRHhr8/mBX2qbMrfH2TFP/CjTfdiNxRRE1aF6Z5wOMLTOzPMI6gUV7n64z?=
 =?us-ascii?Q?NcqbukMmWVLSIf06JPWBzEvI9sKXMJj0R8zoASpygWHNp0SPUdWVlU5wTYvu?=
 =?us-ascii?Q?EMV+Ued28Ik5xdYXtJDHRq5zWkXWEtyMF8Vc7aMKVLYuDQ45PLfPw0LiI3sF?=
 =?us-ascii?Q?A2zmZOiD8k05y3XqhpHB+1PbtMmyL8ScWnybz/o9tR/qPaIrjYPRdSaghsRR?=
 =?us-ascii?Q?XUpg4s04XgscfyjJfLA88PjDoNR0DlLE+kQoS0ksXoZCWh8jKrirlK6fV4YT?=
 =?us-ascii?Q?VgwqQFZuHzc8h744Cap7fm1lBBMrgtL61vd5jTD7b+69p36w+F3zTF8rCVkB?=
 =?us-ascii?Q?5SF2QL0iN5SKXrxAiwsi4uOzsBXM1/EmVeebb5rX/T4K0za1h+Tgixb90Loc?=
 =?us-ascii?Q?DlS44T3DzP5vMR2AMw+TET6jI4jGfyzEjErCZPbaFJJBymi85/grM/MBFGD5?=
 =?us-ascii?Q?ltZCI2BrjCG5Th7PqSXpfQCNnzhV4o6+ISMs1Yqyt91jjjFUPF1zKjidKIt3?=
 =?us-ascii?Q?OKABSG255lMHKbI59ytIXogCqe4HNMAPG3JdCjpu7dJwNmKy2gukrzc/2b3O?=
 =?us-ascii?Q?i7JqstisxHEFqN2MkOmr1Ej650zwn4AHHX5Ks/bmBXsyKssqvpNVAYeLHATm?=
 =?us-ascii?Q?S+ygVC7v745q3/lamybEZdpMpqwuAR7IWAZ6iAH9T6Lp93cN9+YI56gyi6Ss?=
 =?us-ascii?Q?WqOVuQmixzBC6rHa77GLF7oDjkfjxLzrx0+C8C/4uNmxrzXTfy4JLAtuxR0X?=
 =?us-ascii?Q?pEEY5VhtfpUKEfVf1HHFJ58O5+Gpzjvy54DoN6Jm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR03MB5153.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1a225ba-ff5f-42e4-00da-08db038e5a2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 13:23:33.5555
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NCi8EGbZI38wjd+cFO3werY54DlMWLWfITM1el6cPbfl6sRYmOEnZlu5hyAD6yF2n800azdKoy9kKI0ZGGfLlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5342
X-Proofpoint-GUID: hTykkw0F1SzqTXH5idK_Hdwvo6AwTpgR
X-Proofpoint-ORIG-GUID: hTykkw0F1SzqTXH5idK_Hdwvo6AwTpgR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0
 impostorscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301310119
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Jan 2022 3:27 PM
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

>On Tue, Jan 31, 2023 at 09:27:48AM +0000, Sahin, Okan wrote:
>
>First of all, please do avoid top-posting.
>
>> Sorry for second question. I do not want to bother you, but I realized
>> that I need to be sure about driver_data before sending new patch. You
>> said that you need to use pointers directly for driver_data then I
>> fixed that part in mfd, but I do not need or  use driver_data in
>> regulator since chip_id comes from mfd device so I think using like
>> below should be enough for my implementation.
>>
>> static const struct platform_device_id max77541_regulator_platform_id[] =
=3D {
>> 	{ "max77540-regulator", },
>> 	{ "max77541-regulator", },
>> 	{  /* sentinel */  }
>> };
>> MODULE_DEVICE_TABLE(platform, max77541_regulator_platform_id);
>>
>> static const struct of_device_id max77541_regulator_of_id[] =3D {
>> 	{ .compatible =3D "adi,max77540-regulator", },
>> 	{ .compatible =3D "adi,max77541-regulator", },
>> 	{ /* sentinel */  }
>> };
>> MODULE_DEVICE_TABLE(of, max77541_regulator_of_id);
>>
>> What do you think?
>
>If you have got all necessary data from the upper layer, why do you need t=
o have
>an ID table here? I'm not sure I understand how this OF ID table works in =
this
>case.
I added it since there is regulator node in device tree. With the help of d=
evm_regulator_register(..), driver takes parameters of regulator node. I al=
so used id to select and to initialize regulator descriptors which are chip=
 specific. So far there is no comment about OF ID table so I kept it. I tho=
ught I need to add both of id table and platform id table as name matching =
is required to initialize platform device from mfd.
>
>--
>With Best Regards,
>Andy Shevchenko
>

Best Regards,
Okan Sahin