Date:   Tue, 31 Jan 2023 14:33:18 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Frank.Sae" <Frank.Sae@motor-comm.com>
Cc:     Rob Herring <robh@kernel.org>, Peter Geis <pgwipeout@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        yanhong.wang@starfivetech.com, xiaogang.fan@motor-comm.com,
        fei.zhang@motor-comm.com, hua.sun@motor-comm.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/5] dt-bindings: net: Add Motorcomm yt8xxx
 ethernet phy
Message-ID: <Y9kYnnYRMW9Vi0DU@lunn.ch>
References: <20230130063539.3700-1-Frank.Sae@motor-comm.com>
 <20230130063539.3700-2-Frank.Sae@motor-comm.com>
 <20230130224158.GA3655289-robh@kernel.org>
 <af6beebc-0a70-16f5-e0e9-5f4cbeea8955@motor-comm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <af6beebc-0a70-16f5-e0e9-5f4cbeea8955@motor-comm.com>
Precedence: bulk

> phy id list:
> YT8511	0x0000010a
> YT8521	0x0000011A
> YT8531  0x4f51e91b

The first two are clearly invalid, the OUI part is zero. So i would
not list those. Just use the last one.

In the binding part, you need something like

properties:
  compatible:
    const: ethernet-phy-id4f51.e91b
    description: Only needed for DT lint tools

What i don't know is how this will work in combination with the
compatibles gained from ethernet-phy.yaml. You might need to follow
the same structure, include a oneOf:

In the example part, you would do something like:
> 
>     mdio0 {
>         ...
>         ethernet-phy@5 {
	      # Only needed to make DT lint tools work. Do not copy/paste
	      # into real DTS files.
>             compatible = "ethernet-phy-id4f51.e91b";
>             reg = <5>;
>             ...
>         };
>     };

I don't think there are any examples to follow because the kernel
does not need any of this, is probes using the IDs. Listing
compatibles like this is purely for the DT tools, which is why i put
in the comments about not copy/pasting it to real DT blobs.

   Andrew