Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <Y9khL5lKbSG61pWI@gofer.mess.org>
Date:   Tue, 31 Jan 2023 18:11:57 +0400
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <38FDB059-5B8B-4885-AF4B-133F12995641@gmail.com>
References: <20230128034117.3983105-1-christianshewitt@gmail.com>
 <Y9khL5lKbSG61pWI@gofer.mess.org>
To:     Sean Young <sean@mess.org>
Precedence: bulk


> On 31 Jan 2023, at 6:09 pm, Sean Young <sean@mess.org> wrote:
>=20
> On Sat, Jan 28, 2023 at 03:41:17AM +0000, Christian Hewitt wrote:
>> Add a keymap and bindings for the simple IR (NEC) remote used with
>> the Beelink Mini MXIII Android STB device.
>>=20
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> .../devicetree/bindings/media/rc.yaml         |  1 +
>> drivers/media/rc/keymaps/Makefile             |  1 +
>> drivers/media/rc/keymaps/rc-beelink-mxiii.c   | 54 =
+++++++++++++++++++
>> include/media/rc-map.h                        |  1 +
>> 4 files changed, 57 insertions(+)
>> create mode 100644 drivers/media/rc/keymaps/rc-beelink-mxiii.c
>>=20
>> diff --git a/Documentation/devicetree/bindings/media/rc.yaml =
b/Documentation/devicetree/bindings/media/rc.yaml
>> index 266f1d5cae51..f390a5d2c82d 100644
>> --- a/Documentation/devicetree/bindings/media/rc.yaml
>> +++ b/Documentation/devicetree/bindings/media/rc.yaml
>> @@ -39,6 +39,7 @@ properties:
>>       - rc-avertv-303
>>       - rc-azurewave-ad-tu700
>>       - rc-beelink-gs1
>> +      - rc-beelink-mxiii
>>       - rc-behold
>>       - rc-behold-columbus
>>       - rc-budget-ci-old
>> diff --git a/drivers/media/rc/keymaps/Makefile =
b/drivers/media/rc/keymaps/Makefile
>> index ec0361b0b758..03bc9a8d355e 100644
>> --- a/drivers/media/rc/keymaps/Makefile
>> +++ b/drivers/media/rc/keymaps/Makefile
>> @@ -22,6 +22,7 @@ obj-$(CONFIG_RC_MAP) +=3D \
>> 			rc-avertv-303.o \
>> 			rc-azurewave-ad-tu700.o \
>> 			rc-beelink-gs1.o \
>> +			rc-beelink-mxiii.o \
>> 			rc-behold-columbus.o \
>> 			rc-behold.o \
>> 			rc-budget-ci-old.o \
>> diff --git a/drivers/media/rc/keymaps/rc-beelink-mxiii.c =
b/drivers/media/rc/keymaps/rc-beelink-mxiii.c
>> new file mode 100644
>> index 000000000000..09b77295e0a3
>> --- /dev/null
>> +++ b/drivers/media/rc/keymaps/rc-beelink-mxiii.c
>> @@ -0,0 +1,54 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +//
>> +// Copyright (C) 2019 Christian Hewitt <christianshewitt@gmail.com>
>> +
>> +#include <media/rc-map.h>
>> +#include <linux/module.h>
>> +
>> +//
>> +// Keytable for the Beelink Mini MXIII remote control
>> +//
>> +
>> +static struct rc_map_table beelink_mxiii[] =3D {
>> +	{ 0xb2dc, KEY_POWER },
>> +
>> +	{ 0xb288, KEY_MUTE },
>=20
> I'm guessing this is the mouse button. It should say so in a comment, =
if it
> is.

It=E2=80=99s not (for once). It=E2=80=99s a rather minimal remote. =
Nothing
as fancy as mouse support :)

Christian

> Thanks,
> Sean
>=20
>> +	{ 0xb282, KEY_HOME },
>> +
>> +	{ 0xb2ca, KEY_UP },
>> +	{ 0xb299, KEY_LEFT },
>> +	{ 0xb2ce, KEY_OK },
>> +	{ 0xb2c1, KEY_RIGHT },
>> +	{ 0xb2d2, KEY_DOWN },
>> +
>> +	{ 0xb2c5, KEY_MENU },
>> +	{ 0xb29a, KEY_BACK },
>> +
>> +	{ 0xb281, KEY_VOLUMEDOWN },
>> +	{ 0xb280, KEY_VOLUMEUP },
>> +};
>> +
>> +static struct rc_map_list beelink_mxiii_map =3D {
>> +	.map =3D {
>> +		.scan     =3D beelink_mxiii,
>> +		.size     =3D ARRAY_SIZE(beelink_mxiii),
>> +		.rc_proto =3D RC_PROTO_NEC,
>> +		.name     =3D RC_MAP_BEELINK_MXIII,
>> +	}
>> +};
>> +
>> +static int __init init_rc_map_beelink_mxiii(void)
>> +{
>> +	return rc_map_register(&beelink_mxiii_map);
>> +}
>> +
>> +static void __exit exit_rc_map_beelink_mxiii(void)
>> +{
>> +	rc_map_unregister(&beelink_mxiii_map);
>> +}
>> +
>> +module_init(init_rc_map_beelink_mxiii)
>> +module_exit(exit_rc_map_beelink_mxiii)
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Christian Hewitt <christianshewitt@gmail.com");
>> diff --git a/include/media/rc-map.h b/include/media/rc-map.h
>> index 5178dcae5ff7..dadd4d27a760 100644
>> --- a/include/media/rc-map.h
>> +++ b/include/media/rc-map.h
>> @@ -225,6 +225,7 @@ struct rc_map *rc_map_get(const char *name);
>> #define RC_MAP_AVERTV_303                "rc-avertv-303"
>> #define RC_MAP_AZUREWAVE_AD_TU700        "rc-azurewave-ad-tu700"
>> #define RC_MAP_BEELINK_GS1               "rc-beelink-gs1"
>> +#define RC_MAP_BEELINK_MXIII             "rc-beelink-mxiii"
>> #define RC_MAP_BEHOLD                    "rc-behold"
>> #define RC_MAP_BEHOLD_COLUMBUS           "rc-behold-columbus"
>> #define RC_MAP_BUDGET_CI_OLD             "rc-budget-ci-old"
>> --=20
>> 2.34.1